From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Fredrik Salomonsson <plattfot@gmail.com>
Cc: 41731@debbugs.gnu.org
Subject: [bug#41731] [PATCH] gnu: Add emacs-flymake-shellcheck.
Date: Sat, 06 Jun 2020 09:44:56 +0200 [thread overview]
Message-ID: <871rmsab9j.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20200605233349.140049-1-plattfot@gmail.com> (Fredrik Salomonsson's message of "Fri, 5 Jun 2020 16:33:49 -0700")
Hello,
Fredrik Salomonsson <plattfot@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable.
Thank you. Some comments follow.
> + (propagated-inputs
> + `(("shellcheck" ,shellcheck)))
I don't think we should do that. It is up to the user to install
ShellCheck if they want.
For example, installing `emacs-flycheck-haskell' doesn't pull GHC in
user's profile.
> + (home-page "https://github.com/federicotdn/flymake-shellcheck")
> + (synopsis "Flymake backend for Bash/Sh powered by ShellCheck")
> + (description
> + "This package provides a backend for Flymake (emacs-26+) to use the
Nitpick: you can remove the (emacs-26+) part.
> +tool @command{shellcheck} for static analyzing @command{bash} and @command{sh}
Nitpick: since you seem to talk about the tool as a whole, I suggest:
@command{shellcheck} -> ShellCheck
> +scripts. Please see the description on @command{shellcheck} for more
> +information on what it can do."
I think you can remove the last sentence.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-06-06 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 23:33 [bug#41731] [PATCH] gnu: Add emacs-flymake-shellcheck Fredrik Salomonsson
2020-06-06 7:44 ` Nicolas Goaziou [this message]
2020-06-06 16:55 ` Fredrik Salomonsson
2020-06-06 16:58 ` Fredrik Salomonsson via web
2020-06-07 19:22 ` bug#41731: " Nicolas Goaziou
2020-06-06 17:01 ` [bug#41731] " Fredrik Salomonsson
2020-06-06 17:04 ` Fredrik Salomonsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rmsab9j.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41731@debbugs.gnu.org \
--cc=plattfot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.