From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GlB5CC1b3l7tUAAA0tVLHw (envelope-from ) for ; Mon, 08 Jun 2020 15:37:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SGirAy1b3l4MfwAAbx9fmQ (envelope-from ) for ; Mon, 08 Jun 2020 15:37:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 97F3C940602 for ; Mon, 8 Jun 2020 15:37:16 +0000 (UTC) Received: from localhost ([::1]:50000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiJpr-0002Hz-JE for larch@yhetil.org; Mon, 08 Jun 2020 11:37:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiJoh-0001Ce-0y for guix-patches@gnu.org; Mon, 08 Jun 2020 11:36:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiJog-0002cx-Hd for guix-patches@gnu.org; Mon, 08 Jun 2020 11:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jiJog-0005gt-Fj for guix-patches@gnu.org; Mon, 08 Jun 2020 11:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#35305] LightDM service Resent-From: L p R n d n Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Jun 2020 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35305 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ricardo Wurmus Cc: brice@waegenei.re, 35305@debbugs.gnu.org Received: via spool by 35305-submit@debbugs.gnu.org id=B35305.159163052621819 (code B ref 35305); Mon, 08 Jun 2020 15:36:02 +0000 Received: (at 35305) by debbugs.gnu.org; 8 Jun 2020 15:35:26 +0000 Received: from localhost ([127.0.0.1]:57657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiJo6-0005fr-6a for submit@debbugs.gnu.org; Mon, 08 Jun 2020 11:35:26 -0400 Received: from mout02.posteo.de ([185.67.36.142]:41721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiJo3-0005fT-Sa for 35305@debbugs.gnu.org; Mon, 08 Jun 2020 11:35:24 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C60912400FE for <35305@debbugs.gnu.org>; Mon, 8 Jun 2020 17:35:16 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49gcl72My3z6tm5; Mon, 8 Jun 2020 17:35:15 +0200 (CEST) From: L p R n d n References: <87zhooso9g.fsf@lprndn.info> <87imh9gnvy.fsf@lprndn.info> <87k11m2hqx.fsf@elephly.net> <87zhahcfgh.fsf@lprndn.info> <878shz38bf.fsf@elephly.net> <87o8qtzd71.fsf@lprndn.info> <87k116e3ee.fsf@elephly.net> <87tv09zo70.fsf@lprndn.info> <87h7w9ej4w.fsf@elephly.net> Date: Mon, 08 Jun 2020 17:35:14 +0200 In-Reply-To: <87h7w9ej4w.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 21 May 2020 11:23:43 +0200") Message-ID: <871rmp4ll9.fsf@lprndn.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.6 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.49 X-TUID: T6yDeJve+S8t Hello, I spent some time thinking about the lightdm service and what are our possibilities so here are my thoughts and conclusions. (Here, I'll only describe relations between seats, greeters and the lightdm service as it's our main source of problems) So if we get rid of the greeter's services, we can have: 1: (service lightd-service-type (lightdm-configuration (greeters (list (lightdm-gtk-greeter-configuration (seats (list (lightdm-seat-configuration ...)))))))) Here seats are defined by greeters. This way the user doesn't need to fill `greeter-session field as we can do it automatically. But there's a lo= t of nesting (and two lists.) + How do we define autologin? 2: (service lightd-service-type (lightdm-configuration (seats (list (lightdm-seat-configuration (greeter-session (lightdm-gtk-greeter-configuration ...))))))) Defining greeters inside seats allows in the `greeter-session field make it a little simpler. However, we would get errors or conflicts if a user define two different configurations of the same greeter for two different seats. The thing is that we can only have one configuration per greeter as it will always look for a hardcoded file in /etc/ (worst case) or a file we hardcoded at build time (best case). :/ 3: (service lightd-service-type (lightdm-configuration (seats (list (lightdm-seat-configuration (greeter-session 'lightdm-gtk-greeter)))) (greeters (list (lightdm-gtk-greeter-configuration ))))) We can have separate fields for greeters and seats. The user will have to define `greeter-session by himself. And what happen if they define multiple occurences of one greeter's configuration? So my conclusion is that the current implementation using a different servi= ce for lightdm and its greeters is probably not so bad as it prevents most of these issues. Unless someone has an even better idea, indeed. :D Ricardo Wurmus writes: > L p R n d n writes: > >> Hello, >> >> Ricardo Wurmus writes: [...] > Right, I realized this after composing my message. However, currently > the lightdm-gtk-greeter-service-type inherits all the seats and then > overrides the greeter-session value for each of them, which seems rather > rude. So maybe it is wrong to let greeters do that at all. > > I wondered why there=E2=80=99s a service type for the greeter at all, so I > looked at the service extensions it provides: > > * lightdm-service-type: only used to override greeter-session in all > defined seats, which seems like an anti-feature. If other greeters > do the same, then effectively there can only be one greeter for all > seats, and that would be wrong. So seat configuration really should > remain in lightdm-service-type and not be an extension. As disussed on IRC, a greeter service only overwrites its own `greeter-session field. But we could get rid of the `greeter-session field altogether as it's probably not necessary if they're filled by the greeters' service or record (depending of what we choose). > * etc-service-type: that=E2=80=99s to provide the greeter=E2=80=99s globa= l configuration > file. Ideally, we would not need to use a global configuration file. > It looks like lightdm-gtk-greeter respects the XDG_CONFIG_DIRS > variable, so we should be able to generate its configuration file in > an arbitrary location and then add it to XDG_CONFIG_DIRS in the > environment of lightdm itself. I didn't find any informations about lightdm-gtk-greeter using XDG_CONFIG_DIRS. Could you provide further explaination as it could impact what I wrote earlier. > * profile-service-type: that=E2=80=99s to install lightdm-gtk-greeter and= its > assets into the system profile. Again, that=E2=80=99s something we sho= uld aim > to avoid. It seems that we can avoid it with the use of environment > variables in the lightdm shepherd service. Yeah ;) > If we can avoid all three extensions then we don=E2=80=99t need a > lightdm-gtk-greeter-service-type at all. If we don=E2=80=99t need a serv= ice we > can specify greeters as record type values with a name and configuration > file generator. Hope it's clear, I'm really just dumping my thoughts... :) Please tell me what you think. Have a nice day, L p R n d n