all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
@ 2020-07-25  2:04 Joseph LaFreniere
  2020-07-25  2:10 ` [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra Joseph LaFreniere
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Joseph LaFreniere @ 2020-07-25  2:04 UTC (permalink / raw)
  To: 42525

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Patch file is attached.  Note that `guix lint` reports "the source 
file name should contain the package name";  I'm not sure how to 
resolve that.

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-pretty-hydra.patch --]
[-- Type: text/x-patch, Size: 3128 bytes --]

From 512be2f3fd8cfcaa6014bcfa63f635c66135a05f Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Sat, 18 Jul 2020 12:49:15 -0500
Subject: [PATCH 1/2] gnu: Add emacs-pretty-hydra.

* gnu/packages/emacs-xyz.scm (emacs-pretty-hydra): New variable.
---
 gnu/packages/emacs-xyz.scm | 56 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 55afda50df..147c6b476b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -649,6 +649,34 @@ process, passing on the arguments as command line arguments.")
        "Magit-annex adds a few git-annex operations to the Magit interface.")
       (license license:gpl3+))))
 
+(define-public emacs-pretty-hydra
+  (package
+    (name "emacs-pretty-hydra")
+    (version "0.2.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jerrypnz/major-mode-hydra.el")
+             (commit version)))
+       (sha256
+        (base32
+         "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-hydra" ,emacs-hydra)
+       ("emacs-s" ,emacs-s)))
+    (arguments
+     `(#:install '("^pretty-hydra\\.el$")))
+    (home-page "https://github.com/jerrypnz/major-mode-hydra.el")
+    (synopsis "Major mode keybindings managed by Hydra")
+    (description
+     "This package offers an hydra-based method of managing major
+mode-specific key bindings.  It is intended for use as a library only; see
+package @code{emacs-major-mode-hydra} for a user-friendly interface.")
+    (license license:gpl3+)))
+
 (define-public emacs-minions
   (package
     (name "emacs-minions")
@@ -6148,6 +6176,34 @@ them easier to distinguish from other, less important buffers.")
 for Ivy and Company that make use of the library.")
     (license license:expat)))
 
+(define-public emacs-pretty-hydra
+  (package
+    (name "emacs-pretty-hydra")
+    (version "0.2.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jerrypnz/major-mode-hydra.el.git")
+             (commit version)))
+       (sha256
+        (base32
+         "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-hydra" ,emacs-hydra)
+       ("emacs-s" ,emacs-s)))
+    (arguments
+     `(#:exclude (cons "^major-mode-hydra\\.el" %default-exclude)))
+    (home-page "https://github.com/jerrypnz/major-mode-hydra.el")
+    (synopsis "Major mode keybindings managed by Hydra")
+    (description
+     "This package offers an hydra-based method of managing major
+mode-specific key bindings.  It is intended for use as a library only; see
+package @code{emacs-major-mode-hydra} for a user-friendly interface.")
+    (license license:gpl3+)))
+
 (define-public emacs-selectrum
   (package
     (name "emacs-selectrum")
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
  2020-07-25  2:04 [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Joseph LaFreniere
@ 2020-07-25  2:10 ` Joseph LaFreniere
  2020-07-25 13:28   ` Oleg Pykhalov
  2020-07-25 13:20 ` [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Oleg Pykhalov
  2020-07-26 14:04 ` Nicolas Goaziou
  2 siblings, 1 reply; 10+ messages in thread
From: Joseph LaFreniere @ 2020-07-25  2:10 UTC (permalink / raw)
  To: 42525

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

Patch file is attached.  Similar to the first patch in this 
series, `guix lint` reports "the source file name should contain 
the package name".

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-emacs-major-mode-hydra.patch --]
[-- Type: text/x-patch, Size: 1310 bytes --]

From 0e528063cdc3a768059cb0be5c8430506b756b6e Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Sat, 18 Jul 2020 12:50:22 -0500
Subject: [PATCH 2/2] gnu: Add emacs-major-mode-hydra.

* gnu/packages/emacs-xyz.scm (emacs-major-mode-hydra): New variable.
---
 gnu/packages/emacs-xyz.scm | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 147c6b476b..649f856a83 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -677,6 +677,20 @@ mode-specific key bindings.  It is intended for use as a library only; see
 package @code{emacs-major-mode-hydra} for a user-friendly interface.")
     (license license:gpl3+)))
 
+(define-public emacs-major-mode-hydra
+  (package
+    (inherit emacs-pretty-hydra)
+    (name "emacs-major-mode-hydra")
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-pretty-hydra" ,emacs-pretty-hydra)))
+    (arguments
+     `(#:include '("^major-mode-hydra\\.el$")))
+    (synopsis "Create nice-looking hydras")
+    (description
+     "This package provides the macro @code{pretty-hydra-define} to define
+hydras with one column per group of heads.")))
+
 (define-public emacs-minions
   (package
     (name "emacs-minions")
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
  2020-07-25  2:04 [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Joseph LaFreniere
  2020-07-25  2:10 ` [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra Joseph LaFreniere
@ 2020-07-25 13:20 ` Oleg Pykhalov
  2020-07-25 14:57   ` LaFreniere, Joseph
  2020-07-26 14:04 ` Nicolas Goaziou
  2 siblings, 1 reply; 10+ messages in thread
From: Oleg Pykhalov @ 2020-07-25 13:20 UTC (permalink / raw)
  To: Joseph LaFreniere; +Cc: 42525

[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]

Hi Joseph,

Joseph LaFreniere <joseph@lafreniere.xyz> writes:

> Patch file is attached.  Note that `guix lint` reports "the source file name
> should contain the package name";  I'm not sure how to resolve that.

You could fix this by providing a ‘(file-name (git-file-name name
version))’ as in other Emacs packages.

[…]

> * gnu/packages/emacs-xyz.scm (emacs-pretty-hydra): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 56 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 55afda50df..147c6b476b 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -649,6 +649,34 @@ process, passing on the arguments as command line arguments.")
>         "Magit-annex adds a few git-annex operations to the Magit interface.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-pretty-hydra
> +  (package
> +    ...
> +    (arguments
> +     `(#:install '("^pretty-hydra\\.el$")))

'emacs-build-system' handles '*.el' files, unless you exclude them with
the recipe bellow.  :-)

[…]


The following duplicates emacs-pretty-hydra above.

> +(define-public emacs-pretty-hydra
> +  (package
> +    (name "emacs-pretty-hydra")
> +    (version "0.2.2")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/jerrypnz/major-mode-hydra.el.git")
> +             (commit version)))
> +       (sha256
> +        (base32
> +         "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-hydra" ,emacs-hydra)
> +       ("emacs-s" ,emacs-s)))
> +    (arguments
> +     `(#:exclude (cons "^major-mode-hydra\\.el" %default-exclude)))

As I see there is no reason to exclude or include '*.el'.


Also could you take a look on running a test suite?

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
  2020-07-25  2:10 ` [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra Joseph LaFreniere
@ 2020-07-25 13:28   ` Oleg Pykhalov
  2020-07-25 15:02     ` LaFreniere, Joseph
  0 siblings, 1 reply; 10+ messages in thread
From: Oleg Pykhalov @ 2020-07-25 13:28 UTC (permalink / raw)
  To: Joseph LaFreniere; +Cc: 42525

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

Joseph LaFreniere <joseph@lafreniere.xyz> writes:

> Patch file is attached.  Similar to the first patch in this series, `guix
> lint` reports "the source file name should contain the package name".

Yes, because emacs-major-mode-hydra inherits emacs-pretty-hydra.


Does emacs-major-mode-hydra is useful without emacs-pretty-hydra and
vice versa?

I guess not, in that case we could just have emacs-pretty-hydra
containing '*.el' for both.

[…]

> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 147c6b476b..649f856a83 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -677,6 +677,20 @@ mode-specific key bindings.  It is intended for use as a library only; see
>  package @code{emacs-major-mode-hydra} for a user-friendly interface.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-major-mode-hydra
> +  (package
> +    ...
> +    (arguments
> +     `(#:include '("^major-mode-hydra\\.el$")))
> +    (synopsis "Create nice-looking hydras")

Could you extend the synopsis little bit? ;-)

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
  2020-07-25 13:20 ` [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Oleg Pykhalov
@ 2020-07-25 14:57   ` LaFreniere, Joseph
  2020-07-25 15:05     ` LaFreniere, Joseph
  2020-07-25 18:34     ` Oleg Pykhalov
  0 siblings, 2 replies; 10+ messages in thread
From: LaFreniere, Joseph @ 2020-07-25 14:57 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: Joseph LaFreniere, 42525

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]


Oleg Pykhalov <go.wigust@gmail.com> writes:
> Joseph LaFreniere <joseph@lafreniere.xyz> writes:
>
>> Patch file is attached.  Note that `guix lint` reports "the 
>> source file name
>> should contain the package name";  I'm not sure how to resolve 
>> that.
>
> You could fix this by providing a ‘(file-name (git-file-name 
> name
> version))’ as in other Emacs packages.

Thanks.  Not sure how I missed that.

> 'emacs-build-system' handles '*.el' files, unless you exclude 
> them with
> the recipe bellow.  :-)

Thank you for the tip.  I have changed the include to an exclude.

> Also could you take a look on running a test suite?

The repo's test suite tests both pretty-hydra and 
major-mode-hydra.  Since major-mode-hydra is inheriting from and 
depends on this recipe, I'm assuming it would be rebuilt any time 
the pretty-hydra recipe changes.  Just to minimize the amount of 
work prying apart the repository I have left all of the tests to 
be run in the recipe for major-mode-hydra.  The updated patch for 
that will be following shortly.

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-pretty-hydra.patch --]
[-- Type: text/x-patch, Size: 1790 bytes --]

From a08a763c0a7aa09349bdc9e65ac2d27a3c640a54 Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Sat, 18 Jul 2020 12:49:15 -0500
Subject: [PATCH 1/2] gnu: Add emacs-pretty-hydra.

* gnu/packages/emacs-xyz.scm (emacs-pretty-hydra): New variable.
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index db395361b9..c11959dbe2 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -649,6 +649,33 @@ process, passing on the arguments as command line arguments.")
        "Magit-annex adds a few git-annex operations to the Magit interface.")
       (license license:gpl3+))))
 
+(define-public emacs-pretty-hydra
+  (package
+    (name "emacs-pretty-hydra")
+    (version "0.2.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jerrypnz/major-mode-hydra.el")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-hydra" ,emacs-hydra)
+       ("emacs-s" ,emacs-s)))
+    (arguments
+     `(#:exclude (cons "^major-mode-hydra\\.el" %default-exclude)))
+    (home-page "https://github.com/jerrypnz/major-mode-hydra.el")
+    (synopsis "Create nice-looking hydras")
+    (description
+     "This package provides the macro @code{pretty-hydra-define} to define
+hydras with one column per group of heads.")
+    (license license:gpl3+)))
+
 (define-public emacs-minions
   (package
     (name "emacs-minions")
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
  2020-07-25 13:28   ` Oleg Pykhalov
@ 2020-07-25 15:02     ` LaFreniere, Joseph
  2020-12-18 13:24       ` bug#42525: " Ludovic Courtès
  0 siblings, 1 reply; 10+ messages in thread
From: LaFreniere, Joseph @ 2020-07-25 15:02 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 42525

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

Thank you for the reviews, Oleg.  :)

Oleg Pykhalov <go.wigust@gmail.com> writes:
> Joseph LaFreniere <joseph@lafreniere.xyz> writes:
>
>> Patch file is attached.  Similar to the first patch in this 
>> series, `guix
>> lint` reports "the source file name should contain the package 
>> name".
>
> Yes, because emacs-major-mode-hydra inherits emacs-pretty-hydra.

Fixed in the updated patch for emacs-pretty-hydra.

> Does emacs-major-mode-hydra is useful without emacs-pretty-hydra 
> and
> vice versa?
>
> I guess not, in that case we could just have emacs-pretty-hydra
> containing '*.el' for both.

Yes, emacs-pretty-hydra is useful independently of 
emacs-major-mode-hydra.  The descriptions in the initial patches 
were written a long time ago and were misleading.  I apologize for 
the confusion.

> Could you extend the synopsis little bit? ;-)

Missed this comment in the updated patch for emacs-pretty-hydra 
that I just sent.  I will revisit it following this mail.  Is the 
synopsis for this recipe (emacs-major-mode-hyra) suitable?

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-emacs-major-mode-hydra.patch --]
[-- Type: text/x-patch, Size: 1460 bytes --]

From 01cec639c237f582a9e4ecbfec1f483009bbba36 Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Sat, 18 Jul 2020 12:50:22 -0500
Subject: [PATCH 2/2] gnu: Add emacs-major-mode-hydra.

* gnu/packages/emacs-xyz.scm (emacs-major-mode-hydra): New variable.
---
 gnu/packages/emacs-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c11959dbe2..195586ca71 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -676,6 +676,25 @@ process, passing on the arguments as command line arguments.")
 hydras with one column per group of heads.")
     (license license:gpl3+)))
 
+(define-public emacs-major-mode-hydra
+  (package
+    (inherit emacs-pretty-hydra)
+    (name "emacs-major-mode-hydra")
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-pretty-hydra" ,emacs-pretty-hydra)))
+    (native-inputs
+     `(("emacs-ert-runner" ,emacs-ert-runner)
+       ("emacs-use-package" ,emacs-use-package) ))
+    (arguments
+     `(#:exclude (cons "^pretty-hydra\\.el$" %default-exclude)
+       #:tests? #t
+       #:test-command '("ert-runner")))
+    (synopsis "Major mode keybindings managed by Hydra")
+    (description
+     "This package offers a hydra-based method of managing major mode-specific
+key bindings.")))
+
 (define-public emacs-minions
   (package
     (name "emacs-minions")
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
  2020-07-25 14:57   ` LaFreniere, Joseph
@ 2020-07-25 15:05     ` LaFreniere, Joseph
  2020-07-25 18:34     ` Oleg Pykhalov
  1 sibling, 0 replies; 10+ messages in thread
From: LaFreniere, Joseph @ 2020-07-25 15:05 UTC (permalink / raw)
  To: Oleg Pykhalov, 42525

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]


LaFreniere, Joseph <joseph@lafreniere.xyz> writes:
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>> Joseph LaFreniere <joseph@lafreniere.xyz> writes:
>>
>>> Patch file is attached.  Note that `guix lint` reports "the
>>> source file name
>>> should contain the package name";  I'm not sure how to resolve
>>> that.
>>
>> You could fix this by providing a ‘(file-name (git-file-name
>> name
>> version))’ as in other Emacs packages.
>
> Thanks.  Not sure how I missed that.
>
>> 'emacs-build-system' handles '*.el' files, unless you exclude
>> them with
>> the recipe bellow.  :-)
>
> Thank you for the tip.  I have changed the include to an 
> exclude.
>
>> Also could you take a look on running a test suite?
>
> The repo's test suite tests both pretty-hydra and
> major-mode-hydra.  Since major-mode-hydra is inheriting from and
> depends on this recipe, I'm assuming it would be rebuilt any 
> time
> the pretty-hydra recipe changes.  Just to minimize the amount of
> work prying apart the repository I have left all of the tests to
> be run in the recipe for major-mode-hydra.  The updated patch 
> for
> that will be following shortly.

An updated patch for emacs-pretty-hydra is attached with an 
expanded synopsis.

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-pretty-hydra.patch --]
[-- Type: text/x-patch, Size: 1813 bytes --]

From f837604e2a8f405e9e6a9473492be56fc3db004d Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Sat, 18 Jul 2020 12:49:15 -0500
Subject: [PATCH 1/2] gnu: Add emacs-pretty-hydra.

* gnu/packages/emacs-xyz.scm (emacs-pretty-hydra): New variable.
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index db395361b9..12f295a1c1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -649,6 +649,33 @@ process, passing on the arguments as command line arguments.")
        "Magit-annex adds a few git-annex operations to the Magit interface.")
       (license license:gpl3+))))
 
+(define-public emacs-pretty-hydra
+  (package
+    (name "emacs-pretty-hydra")
+    (version "0.2.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jerrypnz/major-mode-hydra.el")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-hydra" ,emacs-hydra)
+       ("emacs-s" ,emacs-s)))
+    (arguments
+     `(#:exclude (cons "^major-mode-hydra\\.el" %default-exclude)))
+    (home-page "https://github.com/jerrypnz/major-mode-hydra.el")
+    (synopsis "Create hydras with one column per group of heads.")
+    (description
+     "This package provides the macro @code{pretty-hydra-define} to define
+hydras with one column per group of heads.")
+    (license license:gpl3+)))
+
 (define-public emacs-minions
   (package
     (name "emacs-minions")
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
  2020-07-25 14:57   ` LaFreniere, Joseph
  2020-07-25 15:05     ` LaFreniere, Joseph
@ 2020-07-25 18:34     ` Oleg Pykhalov
  1 sibling, 0 replies; 10+ messages in thread
From: Oleg Pykhalov @ 2020-07-25 18:34 UTC (permalink / raw)
  To: LaFreniere, Joseph; +Cc: 42525

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

"LaFreniere, Joseph" <joseph@lafreniere.xyz> writes:

[…]

>> Also could you take a look on running a test suite?
>
> The repo's test suite tests both pretty-hydra and major-mode-hydra.  Since
> major-mode-hydra is inheriting from and depends on this recipe, I'm assuming
> it would be rebuilt any time the pretty-hydra recipe changes.  Just to
> minimize the amount of work prying apart the repository I have left all of the
> tests to be run in the recipe for major-mode-hydra.  

Yes, it will, that's a feature of Guix.  ;-)

The ‘test’ directory contains ‘major-mode-hydra-test.el’ and
‘pretty-hydra-test.el’ which could be runned by themself AFAICC.  In
that case, if somebody will need to change ‘pretty-hydra’ recipe, he
will run the test and be sure the package functions as intended.  Would
you like take a look on this, please?

> The updated patch for that will be following shortly.

We don't hurry. ;-) Also, you don't need to attach a patch if you are
working on a thing and will send another one in a day.

Regards,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
  2020-07-25  2:04 [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Joseph LaFreniere
  2020-07-25  2:10 ` [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra Joseph LaFreniere
  2020-07-25 13:20 ` [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Oleg Pykhalov
@ 2020-07-26 14:04 ` Nicolas Goaziou
  2 siblings, 0 replies; 10+ messages in thread
From: Nicolas Goaziou @ 2020-07-26 14:04 UTC (permalink / raw)
  To: Joseph LaFreniere; +Cc: 42525

Hello,

Joseph LaFreniere <joseph@lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> Note that `guix lint` reports "the source file name should contain the
> package name"; I'm not sure how to resolve that.

You are missing a

  (file-name (git-file-name name version))

expression in `origin'.

> +(define-public emacs-pretty-hydra
> +  (package
> +    (name "emacs-pretty-hydra")
> +    (version "0.2.2")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/jerrypnz/major-mode-hydra.el")
> +             (commit version)))
> +       (sha256
> +        (base32
> +         "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa"))))

Nitpick: please move the string on the same line as `base32'.

> +    (build-system emacs-build-system)

There are some tests using ert-runner. Could you try to enable them?

> +    (propagated-inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-hydra" ,emacs-hydra)
> +       ("emacs-s" ,emacs-s)))
> +    (arguments
> +     `(#:install '("^pretty-hydra\\.el$")))
> +    (home-page "https://github.com/jerrypnz/major-mode-hydra.el")
> +    (synopsis "Major mode keybindings managed by Hydra")
> +    (description
> +     "This package offers an hydra-based method of managing major
> +mode-specific key bindings.  It is intended for use as a library only; see
> +package @code{emacs-major-mode-hydra} for a user-friendly interface.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-minions
>    (package
>      (name "emacs-minions")
> @@ -6148,6 +6176,34 @@ them easier to distinguish from other, less important buffers.")
>  for Ivy and Company that make use of the library.")
>      (license license:expat)))
>  
> +(define-public emacs-pretty-hydra

You added the package twice.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#42525: [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
  2020-07-25 15:02     ` LaFreniere, Joseph
@ 2020-12-18 13:24       ` Ludovic Courtès
  0 siblings, 0 replies; 10+ messages in thread
From: Ludovic Courtès @ 2020-12-18 13:24 UTC (permalink / raw)
  To: LaFreniere, Joseph; +Cc: 42525-done

Both patches were applied some time ago in
90eb5dd6b5989eeb5350c785036c53469496e394.

Closing!

Ludo’.




^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-12-18 13:26 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-25  2:04 [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Joseph LaFreniere
2020-07-25  2:10 ` [bug#42525] [PATCH 2/2] gnu: Add emacs-major-mode-hydra Joseph LaFreniere
2020-07-25 13:28   ` Oleg Pykhalov
2020-07-25 15:02     ` LaFreniere, Joseph
2020-12-18 13:24       ` bug#42525: " Ludovic Courtès
2020-07-25 13:20 ` [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra Oleg Pykhalov
2020-07-25 14:57   ` LaFreniere, Joseph
2020-07-25 15:05     ` LaFreniere, Joseph
2020-07-25 18:34     ` Oleg Pykhalov
2020-07-26 14:04 ` Nicolas Goaziou

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.