On 2020-10-01, Denis Carikli wrote:
> I'd like to send a patch to add a bootloader (u-boot) package for a
> single board computer. The patch is trivial and it's already
> ready.

Great!


> However before sending the patch, I'm supposed to build it within Guix
> source code and to test it.

Can't help with that part right now...


> From 06a9dc65588a1b56add1188ba14fd5985a8a26d0 Mon Sep 17 00:00:00 2001
> From: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> Date: Sun, 27 Sep 2020 01:07:44 +0200
> Subject: [PATCH] gnu: Add u-boot-beagleboard.
>
> * gnu/packages/bootloaders (u-boot-beagleboard): New variable.
> * gnu/bootloader/u-boot (install-beagleboard-u-boot): New variable.
>   (u-boot-beagleboard-bootloader): New variable.
> * gnu/system/install (define beagleboard-installation-os): New variable.
...
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index d1de5cea4e..2b90fab895 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
> @@ -685,6 +685,9 @@ it fits within common partitioning schemes.")
>  (define-public u-boot-am335x-evm
>    (make-u-boot-package "am335x_evm" "arm-linux-gnueabihf"))
>  
> +(define-public u-boot-beagleboard
> +  (make-u-boot-package "omap3_beagle" "arm-linux-gnueabihf"))
> +

This package and related variables should be named
"u-boot-omap3-beagle". I think most u-boot targets follow this
convention(naming it after the defconfig target), so it would keep
naming consistent.

Maybe make-u-boot-package should be extended to support passing a list
of "common" names for boards, which could then be appended to the
description?


live well,
  vagrant