From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gAAWBWe2jV+9UQAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 15:53:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UBYCAWe2jV/uCQAAbx9fmQ (envelope-from ) for ; Mon, 19 Oct 2020 15:53:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D4A99404C5 for ; Mon, 19 Oct 2020 15:53:10 +0000 (UTC) Received: from localhost ([::1]:51498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUXTA-0002IK-MN for larch@yhetil.org; Mon, 19 Oct 2020 11:53:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUXT4-0002I7-9J for bug-guix@gnu.org; Mon, 19 Oct 2020 11:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58752) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUXT4-0008Bb-0L for bug-guix@gnu.org; Mon, 19 Oct 2020 11:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUXT3-0005P0-UR for bug-guix@gnu.org; Mon, 19 Oct 2020 11:53:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 19 Oct 2020 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Received: via spool by 44027-submit@debbugs.gnu.org id=B44027.160312272720703 (code B ref 44027); Mon, 19 Oct 2020 15:53:01 +0000 Received: (at 44027) by debbugs.gnu.org; 19 Oct 2020 15:52:07 +0000 Received: from localhost ([127.0.0.1]:42065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUXSB-0005Nr-4K for submit@debbugs.gnu.org; Mon, 19 Oct 2020 11:52:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUXS8-0005NN-F9 for 44027@debbugs.gnu.org; Mon, 19 Oct 2020 11:52:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36432) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUXRz-00085N-VX; Mon, 19 Oct 2020 11:51:56 -0400 Received: from [2a01:e0a:19b:d9a0:6d9b:8bf5:86c1:cec2] (port=38612 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUXRz-00010c-J9; Mon, 19 Oct 2020 11:51:55 -0400 From: Mathieu Othacehe In-Reply-To: <87pn5enygh.fsf@gmail.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Mon, 19 Oct 2020 15:21:18 +0200") References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> <87imb7zctc.fsf@gnu.org> <87pn5emqzc.fsf@gnu.org> <87pn5enygh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Mon, 19 Oct 2020 17:51:54 +0200 Message-ID: <871rhukycl.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44027@debbugs.gnu.org, Brendan Tildesley Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: zRzN+chpgrCi Hello Miguel, > Is there any other issue remaining? It doesn't modify this logic at > all. Should I apply this patch to master then? Yes, your patch LGTM. Please make sure that system tests are still working by running: --8<---------------cut here---------------start------------->8--- make check-system TESTS="gui-installed-os gui-installed-os-encrypted gui-installed-desktop-os-encrypted" --8<---------------cut here---------------end--------------->8--- Thanks, Mathieu