From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eErWNKKdkV+cJwAA0tVLHw (envelope-from ) for ; Thu, 22 Oct 2020 14:56:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SD08L6KdkV+WQgAA1q6Kng (envelope-from ) for ; Thu, 22 Oct 2020 14:56:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 69F199400C9 for ; Thu, 22 Oct 2020 14:56:34 +0000 (UTC) Received: from localhost ([::1]:50144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVc12-0000cT-UY for larch@yhetil.org; Thu, 22 Oct 2020 10:56:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVc0Z-0000an-0f for guix-patches@gnu.org; Thu, 22 Oct 2020 10:56:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVc0Y-0007fh-JN for guix-patches@gnu.org; Thu, 22 Oct 2020 10:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVc0Y-0008Us-Ic for guix-patches@gnu.org; Thu, 22 Oct 2020 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43781] [PATCH 2/2] gnu: Add cgoban Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Oct 2020 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43781 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?= Cc: 43781@debbugs.gnu.org Received: via spool by 43781-submit@debbugs.gnu.org id=B43781.160337855232646 (code B ref 43781); Thu, 22 Oct 2020 14:56:02 +0000 Received: (at 43781) by debbugs.gnu.org; 22 Oct 2020 14:55:52 +0000 Received: from localhost ([127.0.0.1]:53480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVc0N-0008UT-U5 for submit@debbugs.gnu.org; Thu, 22 Oct 2020 10:55:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVc0L-0008UF-RG for 43781@debbugs.gnu.org; Thu, 22 Oct 2020 10:55:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44566) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVc0E-0007XZ-UE; Thu, 22 Oct 2020 10:55:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=51364 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVc0D-0001jQ-9v; Thu, 22 Oct 2020 10:55:42 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <9f324abb-f935-b748-526b-467113e87670@mailbox.org> Date: Thu, 22 Oct 2020 16:55:38 +0200 In-Reply-To: <9f324abb-f935-b748-526b-467113e87670@mailbox.org> ("=?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?="'s message of "Sat, 3 Oct 2020 21:05:46 +0200") Message-ID: <871rhqtimt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: /WxEBqERQkG/ Hi, Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez skribis: > Sorry, I see I should have sent it all in one email. > > * gnu/packages/games.scm (cgoban): New variable. Sorry for the delay! Some comments: > + (arguments > + `(#:tests? #t)) Please add a short comment explaining why tests are disabled. > --- /dev/null > +++ b/gnu/packages/patches/cgoban-1.9.14-cflags.patch > @@ -0,0 +1,40 @@ > +--- a/configure.in > ++++ b/configure.in Patches should start with a couple lines stating the origin, their upstream status, and what they do. Patches also need to be listed in =E2=80=98gnu/local.mk=E2=80=99 and mentio= ned in the commit log. However, I suspect this patch has no effect: since =E2=80=98autoconf=E2=80= =99 is not an input of the package, its =E2=80=98configure=E2=80=99 script cannot be rebu= ilt to take those changes into account. Perhaps you can just remove it? Could you send a second version? Thanks! Ludo=E2=80=99.