From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CDpiGkKYs1+oUQAA0tVLHw (envelope-from ) for ; Tue, 17 Nov 2020 09:30:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UJtTFkKYs18IDQAA1q6Kng (envelope-from ) for ; Tue, 17 Nov 2020 09:30:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CB5B940538 for ; Tue, 17 Nov 2020 09:30:42 +0000 (UTC) Received: from localhost ([::1]:33000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kexJx-0004Xd-2D for larch@yhetil.org; Tue, 17 Nov 2020 04:30:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kexJj-0004X2-GX for guix-devel@gnu.org; Tue, 17 Nov 2020 04:30:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51299) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kexJi-00024w-Nt; Tue, 17 Nov 2020 04:30:26 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54042 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kexJh-0008Kz-V8; Tue, 17 Nov 2020 04:30:26 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: GNU Guix 1.2.0rc1 available for testing! References: <87d00hchij.fsf@gnu.org> <20201115191618.zuvkz65o3kcahfoz@pelzflorian.localdomain> <874klqb82u.fsf@gnu.org> <20201115231643.7mslq2sjzliv4nfd@pelzflorian.localdomain> <87v9e5ll7a.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Nov 2020 10:30:24 +0100 In-Reply-To: <87v9e5ll7a.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 16 Nov 2020 10:12:09 +0100") Message-ID: <871rgstjnz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: F0pBsxm/Wwwf Hi Mathieu, Mathieu Othacehe skribis: > From 6fec27303d0f8767ed48c507af67908a0fcf17a0 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Mon, 16 Nov 2020 10:10:56 +0100 > Subject: [PATCH] Increase device use delay. > > --- > gnu/installer/parted.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm > index f2352c5779..ed3af6af85 100644 > --- a/gnu/installer/parted.scm > +++ b/gnu/installer/parted.scm > @@ -318,7 +318,7 @@ PARTED-OBJECT field equals PARTITION, return #f if no= t found." > fail. See rereadpt function in wipefs.c of util-linux for an explanation= ." > ;; Kernel always return EINVAL for BLKRRPART on loopdevices. > (and (not (string-match "/dev/loop*" file-name)) > - (let loop ((try 4)) > + (let loop ((try 16)) > (usleep 250000) > (let ((in-use? (device-in-use? file-name))) > (if (and in-use? (> try 0)) Should we go ahead and apply this one? Not polling would be nicer, but maybe there=E2=80=99s no real way to do that? BTW: (string-match "/dev/loop*" file-name) should almost certainly be: (string-prefix? "/dev/loop" file-name) The regexp above would match =E2=80=9C/dev/loo=E2=80=9D, =E2=80=9Cqux/dev/l= ooppppppppabc=E2=80=9D, etc. WDYT? Thanks, Ludo=E2=80=99.