From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uMEVLy7S+F8tJQAA0tVLHw (envelope-from ) for ; Fri, 08 Jan 2021 21:44:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uM8BKy7S+F/7IgAAB5/wlQ (envelope-from ) for ; Fri, 08 Jan 2021 21:44:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1F98D9402D6 for ; Fri, 8 Jan 2021 21:44:14 +0000 (UTC) Received: from localhost ([::1]:35838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxzYK-0007LI-6P for larch@yhetil.org; Fri, 08 Jan 2021 16:44:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxzYA-0007L6-CC for bug-guix@gnu.org; Fri, 08 Jan 2021 16:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxzYA-0002G4-5J for bug-guix@gnu.org; Fri, 08 Jan 2021 16:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxzYA-00057s-3E for bug-guix@gnu.org; Fri, 08 Jan 2021 16:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#30116: [PATCH] `substitute' crashes when file contains NUL characters (core-updates) Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 08 Jan 2021 21:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30116 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 30116-done@debbugs.gnu.org id=D30116.161014224019690 (code D ref 30116); Fri, 08 Jan 2021 21:44:02 +0000 Received: (at 30116-done) by debbugs.gnu.org; 8 Jan 2021 21:44:00 +0000 Received: from localhost ([127.0.0.1]:50824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxzY8-00057W-BA for submit@debbugs.gnu.org; Fri, 08 Jan 2021 16:44:00 -0500 Received: from world.peace.net ([64.112.178.59]:57080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxzY6-00057I-I7 for 30116-done@debbugs.gnu.org; Fri, 08 Jan 2021 16:43:58 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxzY0-0006bw-Cz; Fri, 08 Jan 2021 16:43:52 -0500 From: Mark H Weaver In-Reply-To: <87wnwn5jgv.fsf_-_@gmail.com> References: <87r2qrc3mq.fsf@gmail.com> <87k1wjc35d.fsf_-_@gmail.com> <87r2l9q294.fsf@netris.org> <87tvq2smpm.fsf@gmail.com> <87d0wq3u8f.fsf@netris.org> <87wnwn5jgv.fsf_-_@gmail.com> Date: Fri, 08 Jan 2021 16:42:43 -0500 Message-ID: <871rev14wh.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 30116-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 1F98D9402D6 X-Spam-Score: -2.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: ytYC5tn67H8z Hi, Maxim Cournoyer writes: > I was recently reminded of this bug by a new encounter; at last wrote a > test for your proposed fix, and it appear to work as intended! I've > committed it on your behalf in commit 485ac28235 on the core-updates > branch. Thanks for taking care of this Maxim, and for adding the test case. Regards, Mark