From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QA/8DlfWbWB/RQEAgWs5BA (envelope-from ) for ; Wed, 07 Apr 2021 17:57:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2G/wCFfWbWC0bgAA1q6Kng (envelope-from ) for ; Wed, 07 Apr 2021 15:57:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D9C4C17C56 for ; Wed, 7 Apr 2021 17:57:10 +0200 (CEST) Received: from localhost ([::1]:34030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUAYH-0001TH-HT for larch@yhetil.org; Wed, 07 Apr 2021 11:57:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUAYA-0001Sq-O6 for guix-patches@gnu.org; Wed, 07 Apr 2021 11:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUAYA-00008o-Gf for guix-patches@gnu.org; Wed, 07 Apr 2021 11:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lUAYA-0006lv-Eo for guix-patches@gnu.org; Wed, 07 Apr 2021 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47640] [PATCH v2] Add sqlitebrowser. Resent-From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Apr 2021 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47640 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Allan Adair , 47640@debbugs.gnu.org Cc: Allan Adair Received: via spool by 47640-submit@debbugs.gnu.org id=B47640.161781101826021 (code B ref 47640); Wed, 07 Apr 2021 15:57:02 +0000 Received: (at 47640) by debbugs.gnu.org; 7 Apr 2021 15:56:58 +0000 Received: from localhost ([127.0.0.1]:45046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUAY5-0006lb-PU for submit@debbugs.gnu.org; Wed, 07 Apr 2021 11:56:58 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:42538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUAXp-0006l8-KS for 47640@debbugs.gnu.org; Wed, 07 Apr 2021 11:56:56 -0400 Received: by mail-wr1-f48.google.com with SMTP id q26so12834659wrz.9 for <47640@debbugs.gnu.org>; Wed, 07 Apr 2021 08:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=Qafcl4q2bh0DM1WFTsxZcsl9twBec2ajgHPg2d/ryKs=; b=BQmSYeqdvOXA+64d+EQ0smhjeL5dQWoXEH8FHihpMfVyDULbEzXYNcj4NE5rl7Mt1B EapYDGjMAkcu2YvEC2V1Ms4XoF5/55xUjtSudQMyTCuAPkRHaM1eXoI0q8Cw85alwp4J 27UpcLLlPrU8CTL8a1pPA0L8DO+t5wJGHrqmTjb2YKDtHCPLLaj2DzojD/BXq6LPdpO3 uNSZWevFmbFXiwn2X+2zAzdWM9T3RsKLOrNegf5X/rlVwLsAMCvA68aLLHhNuCqBJ3/O vLYi3QMYOOliCEuMqHLHkbnrS056kf4rUktCclyroeSxcBPFgUZDt1l0xZe5TFnN+9FN XcHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Qafcl4q2bh0DM1WFTsxZcsl9twBec2ajgHPg2d/ryKs=; b=gJG1TxqbKkezrBKLdom6969h+ZKM6HsL16YKw+cUxn88NQoJOENc9tuUlIgUneear3 nFCIv0DX3w74PXn8TJ0MPE14KDPsxX9Doki8xQ04055RK3ITINuBvY6gEWFlG8x8l8td DYGV8Xon8nMbWzXtmgRfte45kBs+sNMyZfcxFD4sFT3t46BKiSP2vdjDRP6x1h4pXvqC +zrEsFWyX8AxdUQ6L5N6VNLSgLp0YoRhpCaeTpdjg1MVnpRcwKCRDJxTTBH1glBF6rY4 Xq/TiNqp9DE98msOJ1CI63OW38ndKsR6FS92Ylk9Ib0vVjd+hth9c8SB0GNiJ7wuMAvz OvIQ== X-Gm-Message-State: AOAM532DmVBv82ZgFjNLsoI0d3jSSDkCRbj8ybkp5lXRRdB0JRKpD4US 1cPQUMVhuuS3/L3LSYKKkjw= X-Google-Smtp-Source: ABdhPJz2mlMIn4FTIvqz7wq9eiJQFdWWmzpvSJqCjtz2KHRDGjV/txLJX4nioizfRSdL3Oh8I+NmZA== X-Received: by 2002:adf:cd0a:: with SMTP id w10mr5183242wrm.39.1617810995588; Wed, 07 Apr 2021 08:56:35 -0700 (PDT) Received: from guixSD (host-79-17-142-89.retail.telecomitalia.it. [79.17.142.89]) by smtp.gmail.com with ESMTPSA id c16sm48937942wrs.81.2021.04.07.08.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 08:56:34 -0700 (PDT) From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: <20210407110953.14809-1-allan@adair.no> References: <20210407110953.14809-1-allan@adair.no> Date: Wed, 07 Apr 2021 17:56:33 +0200 Message-ID: <871rbmnl5a.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617811031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Qafcl4q2bh0DM1WFTsxZcsl9twBec2ajgHPg2d/ryKs=; b=bG/BsxBb4FjznKcc3Naif/liTQiJzpP3wvJuwsdRgLEqokhgLpplKWNbCFdGgxpetXT7Wf xwY2LyiUV7yE6cSdu3Y8gZ9UBQeVtfKkvZizR6jk1rkl8/3JX3qoo7iPeA16M061nJ0UlR Vx9B7k2DKP+bOQDekQUimETEfcVLIzDsnVTiQjMnhqv9z5HgDTDbcRETTNEV0eriY6XEGC dStZKJqPXLlS25G+EocCr37ugdA7EjTG8gbNyzkc5Ao7X1ZJWvFgbIcoGnCAPcQ9qXOolj 130TRq0n643dBwTc5srB6km7nAuyoDd0VlfkxkfD+sVu8mVPfZUNAxG+Kr/ggQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617811031; a=rsa-sha256; cv=none; b=bjoOu8iEuMvNn1jCEeyaWGMvP5Y5z+oCDwWumsK7yd1aVbOk0d0AZInGtBf/JzlECwqg2l gd7ApYGlivUxJGtE0mOKMtaIQAU3aquMf96mliPgaDWCcOC8zs7jdWU7ktgccSB9kRaJmH HyDTJCGrnFwbFl+mYmKyi0JfCG9PG/PrO30CDtMc/rasUPHftORj2jAl89pQhAhbI46/HB 0xj+33r16Z+PI9v1ZBR/aH7yHl/xxq9np128UHzuCSsYHGX4dxKGCaGe3t/+bdsQ6h9Ed0 aPD6x5skdQxe/YfkkvraF6VvAUkCYrnk4LGSJnSTLZ2rzZdWwHA/jBr/W4cEUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=BQmSYeqd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=BQmSYeqd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D9C4C17C56 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: icohn8RV2Rs8 Hi, thanks for the contribution! A few comments below Allan Adair writes: > + (description > + "DB4S is for users and developers who want to create, search, and e= dit databases. DB4S uses a familiar spreadsheet-like interface, and complic= ated SQL commands do not have to be learned.") I think the linter here will complain about the single space after the period, and for the really long line. Did you run ./pre-inst-env guix lint sqlitebrowser ? This should tell you if something is wrong > + (license (list license:gpl3+ license:mpl2.0)))) I see that there are bundled dependencies (under /libs), could you try unbundle them (remove the lib folder with a source snippet) and build using guix dependencies? There are only four of them, two of which (nlohmann-json-cpp and qscintilla) are already in guix. Else it might be needed to fix the licence. There are the cmake flags FORCE_INTERNAL_QSCINTILLA, FORCE_INTERNAL_QCUSTOMPLOT, FORCE_INTERNAL_QHEXEDIT which suggest this should be possible. Thanks, Nicol=C3=B2