From: Kyle Meyer <kyle@kyleam.com>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 48033@debbugs.gnu.org
Subject: [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Mon, 26 Apr 2021 20:59:11 -0400 [thread overview]
Message-ID: <871rawa6g0.fsf@kyleam.com> (raw)
In-Reply-To: <8d66684c511e3a36830465481851f9d86d4d6231.1619439907.git.public@yoctocell.xyz>
Xinglu Chen writes:
> * gnu/packages/mail.scm (public-inbox): Update to 1.6.1.
> [synopsis]: Capitalize “git”.
> [description]: Likewise.
> ---
> I haven’t tested it thoroughly; ‘public-inbox-init‘ and
> ‘public-inbox-index’ seem to work fine.
>
> Cc: Kyle since you have been somewhat active on the public-inbox ML. :)
Thanks for updating this.
To add to your manual checks above (and to the passing test suite), I
tested out public-inbox-httpd with some inboxes I have locally, and
everything there seems to be working as expected.
I think the perl-filesys-notify-simple input should be dropped because
Filesys::Notify::Simple isn't used as of v1.6.0. Linux::Inotify2 is
used instead, but it doesn't look like that's packaged for Guix yet. I
believe public-inbox has some fallback behavior here so that
public-inbox-watch is still functional, but ideally Linux::Inotify2
would be added as an input with this update to 1.6.1.
Otherwise, this patch looks good to me, but fwiw there are a few
optional dependencies (already packaged in Guix) that could be added:
* highlight (syntax highlight for associated code repositories)
* perl-inline-c (nice to have for performance reasons)
* perl-parse-recdescent (as of v1.6.0, used only for public-inbox-imapd)
next prev parent reply other threads:[~2021-04-27 1:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 12:35 [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1 Xinglu Chen
2021-04-27 0:59 ` Kyle Meyer [this message]
2021-04-27 1:09 ` Kyle Meyer
2021-04-27 20:21 ` Xinglu Chen
2021-04-27 21:03 ` Xinglu Chen
2021-04-28 4:22 ` Kyle Meyer
2021-04-28 13:16 ` Xinglu Chen
2021-04-28 21:53 ` Kyle Meyer
2021-04-29 12:18 ` Xinglu Chen
2021-04-29 12:37 ` [bug#48033] [PATCH v2 0/2] Update public-inbox " Xinglu Chen
2021-04-29 12:37 ` [bug#48033] [PATCH v2 1/2] gnu: Add perl-linux-inotify2 Xinglu Chen
2021-04-29 12:37 ` [bug#48033] [PATCH v2 2/2] gnu: public-inbox: Update to 1.6.1 Xinglu Chen
2021-04-30 23:49 ` Kyle Meyer
2021-05-01 12:01 ` Xinglu Chen
2021-05-01 12:04 ` [bug#48033] [PATCH v3 0/2] Update public-inbox " Xinglu Chen
2021-05-01 12:05 ` [bug#48033] [PATCH v3 1/2] gnu: Add perl-linux-inotify2 Xinglu Chen
2021-05-01 12:05 ` [bug#48033] [PATCH v3 2/2] gnu: public-inbox: Update to 1.6.1 Xinglu Chen
2021-05-03 16:27 ` bug#48033: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rawa6g0.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=48033@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.