From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id hn1iBK9KQ2HdLgAAgWs5BA (envelope-from ) for ; Thu, 16 Sep 2021 15:46:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uLIOO65KQ2G1FwAA1q6Kng (envelope-from ) for ; Thu, 16 Sep 2021 13:46:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89CF81FFA2 for ; Thu, 16 Sep 2021 15:46:22 +0200 (CEST) Received: from localhost ([::1]:33792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQriX-0000Iz-90 for larch@yhetil.org; Thu, 16 Sep 2021 09:46:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQriF-0000GJ-Fw for guix-patches@gnu.org; Thu, 16 Sep 2021 09:46:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQriE-0002U8-VP for guix-patches@gnu.org; Thu, 16 Sep 2021 09:46:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQriE-0003Li-SH for guix-patches@gnu.org; Thu, 16 Sep 2021 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50374] (no subject) Resent-From: "Collin J. Doering" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Sep 2021 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50374 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adolfo De =?UTF-8?Q?Un=C3=A1nue?= Cc: 50374@debbugs.gnu.org X-Debbugs-Original-Cc: 50374@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 50374-submit@debbugs.gnu.org id=B50374.16317999099520 (code B ref 50374); Thu, 16 Sep 2021 13:46:02 +0000 Received: (at 50374) by debbugs.gnu.org; 16 Sep 2021 13:45:09 +0000 Received: from localhost ([127.0.0.1]:54158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQrhM-0002T5-Cx for submit@debbugs.gnu.org; Thu, 16 Sep 2021 09:45:08 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:37584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQrhH-0002MD-LV for 50374@debbugs.gnu.org; Thu, 16 Sep 2021 09:45:06 -0400 Received: by mail-qt1-f171.google.com with SMTP id m9so5531787qtk.4 for <50374@debbugs.gnu.org>; Thu, 16 Sep 2021 06:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=vDkldQMNLuxGQxPRYHICpDZ57+w//DK3xpaBqoOMSQQ=; b=yWkAPqcUcqiHA3Am7vVyFpTE0B0fxL16kQ2V1xUg6uLfh/Sypci7JUqSrdIYuuurdL Ifk2ErPifSFtKZh75TysU6ksRqvE2DYolu3MU/ZFlJ9AST1ixGInilR6Bv2+VKeX00MU M451xpkC+nbTky7UnIGth8CGFb0wzyAQsXQKdc432MQ6Tb47PHKce7da+cxIyD6MrrJX 9AvtU6jwrGWxEvmnK80NsWb6JYiojvhqYkdHQF4lkHfko6196pfpqTINQN0FIthRlVCA 8uAQepjiTwsfvqzEc6iSSJlvqKpIxo6cPMg0oWwPxCTwzxhSwojjvKWlqvwC2QNfivO6 HS0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=vDkldQMNLuxGQxPRYHICpDZ57+w//DK3xpaBqoOMSQQ=; b=rVnYSa86QplHOViEYlcO1+MrMGv9UpYA7BiXV/yOxHgKOrAwocGuC0YVlnUyE34ldX Xklet0BcYmUYsA3BmqE0ZVFRJElWpK6pKiIEBfD5qHYQ6wtFn3De0IUMFZzSFZ2P+Eyb 1673PrxcuUIk0LoWlOuF3Wsaqvbi8ZnPXT0afK4btSXYq4w8nPZ/XHMo34rTL8ORCpNV 2gAQFJFzVAaxBGrcS2zcrVqBJQgZyOXoi3+owWFSVRMx3Sf48fxxTQ0XpYJ9+xJmfKqM M3H1ushMs8J9G5+jzZDTxe1whrcKP4OiIQWeGqgwmUHGWDQo5tyAIrGcJd/kseVbaj9I GN2Q== X-Gm-Message-State: AOAM532zmikMHBacalHk1LPJmz78y0BvcM43gm9ZVko3ZTEIAudtjxyV npjtWoOixKJ9c+Nrrl7Qt1ccgTndhtkZVA== X-Google-Smtp-Source: ABdhPJwsJkTdbNVg4znGtSIDhSKfMZQTOWH911ow80r2Hxc9LZaiiZo9wwUjXmgytoLfujfHlJl9HQ== X-Received: by 2002:ac8:7003:: with SMTP id x3mr5224760qtm.284.1631799898086; Thu, 16 Sep 2021 06:44:58 -0700 (PDT) Received: from rekahsoft-work (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233]) by smtp.gmail.com with ESMTPSA id l7sm2363151qki.99.2021.09.16.06.44.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 06:44:57 -0700 (PDT) References: <8735qk9v2x.fsf@rekahsoft.ca> <875yv5sr0z.fsf@unanue.mx> User-agent: mu4e 1.6.5; emacs 27.2 From: "Collin J. Doering" Date: Thu, 16 Sep 2021 09:38:31 -0400 In-reply-to: <875yv5sr0z.fsf@unanue.mx> Message-ID: <871r5ohbxj.fsf@rekahsoft.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631799982; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vDkldQMNLuxGQxPRYHICpDZ57+w//DK3xpaBqoOMSQQ=; b=D13lWny0VdLkKWfqgSUTU8X4msT8GFiPQ/0bfJcyk1DMRbKZR3DoemgkR4y0OPmhK0ws3s QFQCB/hwR+yVx8FF+QbwroZkWH0Y38ZmRZrV/7P7suu0pCL0niAox4ezZsEuLUexaz8QiN iTy1JcCg0Auy8pQWWHAae53MOzIN5AKUVdmUScCi6VqbytPcMGH1ecPZEFg+GAUPHS6aO2 nMpI6/Hn2Mf3zX89UowilPLztmcFatIfAIpqXLh1EBDv14rc7lUprWmUgcFHwMAX+8VOTE 3NWGejEE/Ttf2IL5CpLpJfggfYVqSg0tOigYDsO5SyxftcqdLvYRzwBGPX0FhQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631799982; a=rsa-sha256; cv=none; b=dlqJMhEszOYAJyjSyQpZzwtrUIJjfhtVRKY4iMEq54pkaIYV6/tr//A63/CD1+G1e7ITxb DTZHAh6+7kzLwBXYSNAEPqY7lo/fDgrgEPzv0EeH/YSS4HDa8JVoo18kJjFm9qu+47Msgi SEIvNzhK0gL9LFbgpoyASbTmYS8q0zyaCIg58JSv7mQXYI6JxJKK4mPtCeDGueJmd6BWcy 6Z/g4dPnW1uCh3WzZeX35K+TLB3NjXa6qQwj/Mj7vk5T+zl9F/ADQ9vfeoLA67DPgv2XXm XBcxrh9QlgbvKO5C46J/HT8qtEIMkkgfvsocDbkv+WFhFsgsuSoqD129uMDreg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=rekahsoft.ca header.s=google header.b=yWkAPqcU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=rekahsoft.ca (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=rekahsoft.ca header.s=google header.b=yWkAPqcU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=rekahsoft.ca (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 89CF81FFA2 X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: RKH6csJhS/QO Hi Adolfo, I am not a guix expert either and am relatively new to the project. I actually asked about this topic on guix IRC, where folks there suggested splitting it into another package. I see very little difference between including the org-roam-extensions as a separate package output, or as a standalone package. I feel that having it as an additional output is more "pure", but found that many packages already use a standalone package for extensions, and I found that doing it in this way made both packages themselves easier to define. You can see this for yourself with a query like this `guix package -s '.*-extensions$' | recsel -CP name`. Hope this helps, and kind regards! On 12 Sep 2021 at 11:19, Adolfo De Un=C3=A1nue wrote: > Hi > > I am the author of the patch https://issues.guix.gnu.org/50333 (my first > patch, so I am a newbie on this). > > Could you help me to understand why your proposal is a better solution? > I want to learn how to approach to this matters in the future. > > My rationale is that the extensions folder *is* part of org-roam, that's > why I *added* them to the original package. > > Also, Do we need to do something in order to get this patch (or mine) > approved? > (again, just asking because this workflow is new for me) > > Thanks in advance for your time --=20 Collin J. Doering http://rekahsoft.ca http://blog.rekahsoft.ca http://git.rekahsoft.ca