From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0PZMBWAmRmExAgEAgWs5BA (envelope-from ) for ; Sat, 18 Sep 2021 19:48:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mNbgAGAmRmEzawAAB5/wlQ (envelope-from ) for ; Sat, 18 Sep 2021 17:48:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D55B5E0C for ; Sat, 18 Sep 2021 19:48:15 +0200 (CEST) Received: from localhost ([::1]:43530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mReRi-0005BJ-Ln for larch@yhetil.org; Sat, 18 Sep 2021 13:48:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mReRW-0005Ae-9y for guix-patches@gnu.org; Sat, 18 Sep 2021 13:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mReRW-0000kc-2i for guix-patches@gnu.org; Sat, 18 Sep 2021 13:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mReRW-0000fW-1N for guix-patches@gnu.org; Sat, 18 Sep 2021 13:48:02 -0400 Subject: bug#50359: [PATCH v3 0/3] Add 'generic-git' updater Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 18 Sep 2021 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50359 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: Sarah Morgensen , 50359-done@debbugs.gnu.org Mail-Followup-To: 50359@debbugs.gnu.org, ludo@gnu.org, public@yoctocell.xyz Received: via spool by 50359-done@debbugs.gnu.org id=D50359.16319872642531 (code D ref 50359); Sat, 18 Sep 2021 17:48:01 +0000 Received: (at 50359-done) by debbugs.gnu.org; 18 Sep 2021 17:47:44 +0000 Received: from localhost ([127.0.0.1]:36806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mReRE-0000ej-0b for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:47:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mReRC-0000e9-7J for 50359-done@debbugs.gnu.org; Sat, 18 Sep 2021 13:47:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60564) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mReR6-0000Pt-6w; Sat, 18 Sep 2021 13:47:36 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35824 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mReR5-0003Mr-V4; Sat, 18 Sep 2021 13:47:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Jour du =?UTF-8?Q?G=C3=A9nie?= de =?UTF-8?Q?l'Ann=C3=A9e?= 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 18 Sep 2021 19:47:34 +0200 In-Reply-To: (Xinglu Chen's message of "Fri, 17 Sep 2021 10:04:15 +0200") Message-ID: <871r5lu66h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631987295; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=6tBUfqrOpg1DLKR0kY5mIyW0KGTtj3BpjnbyvszsYYw=; b=m3EHuTdLRyuDo2/4oI7VQfIj39CWym9syvxHc0eyFVXvkOb/l8r41cWUNjtUM8OxaU0NbF W8P1fdPX/4ePihg/Hk1mBQCmP75GKyeVI1O/Hzz4t2ZiPr5MU6YBbgxofwnz/aiTXGdzBb mNhkzqtG5kgfKusBbjr+Z/+iJg9N5VSRJlIa4XXN0kAzC2Kjc3Sh+zezYVQu1ds7g7Up5z j6gKKf4C60XOzaTRTQDcO40PEhFLLbHRB0KtjlBsSOGR9g9RY6xPFQxe9A5F0kVmQ4ejZ/ Dxnsjfn2Xm5DhfGxKNNv/DEG3Wu9gmSmUW9BtDOnGHUDFihgKtgGTG/9RBi7cA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631987295; a=rsa-sha256; cv=none; b=L4xqG+CA18mtGZpmlUJgMKfv2FmyR3sZKOEFpBrrvMfFZ2VDX9F6+V1IM67ur4DxgHrhJp UXd9N1CfU0PUCi3mKjPk+6NPfBd67gY1m2F+ZKpVOQAUO9ISYzd2kF3BQzJOtjRxW3Utac 3id4aX80h6P/qz7vPymoVFj0A5ZoH6fegV0KTkAUgCJ5Oo76k+X7VSTdzFS7k74E0pzV35 bB8daRVe27IK6PaUFDLBi88qNVBDsfEcMbDD1U4Lc6kmA9rA9XWyFnBr+6WjH/JELTkvi6 epCoFeF7rHPYIGrQETG2WV8gLNIUjQEs4AIypUxFsClniXohd2B1uyJbRJGuTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.39 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7D55B5E0C X-Spam-Score: -1.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: Yhtj4lLVuXA8 Hello! Xinglu Chen skribis: > Changes since v2: > > * Address the feedback by Ludovic and Sarah. > > One problem I noticed was that when =E2=80=98accept-pre-releases?=E2=80= =99 is #t, a tag > like =E2=80=9C1-2-3-alpha=E2=80=9D would turn into =E2=80=9C1.2.3.alpha= =E2=80=9D, but I think the > correct version string would be =E2=80=9C1.2.3-alpha=E2=80=9D. > > I solved the problem by making the pre-release part a separate regexp > group, and then appending the pre-release part after extracting the > version from the tag. That way, the =E2=80=9C-=E2=80=9D in =E2=80=9C-alp= ha=E2=80=9D would not be > interpreted as a version delimiter. I also added a new test for testing > this. I think that=E2=80=99s fine; this is all guesswork anyway, and there are al= ways cases where we=E2=80=99ll get it wrong. What=E2=80=99s useful though is te= sts to guard against regressions in the heuristics. > One of the tests in tests/channels.scm is failing; I am not sure why. > Before the first and second patches were applied, 6 of them were failing > for me, so I guess it=E2=80=99s an improvement. However, on IRC, Ludovic= said > that all of them were passing (prior to apply my patches). It would > be great if people could run the tests before and after applying > patches, and see if they pass. Turns out that the failure in tests/channels.scm was a real bug: =E2=80=98channel-news-entry-commit=E2=80=99 was not resolving annotated tag= s correctly (it would return the ID of the tag instead of the ID of the commit pointed to by the tag). Fixed in 778c1fb4eabbb48c05f6c7555c89466d5249ebce. > tests: git: Don't read from the users global Git config file. > tests: git: Make 'tag' directive non-interactive. > import: Add 'generic-git' updater. Applied! I changed the second patch to preserve support for non-annotated tags and to leave tests/channels.scm unchanged. BTW, =E2=80=9Cgit tag xyz=E2=80=9D is not interactive AFAICS. Thanks Sarah & Xinglu for this work! Let=E2=80=99s update our packages! := -) Ludo=E2=80=99.