From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QLvZFq5qSGGXUwAAgWs5BA (envelope-from ) for ; Mon, 20 Sep 2021 13:04:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eCKFEq5qSGF+FAAAB5/wlQ (envelope-from ) for ; Mon, 20 Sep 2021 11:04:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 063CD27745 for ; Mon, 20 Sep 2021 13:04:14 +0200 (CEST) Received: from localhost ([::1]:47758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSH5o-0002yC-4P for larch@yhetil.org; Mon, 20 Sep 2021 07:04:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSH5f-0002y2-EB for guix-patches@gnu.org; Mon, 20 Sep 2021 07:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSH5e-00009z-EX for guix-patches@gnu.org; Mon, 20 Sep 2021 07:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSH5e-00005r-8U for guix-patches@gnu.org; Mon, 20 Sep 2021 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50614] [PATCH core-updates] build: utils: Add =?UTF-8?Q?=E2=80=98optional=E2=80=99?= macro. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Sep 2021 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50614 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 50614@debbugs.gnu.org, Liliana Marie Prikler , Sarah Morgensen Received: via spool by 50614-submit@debbugs.gnu.org id=B50614.1632135829340 (code B ref 50614); Mon, 20 Sep 2021 11:04:02 +0000 Received: (at 50614) by debbugs.gnu.org; 20 Sep 2021 11:03:49 +0000 Received: from localhost ([127.0.0.1]:41080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSH5Q-00005Q-OU for submit@debbugs.gnu.org; Mon, 20 Sep 2021 07:03:48 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:35334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSH5O-000057-SP for 50614@debbugs.gnu.org; Mon, 20 Sep 2021 07:03:47 -0400 Received: by mail-wr1-f53.google.com with SMTP id i23so28475645wrb.2 for <50614@debbugs.gnu.org>; Mon, 20 Sep 2021 04:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7uRSzjZMCKZgPt8eRhFSqPicnbu5ffuJ1b64uvH8o4A=; b=g5CM9/uspvfxJbI66RTA9RY9b8BWKL2MZts8zs+OMwmAdGpbE0mrURfexa724dYc9z IrOg+TTGDev4Xlf9DwUezCdseYnWZThVweYFO3KoLP+kZIub0rg+O11g7O2Y6dcLjt1Z Zkbumy6ZAo7PjIiI0mhAww4kh2D2kNMvcvLXEpafQP2qGcSuVPawRmrUIr1g/ZyLHQwK qn+UZqxB0rvfI7gYiqXkvPTUdAMr8XRDO3nX6TRQR9l6ieHoZzG208iffN9MuU43eljA co1BACys1iiSRlP09lRMlOg5dYhQtc5IpJ+kYecRxCGWcNhSKS+ocmRXtkzds2KFYO51 adoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7uRSzjZMCKZgPt8eRhFSqPicnbu5ffuJ1b64uvH8o4A=; b=Z4EfWrCUlPHeMvzpxMe6RtlSt+cfrcTmdY0tulqbzjjEqaRqBevHYLHEHzyomuE6NF hQvYAveoNHBkXhxqfqn9sS8R3mAeaNA91fVciTZCBf9R5XW418ZgM2dqXAdw1cqSJznW HdLN3Ddi1LqEPngfxPeVR7IZklkA9jwU3WNeXEZ+FmMXH3PzDiPr7VS4SRXMVSTFmX1D v0Aa1ojmu0kbshaonByIv5pvyGLcJF5L5WrU8AyJPVCNni/IaToHsttViT03o+fw194x 8/EdLDyS65mwweiGYZb6BI5Zyt4Kh1c2dbehjZT7LyoTtkhd5bAYJDCdZkXgbzPnKeh6 +aog== X-Gm-Message-State: AOAM530EMLKygHoMkE4yer7qEVgtUDaIZNKP8x7VjiTeDmKToE6IyJXc riStbnWN84DH5EuyF4N2sYM= X-Google-Smtp-Source: ABdhPJwx/XdktauQujuJd6HTl7EZf0GQk1ThRcOCc+gVmfeA+guY8/EYu7k9h4pgY/20HFaMhfV6bg== X-Received: by 2002:a05:6000:c7:: with SMTP id q7mr16139324wrx.257.1632135820801; Mon, 20 Sep 2021 04:03:40 -0700 (PDT) Received: from pfiuh02 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id p6sm15084470wrq.47.2021.09.20.04.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 04:03:40 -0700 (PDT) From: zimoun References: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> Date: Mon, 20 Sep 2021 13:03:34 +0200 In-Reply-To: (Xinglu Chen's message of "Sun, 19 Sep 2021 15:50:41 +0200") Message-ID: <871r5jh5kp.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632135854; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7uRSzjZMCKZgPt8eRhFSqPicnbu5ffuJ1b64uvH8o4A=; b=RoNNNOgUP+6+ptacfXzJszAX5QVKg/cLdBB33rYE51iHReNrBEBWVP3aQH3gMI+lylD7l7 0nkAJcTy/4D6GqUCAkUyES/lNem+8putj9916L89DRsHfIOxJ42WjAyaHFldIWyLukl2B9 iASm2gyqQ0hmQMgYcPxjLi1sBLRWA+mavY5O15w08mwDvD25rzGRL7/U0ViESh2ghpuske A8SOYu86u8tOvKJP8bJH473h84eUtG3eevst1xIn6KV4UF0s2gCQyECOmGVybIVOqeZumV QKPZuclk/1umHtwAeL59/n/l1Uz/c5XyUrMxhR86sOinoWzsH7fPwYokw7aN0g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632135854; a=rsa-sha256; cv=none; b=sq+Vtv1D/YTA36vwl9OfcAZGWbk0kTg35swlBylf07PA7C0MlrX/aUx2d52qNrV97udz7o N65MJXUcT5LpVYld6XpwKeV4uKHiX56isESp8NmgjAvv81A+TLu5YBcqSses2W85AkbPIB iWPmFwO8ueYfK5PvbmA6lFxjFX6GnJ89YLmskCL7u61wcOOH2YaSaLu7+Y4iifnqio6PUB r+SCIEgflzWfT9OzVHOneT7mtSgMWsbuM4k5ERHUyq2hFPYaj6NaOJF1H/7VaFhjEZuNcV ZZlg/BtIUDvUzaxlCcPQCbtgrYYjII3c2Xc6nb7J6bjuGc6awcsthvnkLvifng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="g5CM9/us"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="g5CM9/us"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 063CD27745 X-Spam-Score: 0.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: /7ZReQl2NIdd Hi, On Sun, 19 Sep 2021 at 15:50, Xinglu Chen wrote: > +@lisp > +(if @var{test} > + (list @var{consequent} @dots{}) > + '()) > +@end lisp [...] > +@lisp > +(arguments > + `(#:configure-flags (list "--localstatedir=3D/var" > + "--sysconfdir=3D/etc" > + ,@@(list-when (hurd-target?) "--with-courage"= )))) > +@end lisp Personally, I am not convinced it helps the readibility. But that=E2=80=99= s a matter of taste. :-) My concern is about the coherence. First, =E2=80=99list-unless=E2=80=99 is= also required by a similar pattern, see for instance: --8<---------------cut here---------------start------------->8--- gnu/packages/guile.scm:162: ,@(if (target-mingw?) '() `(("bash"= ,bash-minimal))))) --8<---------------cut here---------------end--------------->8--- And second, these 2 patterns =E2=80=99list-when=E2=80=99 and =E2=80=99list-= unless=E2=80=99 are used in by many files, see guix/build-system, guix/import, guix/describe, gnu/packages, gnu/system, gnu/services files. For the oneline pattern: =E2=80=9Cag --scheme '@\(if' | grep '()'=E2=80=9D. All should be replaced;= which implies a world-rebuild I guess. Well, all in all, I am not convinced that all this work is worth for a small debatable readibility improvement. :-) All the best, simon