From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cCWjHN484GGpFwAAgWs5BA (envelope-from ) for ; Thu, 13 Jan 2022 15:53:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qHRkFd484GFLJwEAG6o9tA (envelope-from ) for ; Thu, 13 Jan 2022 15:53:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E3B71945C for ; Thu, 13 Jan 2022 15:53:18 +0100 (CET) Received: from localhost ([::1]:52462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n81TY-0001kj-7g for larch@yhetil.org; Thu, 13 Jan 2022 09:53:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n81RO-000857-K7 for bug-guix@gnu.org; Thu, 13 Jan 2022 09:51:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n81RO-00029T-AI for bug-guix@gnu.org; Thu, 13 Jan 2022 09:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n81RO-0003LC-85 for bug-guix@gnu.org; Thu, 13 Jan 2022 09:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52919: Hidden "disk-image-rw" files aren't deleted after use, filling $tmpdir Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 13 Jan 2022 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52919 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 52919-submit@debbugs.gnu.org id=B52919.164208540512752 (code B ref 52919); Thu, 13 Jan 2022 14:51:02 +0000 Received: (at 52919) by debbugs.gnu.org; 13 Jan 2022 14:50:05 +0000 Received: from localhost ([127.0.0.1]:60576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n81QS-0003Jb-VI for submit@debbugs.gnu.org; Thu, 13 Jan 2022 09:50:05 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:58268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n81QQ-0003J1-U5 for 52919@debbugs.gnu.org; Thu, 13 Jan 2022 09:50:04 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 84C687EE; Thu, 13 Jan 2022 15:49:56 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e-zk2gvNHs57; Thu, 13 Jan 2022 15:49:55 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 29A9B789; Thu, 13 Jan 2022 15:49:54 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87pmp850ll.fsf@gnu.org> <8735m3nccu.fsf@inria.fr> <87v8yqv4dh.fsf@gnu.org> <874k68r7y2.fsf@gnu.org> <87sftr52hy.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?UTF-8?Q?Niv=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 13 Jan 2022 15:49:54 +0100 In-Reply-To: <87sftr52hy.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 13 Jan 2022 11:55:21 +0100") Message-ID: <871r1b8zcd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 84C687EE X-Spamd-Result: default: False [0.90 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_HAS_CURRENCY(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 52919@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642085598; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=xGgafhIxNbrdM8GWQgBaZD/p5mKFbm81bc++M7hyXXw=; b=MMpTutOxbiBc0Bl/vkar1XBjQEtdF4Gyt6+mzlYAHNLXEm53OZ6PsXMB/pP2YRGk4VbSVs 2rzh+CL+T4wwr54UCKOsXKHg865lpy2FDm3FamBQE8IEuj/BoG8g1Z2T+BofjIrJCsQrlq g5QeqELEtMkhZ0SMuxJJQR9GS8NzOtuj0LXwqETVgqmv/FqfYHw2dJqHYaIjrDqLAkODr5 H0+rXtUzhrbqPyoO7RlnwMmmL8OJawpgXSCe/zUviJoEiaJFqz8YD5I/+1qXqMc3BFYLzC 619zT8WtI9nyuwGGlWdSdATgQEOz9UTfzvio6myF/8rmyGVmqvQ0cIHTy/dPvA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642085598; a=rsa-sha256; cv=none; b=TSS3YhnpmhwKezASHzG3EQJ9saiQXdg3gHG7VmsPHXIWVZ/OosnK0FOFBoEgbYhXiYtUbK X7q71xLoZD+92qCcHyNQ9jEfSqsXKGo1QqJWPklVR+pqBaPureAwrK9VCL01b4lw+O2eaC L4/HY8iSVGbTbUUUl86IIuoElkQoD2IbvuJpViaJNNyx7bYXlM2/yvdNMnut2j1dCO04ic AJ+QYYDfIQNNM6DMA/gOtOR+K+EkOgygjEx6XeqYRit+MWo/GY1HhWbO8CXwZiQiATThkd SS5/oDj3DFeme7OFDVqYu7GNW5yKEDyStNzf3x7Sn6xGMUo+wcvtPfv+DoAlzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0E3B71945C X-Spam-Score: -3.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: o9Ya4TujrmaG Hello, Mathieu Othacehe skribis: >> Hmm. Can we keep =E2=80=9Cimage=E2=80=9D persistent by default, and mak= e =E2=80=98vm=E2=80=99 volatile >> by default? That way, =E2=80=98--volatile=E2=80=99 would only make sens= e for =E2=80=98image=E2=80=99, >> and =E2=80=98--persistent=E2=80=99 would only make sense for =E2=80=98vm= =E2=80=99. (So we=E2=80=99d be adding >> just one option: =E2=80=98--persistent=E2=80=99.) >> >> WDYT? > > I'm not fan of adding antithetic options: --x and --no-x. There's an > attached patch introducing --volatile-image and --persistent-vm options, > and documenting them. It's maybe not that bad after all. [...] > From b0c84a411f9f23f4f1a4155ba5efa68cac9004a2 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Thu, 13 Jan 2022 11:35:40 +0100 > Subject: [PATCH 1/2] scripts: system: Rationalize persistency. > > Make sure that the images are created with a non volatile root by default= and > the vm are created with a volatile root by default. Break the --volatile > option into --volatile-image and --persistent-vm options. > > * guix/scripts/system.scm (perform-action): Turn volatile? argument into > volatile-vm-root?. > (show-help): Introduce --volatile-image and --persistent-vm options inste= ad of > --volatile. > (%default-options): Adapt it. > (%options): Handle those options. > (process-action): Honor them. > * doc/guix.texi (Invoking guix system): Adapt it accordingly. It=E2=80=99s maybe not that important but I=E2=80=99m not convinced about t= he extra =E2=80=9C-image=E2=80=9D and =E2=80=9C-vm=E2=80=9D suffixes; I don=E2=80=99= t think it makes things clearer. [...] > - (option '("volatile") #f #f > + (option '("volatile-image") #f #f > + (lambda (opt name arg result) > + (alist-cons 'volatile-image-root? #t result))) As a rule of thumb, we should not remove an option without going through a deprecation period. So if we take that route, =E2=80=9Cvolatile=E2=80=9D should still be accept= ed, only with deprecation warning emitted. We can remove it entirely in 1.5.0 or so. Thanks! Ludo=E2=80=99.