From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Nicolas Goaziou <mail@nicolasgoaziou.fr>, 49943-done@debbugs.gnu.org
Subject: bug#49943: [PATCH] gnu: Add openboard
Date: Tue, 22 Mar 2022 16:16:50 -0400 [thread overview]
Message-ID: <871qyt3fpp.fsf_-_@gmail.com> (raw)
In-Reply-To: <87tuc9t58p.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 07 Mar 2022 23:53:10 -0500")
Hello,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi Nicolas and Maxime,
>
> Maxime Devos <maximedevos@telenet.be> writes:
>
>> Nicolas Goaziou schreef op zo 06-03-2022 om 00:16 [+0100]:
>>> + (add-after 'unpack 'fix-hard-coded-env
>>> + (lambda* (#:key inputs #:allow-other-keys)
>>> + (substitute*
>>> "src/frameworks/UBPlatformUtils_linux.cpp"
>>> + (("/usr/bin/env") (search-input-file inputs
>>> "/bin/env")))))
>>
>> You have to add 'coreutils-minimal' (or 'coreutils') to 'inputs',
>> otherwise 'search-input-file' will fail when cross-compiling because
>> 'bin/env' (from 'coreutils') is not among the inputs, whereas it is in
>> the (implicit) native-inputs when compiling natively and native-inputs
>> are merged into inputs when compiling natively.
>
> I've tested it, and it was for the most part functional (only the
> "games" add-on that I could integrate to the main screen didn't render
> fully, perhaps because my WebGL support was marked as blacklisted (I use
> the nouveau driver)).
>
> LGTM, with the above comment from Maxime addressed!
I went ahead and adjusted the version string to be monotonic, added
coreutils-minimal as an input, and pushed as 96b2da8cde.
Thanks,
Closing.
Maxim
prev parent reply other threads:[~2022-03-22 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 14:47 [bug#49943] [PATCH] gnu: Add openboard Nicolas Goaziou
2022-02-24 4:23 ` Maxim Cournoyer
2022-02-24 21:32 ` Nicolas Goaziou
2022-02-27 5:20 ` Maxim Cournoyer
2022-02-28 20:56 ` Maxim Cournoyer
2022-03-05 23:16 ` Nicolas Goaziou
2022-03-06 9:03 ` Maxime Devos
2022-03-08 4:53 ` Maxim Cournoyer
2022-03-22 20:16 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qyt3fpp.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=49943-done@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.