From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id fHDCFnE5YmJKGAAAbAwnHQ (envelope-from ) for ; Fri, 22 Apr 2022 07:13:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KPODFXE5YmLwxgAAauVa8A (envelope-from ) for ; Fri, 22 Apr 2022 07:13:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E160220772 for ; Fri, 22 Apr 2022 07:13:20 +0200 (CEST) Received: from localhost ([::1]:60506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhlbb-0006JH-6D for larch@yhetil.org; Fri, 22 Apr 2022 01:13:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhlbL-0006Gu-3i for guix-patches@gnu.org; Fri, 22 Apr 2022 01:13:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhlbK-0001er-RB for guix-patches@gnu.org; Fri, 22 Apr 2022 01:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nhlbK-0002Q6-LR for guix-patches@gnu.org; Fri, 22 Apr 2022 01:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54997] [PATCH 01/12] gexp: Add 'references-file'. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Apr 2022 05:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54997 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54997@debbugs.gnu.org X-Debbugs-Original-Cc: 54997@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 54997-submit@debbugs.gnu.org id=B54997.16506043489240 (code B ref 54997); Fri, 22 Apr 2022 05:13:02 +0000 Received: (at 54997) by debbugs.gnu.org; 22 Apr 2022 05:12:28 +0000 Received: from localhost ([127.0.0.1]:51280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhlam-0002Ox-DK for submit@debbugs.gnu.org; Fri, 22 Apr 2022 01:12:28 -0400 Received: from mx.kolabnow.com ([212.103.80.153]:58930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhlak-0002Oj-CR for 54997@debbugs.gnu.org; Fri, 22 Apr 2022 01:12:27 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 555F741124; Fri, 22 Apr 2022 07:12:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1650604339; x=1652418740; bh=IO7T1ko6xqVQQDghgRkRCEojlXT1LulNIjg ex+OJ45k=; b=kaZfz7akQto5JrZLQ/+6r/FGqfuy7wbmz7gY0mH6CzRdgx7Lv/3 d38PINruTNQYO7KxEGaj2eei5JCFUS1Xpo781I/GsEjudZWU9VS+/0mXwhTwP8OD YOQJScgrKfjMOxcALCbL5vBIQlKF7QI2uVHXUwOFEG3XqkOcIAW9PXqopjmzxfLX padMFfPcCrDWwpIxd0w2BbZya/GyeIoQsvsBsDe7aOJE/AyjF6fL4A6Ia+82EcBc 2UcK/YsUBsue6cXU/LHvwiz62c5JBClgHg918tvjgBn9kjtv/GMlf+3JgAibTlSo e+tGQmSeFKwSJG4PlfkAazoNyFX6gKQqfAzsWD3+lXoo6806JOtuhaIEqMI0UkDt ghySzYDJeQ21dxo5Lj1Emjdh041/QavGa37dKT8NYxABqhdggd5bu0ebyGKAo1pS 7q8V+TRhsYBEyyPkQb7hASTnkDrSx6SOkNwcmGyjbgCGKEJJUXvD+8VcgBVF86VW vgaZAzTFSJfe1CndftHnbJ56oQto0Jusak+t0Xzs738lZ9pJnrGM9/dKYUMvaD8U /bY50robgApAVtH3zzWaiAkZYi4kNUwd8aPAS7JHdb96kRcBmQZDPpWBGoRM4dDn FwnSnJ4sD+8jrs98wcz8lAYE+mMc4X0RWzB82SnEf0DWNwlbm0U2H1FU= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H22eG3UAzbvG; Fri, 22 Apr 2022 07:12:19 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by mx.kolabnow.com (Postfix) with ESMTPS id 1760740D72; Fri, 22 Apr 2022 07:12:18 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 2D7313794; Fri, 22 Apr 2022 07:12:17 +0200 (CEST) References: <20220417210107.27263-1-ludo@gnu.org> <20220417210453.27884-1-ludo@gnu.org> Date: Fri, 22 Apr 2022 02:01:39 -0300 In-reply-to: <20220417210453.27884-1-ludo@gnu.org> Message-ID: <871qxpvh04.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650604401; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IO7T1ko6xqVQQDghgRkRCEojlXT1LulNIjgex+OJ45k=; b=WwOGPkFwtf1U7r7DA1+5dNbMetSKOnqfq7ozrWCjzRK1cGTm1LyGQsK2rj40qd0LSDDD66 VuGeDMYf+1J4mVn7LKQhFcteLqkKPOIfI5mWVYZVRpfgosk8s2xdAxPy+sRoHrfq8vnfs4 lnV/RynZSE7r8ltr5HFNnz6evdpo+/R5Fu3SvX0uVMbEAJ/E2VHKIMAvCH+cywzpiOoWpa 8QWUpiZw11sY6C24tV5+YDNwes8y/MUtF19FRu9UpPo9Mn06FD9YjnUL2FX5Dk3tnLODDQ 5x6NF2Ikz0qBM6Y3y+awYo5nlLEUSBJAUgCRNnxZEqL/92uStWTAyPOIYH85pw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650604401; a=rsa-sha256; cv=none; b=AJ0ux+AcR8BB2M0peUefVCvOMKN1QUlxe7L8nhRa4eZgJoRd2UdpsQqp/KlVhBhSd8IG4y BH/YcMk6h1sOhAfj7tUTuhhgPaJyJrcy01dI+amLpVCTV7qiTOThNK5zuZNJ71DoUCgNe8 30Rn4E+9boh40n6NZRfCpW0FtNGdmEuJAiPzhEf2GVGgs+urifJbEukOSIRsvEWVrfb/cH MY6UvlHdqi/+lK/D1qOHy7MXMVmHfZMtFb9u7FTMGQJAVI6ua4LwoEtY+aIqRy5AKPnftf TWk07TWXCwSpIzuIWMksyObpXO0Rvtbe5ZM+eznJ6k1PRbpNzdY/Af9WmoR9DA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=kaZfz7ak; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=kaZfz7ak; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E160220772 X-Spam-Score: -3.53 X-Migadu-Scanner: scn1.migadu.com X-TUID: jX5Puh/nzlwP Hello Ludo, This is an awesome series! It will be yet another strength of Guix to have many services as possible (and even desktop apps, hopefully) isolated. I have one question: Ludovic Court=C3=A8s writes: > + (define (read-graph port) > + ;; Return the list of references read from > + ;; PORT. This is a stripped-down version= of > + ;; 'read-reference-graph'. > + (let loop ((items '())) > + (match (read-line port) > + ((? eof-object?) > + items) > + ((? string? item) > + (let ((deriver (read-line port)) > + (count > + (string->number (read-line po= rt)))) > + (drop-lines port count) > + (loop (cons item items))))))) I'm sure I'm being dense, but I don't see how =E2=80=98item=E2=80=99 can ch= ange between iterations of this loop. Which in my mind means that =E2=80=98read-graph=E2= =80=99 can only return a list where the original =E2=80=98item=E2=80=99 argument from =E2=80=98references-file=E2=80=99 is repeated many times over. I ran the te= sts/gexp.scm test and all tests pass, so this code must be working... --=20 Thanks Thiago