From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4JGjKzl6fmJjfwEAbAwnHQ (envelope-from ) for ; Fri, 13 May 2022 17:33:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iKGHKzl6fmJyPwEAauVa8A (envelope-from ) for ; Fri, 13 May 2022 17:33:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E9BD3894D for ; Fri, 13 May 2022 17:33:13 +0200 (CEST) Received: from localhost ([::1]:59414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npXI0-0002dh-H7 for larch@yhetil.org; Fri, 13 May 2022 11:33:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXHq-0002dD-SK for guix-patches@gnu.org; Fri, 13 May 2022 11:33:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npXHq-0006bw-Jj for guix-patches@gnu.org; Fri, 13 May 2022 11:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npXHq-00034q-BW for guix-patches@gnu.org; Fri, 13 May 2022 11:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55297] [PATCH 0/10] Make adding SSL_CERT_FILE/DIR search paths easier and add some missing ones Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 May 2022 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55297 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55297@debbugs.gnu.org Received: via spool by 55297-submit@debbugs.gnu.org id=B55297.165245595211746 (code B ref 55297); Fri, 13 May 2022 15:33:02 +0000 Received: (at 55297) by debbugs.gnu.org; 13 May 2022 15:32:32 +0000 Received: from localhost ([127.0.0.1]:44650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npXHF-000338-O1 for submit@debbugs.gnu.org; Fri, 13 May 2022 11:32:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npXHE-00032p-HN for 55297@debbugs.gnu.org; Fri, 13 May 2022 11:32:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXH9-0006YQ-4d; Fri, 13 May 2022 11:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5I1hQuvw26FpBn0DV+rHOEOAgL+zPxg2b1FkK8fQCno=; b=ZEYaZZG0Pk9RzR3ZOW58 pY1O8wp24SO8rXM2MLcNKMsk/1AaGWm1UI4ixAvuZLn/9llK3LI4x93owtFVcO+YfZXo/YKIDH36K +EBbiG0g8vc9nwCaFf0Qlq7jb/tS7ZDnf6sBMNQNNEVGiCnSF8nPPWQ8EyaCO43Yl3IgeIg9cCVzh o/yBl7MiUlDcnDggaTJZMUQBbHJWXhzBMxY10cSFpM4BPlQM6rxjngI3IwQ08o0szbEANMx5Z9ZLm eGjLeFsFCa5pC+jQSBmrRHo+IUhNXNkn7OLup/S6x+YubfiBPY6jekXicKwdvlstE5FaWJbaY9Hvz Adcqxk6GpiDSSA==; Received: from [193.50.110.244] (port=52712 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXH8-00055d-Mn; Fri, 13 May 2022 11:32:18 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Fri, 13 May 2022 17:32:16 +0200 In-Reply-To: (Maxime Devos's message of "Sat, 07 May 2022 10:35:00 +0200") Message-ID: <871qwxh2in.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652455993; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5I1hQuvw26FpBn0DV+rHOEOAgL+zPxg2b1FkK8fQCno=; b=SVUmxoy2FHhemIcQrk6/3MaYabPMDDp2o8LrUw/g4wqkwIOJId6DGNu4W0hhEnaiiIk9lv aCVSvd5qqiijSs6aRi9dLAZTQJ+/InxIFfxS7+kKHEGqU3vyD+3hNxDDowRI+4xDandjZ1 uLtJwgs2usPdTeBD+T34x5eRqqbc6fS/RlPWqpEP1jn4BQ56lpkK6J5NzZ0Bu046E+6C3B CWXBGbGEUCDtvRIzhVoOclxHXf9cKTD0L9vWICAlh+A9rVtujheJdHh9B7NmztT81bW8kT MD6w2rT+iruzEvgYo4w6dS54N1abiNdnWVH8oX5NR31Z9XC1mO4ghoYfA67/TA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652455993; a=rsa-sha256; cv=none; b=NDEC2K1kBIdM4clHoPws/hXfjCWpoGFGDIbIwDdYRXV6seoT6IdjdIW4DaLUIgV2cXHkyp mxXBSHZu1g3Lr00l83lzdNszks9DVtHeR0E0ujMsEgUM0+YUlv+qFF8iC80OLRXQq/9SWZ GHX4FondlGXt7RrfcgbQy5QiXg51ax9n4hncjLdLPgxIV+K0xIpLtR8TU/VkLNFaefdRq7 bScYFshHFe70CtPY/mlVO18U+ML6h6EHCgvifaSDGCafqzywt1YUXDpm0bGzEklqfCpxic Cj8JEZZ92F0OS2Kh2RdhjWnKC2Q5dXwvijNMcl9hscsq9OYZ51oLW0/AoaOTLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ZEYaZZG0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ZEYaZZG0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4E9BD3894D X-Spam-Score: -4.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: QSesPHYSJ01h Hi! Maxime Devos skribis: > This patch series adds $SSL_CERT_DIR/$SSL_CERT_FILE to youtube-dl, some > dependents and w3m, as they respect $SSL_CERT_DIR/$SSL_CERT_FILE. > > To make this easier (e.g. less duplication), I moved the definition of > $SSL_CERT_DIR/$SSL_CERT_FILE to a single location (guix search-paths) > instead of many separate packages. > > This moving was previously rejected by Ludo, but that was in a > different context, maybe in this context it's considered ok? I don=E2=80=99t remember the previous discussion, but here I think it=E2=80= =99s reasonable. It=E2=80=99s a case where, effectively, those variables that w= ere initially OpenSSL-specific are now honored by other pieces of software. However, the last few patches are incorrect in that, for example, w3m does not honor these variables by itself (its code doesn=E2=80=99t call get= env): --8<---------------cut here---------------start------------->8--- $ grep -r SSL_CERT_ $(guix build -S w3m) /gnu/store/aqdk56qa1lssjs50gvrii47ccc7ibmkp-w3m-0.5.3+git20210102-checkout/= rc.c:#define CMT_SSL_CERT_FILE N_("PEM encoded certificate file of client") /gnu/store/aqdk56qa1lssjs50gvrii47ccc7ibmkp-w3m-0.5.3+git20210102-checkout/= rc.c: CMT_SSL_CERT_FILE, NULL}, --8<---------------cut here---------------end--------------->8--- Instead, it honors them because it=E2=80=99s linked against OpenSSL. Likewise for youtube-dl & co. So I=E2=80=99m omitting the last few patches that add search paths. I hope that makes sense. Thanks! Ludo=E2=80=99.