From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yPxCIOiFi2Kz4QAAbAwnHQ (envelope-from ) for ; Mon, 23 May 2022 15:02:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sOocIOiFi2LC/QAA9RJhRA (envelope-from ) for ; Mon, 23 May 2022 15:02:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8E6CDBF2 for ; Mon, 23 May 2022 15:02:31 +0200 (CEST) Received: from localhost ([::1]:41850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt7he-0003dm-G2 for larch@yhetil.org; Mon, 23 May 2022 09:02:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt7eI-0008Lh-Pe for guix-patches@gnu.org; Mon, 23 May 2022 08:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nt7eI-00023E-8q for guix-patches@gnu.org; Mon, 23 May 2022 08:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nt7eI-0006WV-6y for guix-patches@gnu.org; Mon, 23 May 2022 08:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55253] nginx-rtmp-module not compatible with nginx Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 May 2022 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 55253@debbugs.gnu.org Received: via spool by 55253-submit@debbugs.gnu.org id=B55253.165331069225009 (code B ref 55253); Mon, 23 May 2022 12:59:02 +0000 Received: (at 55253) by debbugs.gnu.org; 23 May 2022 12:58:12 +0000 Received: from localhost ([127.0.0.1]:47604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt7dT-0006VI-QE for submit@debbugs.gnu.org; Mon, 23 May 2022 08:58:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nt7dP-0006Ur-4O for 55253@debbugs.gnu.org; Mon, 23 May 2022 08:58:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt7dJ-0001r5-Ad; Mon, 23 May 2022 08:58:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rrndyFTLhy5kjv+SVydN4447unOGI9HR5MBySBsw7IQ=; b=DUBDuO3r0PjMYdRyNdKt bPlVUju1SjYjEL9qVhLcXG/z08RopGz3Jm916q3HavINNaKvH7SG6h+01poMY0KZxf9/RByBoYzMe 8o/looHiDekZWO82eO/xzPEk4TRb2jNC4iZPyGDxEX7tEwkqk160hZwKu0kjpzd2nSgl+meEjyNPO oHMZvdR60tPEAdhroSQBQl4BywbzvnT/SFAnxXMmpKxCd+mHIFOiyIpY1jffhIHtZF6qZbCIa35ly XnwiKOq8LoATg4SbEbtyEet5BW1K5IeO6/3JvIbvYJoewLqGPWMVAth1NJdW9fGwYT1+9QoDAgZmR POjrCDiNCNljuQ==; Received: from [193.50.110.143] (port=58878 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt7dI-0001RI-ST; Mon, 23 May 2022 08:58:01 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220522055157.31807-1-jackhill@jackhill.us> Date: Mon, 23 May 2022 14:57:58 +0200 In-Reply-To: <20220522055157.31807-1-jackhill@jackhill.us> (Jack Hill's message of "Sun, 22 May 2022 01:51:56 -0400") Message-ID: <871qwk8kyx.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653310952; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rrndyFTLhy5kjv+SVydN4447unOGI9HR5MBySBsw7IQ=; b=Qp6n4z3jglDKxqSsm2aFtvlHKsacn/2QlvHaYOEDQGYmpt1E5rqTc+SmhzOTpZd4RlQXqb hZUG+toIEK0EWYbG85jjPHpx0FXFe2F1TSjg3Z5FHlPO+i7rz2NhV5rrCy59S1F/H3RnlA cxKizkrIkOlmnnqmpiDgiEJS0AIYHAZthmsXLpEyShp3t65t76ZDhJzeRDMoNuVHL/ughq UwU274sZxW3quGNhoEMly46/V8L/I/uD4AsmDKpoSlHuFEvlFXt+EuolZ68PMCE6qXRIL4 Q9szgkDNLnB77gr1R/Rq6+xdxo1SfK0zj5BYCXT8E/+CyXsBBj3/7Bsfm5NEzg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653310952; a=rsa-sha256; cv=none; b=XDp7yyBIz6ArD79gnwdzXcIHZ9W7SbOBBgz5kUArzbLPFAOoawSRYmFsbX04/oF6NmGyui 3YyFrt91ok8Dxop8S7eQ0b4TGjbY1muo4tK6bBVU3195o85cQijUpKnx9+IBafyUqyLkvq CO8z+pfEaBSGr1ZyJMQTI3H/LxiCw6EeLw1JeDJ7cUGC/VaM//vb1Ps+hQUIAvv6mcO8iV tFR/baD/H8DmT2nXwC1OrfvcQ6ZXocHeiRxW2WcwSI+++cEq//Ap8ZkJOZo6HBGtRBTlfn 4aXnQ2Qt76AQyxs/u1/pdLh2lrV4nEO4aom1IH7sWnNOXc1XNCdnLzk8UJi4EA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DUBDuO3r; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DUBDuO3r; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A8E6CDBF2 X-Spam-Score: -4.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2XlSgNYMQONi Hi Jack, Jack Hill skribis: > * gnu/packages/web.scm (nginx-rtmp-module)[arguments]: Simplify copying > of arguments from nginx and augment #:configure-flags from nginx > rather than overwriting. > --- > gnu/packages/web.scm | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm > index 600ef0c895..50401c07e1 100644 > --- a/gnu/packages/web.scm > +++ b/gnu/packages/web.scm > @@ -785,12 +785,9 @@ (define-public nginx-rtmp-module > `(("nginx-sources" ,(package-source nginx)) > ,@(package-inputs nginx))) > (arguments > - (substitute-keyword-arguments > - `(#:make-flags '("modules") > - #:modules ((guix build utils) > - (guix build gnu-build-system)) > - ,@(package-arguments nginx) > - #:configure-flags '("--add-dynamic-module=3D.")) > + (substitute-keyword-arguments (package-arguments nginx) > + ((#:configure-flags flags) > + #~(cons "--add-dynamic-module=3D." #$flags)) If I=E2=80=99m not mistaken, #:make-flags and #:modules are lost here, no? Or were they unnecessary in the first place? Thanks, Ludo=E2=80=99.