all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Paul A. Patience" <paul@apatience.com>
Cc: 56638@debbugs.gnu.org
Subject: [bug#56638] [PATCH] gnu: Add asli.
Date: Thu, 04 Aug 2022 23:40:52 +0200	[thread overview]
Message-ID: <871qtvlmaj.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220724120228.54052-3-paul@apatience.com> (Paul A. Patience's message of "Sun, 24 Jul 2022 12:02:57 +0000")

Hi Paul,

"Paul A. Patience" <paul@apatience.com> skribis:

> * gnu/packages/graphics.scm (asli): New variable.
> * gnu/packages/patches/asli-use-system-libs.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register patch.

The source derivation fails to build for me:

--8<---------------cut here---------------start------------->8---
File CMakeLists.txt is read-only; trying to patch anyway
patching file CMakeLists.txt
Hunk #2 FAILED at 172.
Hunk #3 succeeded at 240 (offset 1 line).
Hunk #4 succeeded at 253 (offset 1 line).
1 out of 4 hunks FAILED -- saving rejects to file CMakeLists.txt.rej
--8<---------------cut here---------------end--------------->8---

> diff --git a/gnu/packages/patches/asli-use-system-libs.patch b/gnu/packages/patches/asli-use-system-libs.patch
> new file mode 100644
> index 0000000000..d8234fd608
> --- /dev/null
> +++ b/gnu/packages/patches/asli-use-system-libs.patch
> @@ -0,0 +1,70 @@
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index b11c5ba..702423e 100755

Also, as suggested by ‘guix lint’, please add a comment at the top
stating what this does and what the upstream status is (if it’s been
submitted), at least something like:

  Tweak build system to use system dependencies instead of those that
  are bundled.

Could you please send an updated patch?

Thanks!

Ludo’.




  reply	other threads:[~2022-08-04 21:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  7:59 [bug#56638] [PATCH] gnu: Add asli Paul A. Patience
2022-07-19  8:10 ` Paul A. Patience
2022-07-19 14:21   ` Ludovic Courtès
2022-07-19 14:32 ` Maxime Devos
2022-07-19 14:34 ` Maxime Devos
2022-07-24 12:02 ` [bug#56638] [PATCH v2 0/2] " Paul A. Patience
2022-07-24 12:02   ` [bug#56638] [PATCH v2 1/2] gnu: Add mmg Paul A. Patience
2022-08-29 21:21     ` [bug#56638] [PATCH] gnu: Add asli Ludovic Courtès
2022-07-24 12:02   ` [bug#56638] [PATCH v2 2/2] " Paul A. Patience
2022-08-04 21:40     ` Ludovic Courtès [this message]
2022-08-29 21:21       ` [bug#56638] [PATCH] " Ludovic Courtès
2022-08-30 12:01         ` Paul A. Patience
2022-09-02 20:34 ` [bug#56638] [PATCH v3] " Paul A. Patience
2022-09-13 19:02   ` Paul A. Patience
2022-09-14 21:13   ` [bug#56638] [PATCH] " Ludovic Courtès
2022-09-15 13:37     ` Paul A. Patience
2023-06-20  0:39       ` Paul A. Patience
2023-09-08 17:16       ` bug#56638: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qtvlmaj.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=56638@debbugs.gnu.org \
    --cc=paul@apatience.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.