From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yE9JNT6r+GKhMQEAbAwnHQ (envelope-from ) for ; Sun, 14 Aug 2022 09:58:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6E9cND6r+GLELgEAG6o9tA (envelope-from ) for ; Sun, 14 Aug 2022 09:58:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 619111AE2A for ; Sun, 14 Aug 2022 09:58:54 +0200 (CEST) Received: from localhost ([::1]:55866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oN8WK-0006Lt-5G for larch@yhetil.org; Sun, 14 Aug 2022 03:58:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN8VX-0006Jf-8Z for guix-patches@gnu.org; Sun, 14 Aug 2022 03:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oN8VW-0005ab-V7 for guix-patches@gnu.org; Sun, 14 Aug 2022 03:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oN8VV-0001mT-Ko for guix-patches@gnu.org; Sun, 14 Aug 2022 03:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55891] [PATCH] gnu: Add iec16022 Resent-From: Remco van 't Veer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Aug 2022 07:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55891 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55891@debbugs.gnu.org Received: via spool by 55891-submit@debbugs.gnu.org id=B55891.16604638756832 (code B ref 55891); Sun, 14 Aug 2022 07:58:01 +0000 Received: (at 55891) by debbugs.gnu.org; 14 Aug 2022 07:57:55 +0000 Received: from localhost ([127.0.0.1]:35748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN8VO-0001m8-QZ for submit@debbugs.gnu.org; Sun, 14 Aug 2022 03:57:55 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:41657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN8VL-0001lr-E4 for 55891@debbugs.gnu.org; Sun, 14 Aug 2022 03:57:53 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 77BC632004AE; Sun, 14 Aug 2022 03:57:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 14 Aug 2022 03:57:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1660463864; x= 1660550264; bh=7+haAU4DnlTz4BgVXDEUvnncyLKwE6Hf+fcwpuzmvz0=; b=H pU75Ohho4o2iOjj4nVmw/u/tFIlnvcNfhrsHV8Y7EzGcM4ttX95oeQcHsUjq2a3C FL8bTICByRZrIoN074kSA+t4nmQt8lopMTsabBp5yNM/ppFHWot0t3pls3vl6YkR st1ayvnB2ROVUg9lS0DLP9WpM1dpxuUrCwRoaBydKGSC6eTp83N9JXT6g9L6owsE ouBej1ZFPxLDT4Bx/f29tot4QNWNz2WkcOUGE+ieUKeWK0AtJOeYIE9trRUvK5lh bHuukJ+GtdAV/tFnyFyYkJMgXfFH/YjfQtiwgvSluv9uSR6EYef2onTMfSh4+1Wx Ena1I3kLu/rNW7Fuwm9rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660463864; x= 1660550264; bh=7+haAU4DnlTz4BgVXDEUvnncyLKwE6Hf+fcwpuzmvz0=; b=u NdBBstR4XHMZU5edpZ7WtCb75KGsOmsVO423Gya/hZMfUEz3SdJzIijHy9q4n4fb vA5tz+DuRgTHjlyj4OSnyhJNIRlq0WlWRsI0Sf8O64xb4p/FxKS8aTwpv1WGv3Fq CH1bLCRnszMd+CNh/76yhS5HLxI00HtiVyMCcE15qUSS3uzWGjo07bBksBrVCOe0 7XNm7N+lfyXZBhewjWh7DUnpg7Xj13QhnKTiK6ICWBdCCSFYAI+yuQi2A+Dw4Ly4 piPevMFYIkE2mg1twxyy6yWBikkAgc3S33r37JnYxX21GBDIdjLd1C024fopkwQy +WI42Q/6/fB3y3JUDufzg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegledguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufgjfffkgggtgfesthhqredttderjeenucfhrhhomheptfgv mhgtohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtghosehrvghmfihorhhkshdrnhgvth eqnecuggftrfgrthhtvghrnhepkeeghfelhfeiueffjefftdeigfevgeegvdeggeefgeeu jeevuddvtdeutdeuhefgnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpghhnuhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehr vghmtghosehrvghmfihorhhkshdrnhgvth X-ME-Proxy: Feedback-ID: i568842cc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 14 Aug 2022 03:57:44 -0400 (EDT) References: <20220610150448.9513-1-remco@remworks.net> <2dfe4787038a3c9b6fe21982aea621c4447eca75.camel@telenet.be> <877d5opgd4.fsf@remworks.net> <87mtejhe1d.fsf@remworks.net> <87edzceqw0.fsf@remworks.net> <87tu819v5v.fsf@remworks.net> <3e39fece-f6b2-b3c1-da19-e1c78fee2112@telenet.be> User-agent: mu4e 1.8.8; emacs 28.1 From: Remco van 't Veer In-reply-to: <3e39fece-f6b2-b3c1-da19-e1c78fee2112@telenet.be> Date: Sun, 14 Aug 2022 09:57:38 +0200 Message-ID: <871qtjfea5.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660463934; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7+haAU4DnlTz4BgVXDEUvnncyLKwE6Hf+fcwpuzmvz0=; b=OLO0sKc46AffUercZBVKSCHnlno0YZ3/QLWUbvj9c15GgdYJp+sjgGzp5wnZpDIp77DNO9 lIaYLM29lQJOcEe7HTuqU4AYFpLlW0jn+Mqi7agO/nM9M/ssXhwShQdZgFvOcjSISWWuEK qc2WBUK2PrJ2coDPeEHM0J6D0M7Jy4ABAZ/dKxOf9S13zxqSyzf27I+e3vem74MdmlCbIw wpy1M0j3+bWupVKuwNjK7t6WsaqM/5tCFRVCAUbGt7GDbMSI0OOsnhuQsCtiYFi/U0FUMk kBogPpp1UUNSjJ8LAgR+cOyygDOa8X1kw6KGYChbidcSbEDKA2ToqWaxx+WBUw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660463934; a=rsa-sha256; cv=none; b=mgfDutLUErF7JUD4M15mHzge7tZq0GwJ5JrMnXXJ2hZimOnjfa0oA7Ntg9sB7T/pfkEsZs NbFmagcHZ7+BhI2DvbD87CDe7/YWZPcDsDob8tH4JaNO0h8hfqTwE3m6x3FIOk+DxuZBOd Zazj2qJcAJ0IwlbjW8d0wLaBVukvXxfYEXenkmIOstrjYuVfjp6nr/CjoRcmMVaFgeE8bS HkJOXAW4+uAOzJGBQg5S79NMdYRoF9mfA3Iws8b0NJvH8nnQqvkruKfBU88NDP/EPM5K9F CVld4I32p7DcV2TdJLznthaaa02DJ/qhbialQvo0+1hMsAgFy7VsFiGoAuHiXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm3 header.b="H pU75Oh"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="u NdBBst"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=remworks.net header.s=fm3 header.b="H pU75Oh"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="u NdBBst"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 619111AE2A X-Spam-Score: -0.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: ChaRO6g/kmXE Hi Maxime, Sorry for the late reply, I was out camping. 2022/07/31 01:48, Maxime Devos: > On 01-07-2022 08:58, Remco van 't Veer wrote: > >> Is there anything else I can do to keep this ticket moving? Bug about >> unchecked IO is reported and discussion about unchecked malloc has >> stalled. > > You could search for an alternative solution that is acceptable to > upstream, or if upstream completely refuses bugfixes, add some patch > to the Guix package definition.=C2=A0 Also, I have not yet seen a v2 for > resolving the other (non-upstream-code) issues I noted. The patches I did submit upstream were not accepted and I agree with the arguments of the maintainer so I won't add these to this package definition. https://github.com/rdoeffinger/iec16022/pull/17 Also, I did make a v2 but forgot to cc you, sorry about that: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55891#20 Also did a v3 because the copyright line was missing (and failed to cc you again): https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55891#35 > Another method would be to help out with reviewing and fixing things > (with other packages), this frees up time and is seen as a good act, > hence making other people more inclined to help out with any remaining > issues in your patches (including fixing issues such as those of the > kind I have mentioned before, but also actually applying the patch and > committing it). That's a great tip and I will try and leap over my newby/shyness feelings to get into that. Getting feedback like yours has certainly thought me a lot about what to look out for. Thank you for your feedback so far, also on the other patches I've submitted! > You could also perform _all_ the checks in (guix)Submitting Patches > (e.g., the bundling check, actually building it for other systems as > well with QEMU, reproducibility check). Just ran through them again and all seems to be fine. I am not sure how to prove I did. >> Also note, this package is also being shipped by debian, archlinux, >> fedora, and others. Not that it matters but just to point out it's a >> widely spread utility. > > I am not convinced by your implied method of persuasion by social > pressure / argumentum ad populum. If it doesn't matter, why use it as > an argument? What I should have written is I am moving and application from ubuntu/debian to guix and am missing this package. We already use a custom channel to make development possible but in doing to I was tickled by (guix)Creating a Channel mentioning: Before publishing a channel, please consider contributing your package definitions to Guix proper (*note Contributing::). Guix as a project is open to free software of all sorts, and packages in Guix proper are readily available to all Guix users and benefit from the project=E2=80=99s quality assurance process. Cheers, Remco