From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4E1tKLLgKmNDcwEAbAwnHQ (envelope-from ) for ; Wed, 21 Sep 2022 12:00:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wKqVJ7LgKmPwxQAAG6o9tA (envelope-from ) for ; Wed, 21 Sep 2022 12:00:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A0BF3365A for ; Wed, 21 Sep 2022 12:00:18 +0200 (CEST) Received: from localhost ([::1]:60476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oawWf-0002z4-CF for larch@yhetil.org; Wed, 21 Sep 2022 06:00:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oawWR-0002yo-FE for guix-patches@gnu.org; Wed, 21 Sep 2022 06:00:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oawWQ-0006Bf-C7 for guix-patches@gnu.org; Wed, 21 Sep 2022 06:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oawWP-0007u7-UZ for guix-patches@gnu.org; Wed, 21 Sep 2022 06:00:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57963] [PATCH 1/1] home: fontutils: Support user's fontconfig. Resent-From: Taiju HIGASHI Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Sep 2022 10:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57963 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 57963@debbugs.gnu.org Received: via spool by 57963-submit@debbugs.gnu.org id=B57963.166375438330325 (code B ref 57963); Wed, 21 Sep 2022 10:00:01 +0000 Received: (at 57963) by debbugs.gnu.org; 21 Sep 2022 09:59:43 +0000 Received: from localhost ([127.0.0.1]:60737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oawW7-0007t3-Ik for submit@debbugs.gnu.org; Wed, 21 Sep 2022 05:59:43 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:38467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oawW4-0007sp-Bf for 57963@debbugs.gnu.org; Wed, 21 Sep 2022 05:59:42 -0400 Received: by mail-pg1-f178.google.com with SMTP id t70so5415272pgc.5 for <57963@debbugs.gnu.org>; Wed, 21 Sep 2022 02:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=taiju-info.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date; bh=dcUdtul+/c5tYibo0P+kA/1g7XOiyIvJp0/xKXYa4DI=; b=OXpaNzw+2J/hjCTer+/sBYzWZzDTqKHxAWbjCL62MrM5KoarrZxakr5rMvzToVZEkv UYTAaifr5/sa+EV8119GPPERL32PpjBfkbv9OEcHtKB6RlqU2iv2xqIpcGmKCezo8TNG Eh2VXrq4oSCv13GzxdiRN4ZL7GhxPrBDug4VxR9jlao8WrvDk7URWf3zv8tZ2/Esi/Ra peNBSvPwokKH66znodlgRX/XeBxX2JmxDVbZwPGeR8LsJ7GLdXLAj4ONbU2QFWjZjg1M 44+xeIFgBcjDBqKECsqrag+zbMJeyR2/qGBjBldS3L2gaVAEL/pWNlXR1W54EakOywg/ c/yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date; bh=dcUdtul+/c5tYibo0P+kA/1g7XOiyIvJp0/xKXYa4DI=; b=oCncJ7DVxmrgFstsWD2YIEryFp7cr9UIvVpTWMImvnN7NajDICPo2Nmg4AuSAelDrD nIVAkwzdKp+UZxHIOl6ZAzqqVSy5jdfiepvml5wqUDFa7/gdDvqrV1W6cwieq3a4AJqr OCzWOnk/YzeQzGEyNwAiKcgUtZZilkIHNo9/dB+afq4iZ5WjyqYmS5RMeunYJN6GR50Z IhPRQWjLuCWMDUhH1fav2Bz//vWUB3AQGFzUiF9ky+mFrWRt2f2B1jUG7Yl7WUcvQ4VB N05HP0gsr+fodURdi0rp+x8MzbrW1H3PahzOMD+nDZmArdpn+qu2HTasNjx2daEOPcbR FX3A== X-Gm-Message-State: ACrzQf1HmtFHRuPRlOi4sYDwmadbb6jtInG0G5n1g9tDFqCBvHTb2XhE 32fEgHYcl1okSf/aA7hii7+/Nbr94Vg+dbUj X-Google-Smtp-Source: AMsMyM765QIAJ23b3dhFUHfWPT53F2GmXj9s3IIVFuwfq2ZpVgcGKOXs7aFBiSbSG0r6GP/FX0ic3Q== X-Received: by 2002:aa7:9851:0:b0:53e:87eb:1ffa with SMTP id n17-20020aa79851000000b0053e87eb1ffamr28222435pfq.35.1663754374138; Wed, 21 Sep 2022 02:59:34 -0700 (PDT) Received: from Taix ([240b:253:ec40:2400:b7d1:436e:2d61:e925]) by smtp.gmail.com with ESMTPSA id c6-20020a170903234600b0017680faa1a8sm1562347plh.112.2022.09.21.02.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 02:59:33 -0700 (PDT) From: Taiju HIGASHI References: <20220921002921.23631-2-higashi@taiju.info> Date: Wed, 21 Sep 2022 18:59:31 +0900 In-Reply-To: (Liliana Marie Prikler's message of "Wed, 21 Sep 2022 10:54:34 +0200") Message-ID: <871qs5xd30.fsf@taiju.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663754418; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dcUdtul+/c5tYibo0P+kA/1g7XOiyIvJp0/xKXYa4DI=; b=U4wKlFoM8MfliIbIba2c6G0LAL38fXARpTlK3M8N5a+HBdqrmbj33QXS/3/pRtcBuj98zp yVrZ2be+NAmykWKswgU6eAUT7dHOhzX7iW0AnE/nBxWKq7+JvKKiCZwyPDi8QVSLEhj1Yp 3QUr8Wwh+qaL0rh/yGgRNQHqhevbv0khHT1eb4rq11ehZKNbl7w/DlkxrD37KNSum+0ew9 osk85yUWfCZ2EvsrQXLxNNHVhffsdeaZNSSUf3YfRVDh1eMQmdb3JQA5eTlYd+ocyT5P18 RozsDTE3OnOKNlZcLt7DCviFlx1gBcylf7gnj3nAk6peRb7VLoAnjGLi471Emw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663754418; a=rsa-sha256; cv=none; b=WgrtRtUcOABSVO899JS4hS/TyoRoUe33Sy2ppv2my1ZuR0Sgt/7FucOyvF3djfXtujZPj1 AJGOeqZB1qjgHsKMmzx06ZeLECnKI0kbC7yFts31mSdrgcxPwcFoqyPilRmP+VQju4xj5G p4xfuY+pv/bpiZNTiR+masR0M0WI8u1zufW+JVIZiXr7PU30mNHnraNmW7SIO9zgiU2p9i BhbXth77JazmSkjNAsUjfSpb3K5CUO2d7CudQPxX0N9PcLPZn9EzgWZMKyhScEluoIQG7n Jp0jQ4UqhaqUR4N7bJYjAoJ/2NbbVG+/ntu/bsTE0EV7G66TiFBljrULyRYHyw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b=OXpaNzw+; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.16 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=taiju-info.20210112.gappssmtp.com header.s=20210112 header.b=OXpaNzw+; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4A0BF3365A X-Spam-Score: 1.16 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6By7eK2K7fmK Hi Liliana, Thank you for your review. >> -(define (add-fontconfig-config-file he-symlink-path) >> +(define (add-fontconfig-config-file font-config) >> =A0=A0 `(("fontconfig/fonts.conf" >> =A0=A0=A0=A0=A0 ,(mixed-text-file >> =A0=A0=A0=A0=A0=A0=A0 "fonts.conf" >> =A0=A0=A0=A0=A0=A0=A0 " >> =A0 >> =A0 >> -=A0 ~/.guix-home/profile/share/fonts >> -")))) >> +=A0 ~/.guix-home/profile/share/fonts\n" >> +=A0=A0=A0=A0=A0=A0 (if (null? font-config) >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 "" >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (string-join font-config "\n" 'suffix)) >> +=A0=A0=A0=A0=A0=A0 "\n")))) > I think it'd be wiser to pretty-print SXML here. > The structure could look something like > `(fontconfig > (dir "~/.guix-home/profile/share/fonts") > ,@(extra-user-config ...)) That's definitely better! Does this assume that SXML will also accept additional user settings? > Also, for the particular use case of handling multiple profiles > gracefully (rather than the current status quo) I think fontconfig- > service-type should be able to construct (dir "#$profile/share/fonts") > style entries on its own. However, given that multiple profiles aren't > supported yet, this is future work. Noted. I believe that even with the current patch, it is possible to add arbitrary directories, so it will be better than what we have now. Cheers --=20 taiju