From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cO5WBKkyf2NnMwAAbAwnHQ (envelope-from ) for ; Thu, 24 Nov 2022 10:00:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yBppBKkyf2MXyQAA9RJhRA (envelope-from ) for ; Thu, 24 Nov 2022 10:00:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9339124792 for ; Thu, 24 Nov 2022 10:00:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oy85e-0004lc-OF; Thu, 24 Nov 2022 04:00:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy85S-0004kX-P3 for guix-patches@gnu.org; Thu, 24 Nov 2022 04:00:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oy85S-0007Gn-8o for guix-patches@gnu.org; Thu, 24 Nov 2022 04:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oy85S-0001qr-4H for guix-patches@gnu.org; Thu, 24 Nov 2022 04:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Nov 2022 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.16692803537035 (code B ref 59513); Thu, 24 Nov 2022 09:00:02 +0000 Received: (at 59513) by debbugs.gnu.org; 24 Nov 2022 08:59:13 +0000 Received: from localhost ([127.0.0.1]:57206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy84e-0001pP-P9 for submit@debbugs.gnu.org; Thu, 24 Nov 2022 03:59:13 -0500 Received: from mira.cbaines.net ([212.71.252.8]:41970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy84b-0001pC-DM for 59513@debbugs.gnu.org; Thu, 24 Nov 2022 03:59:10 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 2BD4B27BBE9; Thu, 24 Nov 2022 08:59:08 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d63786e3; Thu, 24 Nov 2022 08:59:07 +0000 (UTC) References: <20221123104946.29480-1-mail@cbaines.net> <86tu2pfmbv.fsf@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Thu, 24 Nov 2022 08:40:59 +0000 In-reply-to: <86tu2pfmbv.fsf@gmail.com> Message-ID: <871qps20fa.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669280424; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=gG87yiK1nDLk5nrsVa/MJlLJMtGlRfuMxpvvR47f9mU=; b=s/Go5ElhnqMlvBIYk2uoazx1kYrldoQMnS0OETD0CRpd7A7ckw6ZwWkwnReDcjPaliYFD3 pm2OBEuXGzIzx32u5/JHjJXGD35ZpSb8CG/k9y3sjQL3VRKRhVH3Sn9MY+gZ6jMj3Wfnov DGkfD4afmrXY0USj5cvM4Hep9TwshFbZuSKmiuTSMeVOUUiclmtVSpZDXcRsuw5JJ9hT4Z YlGUigz/UpMb9kVrLJmXyNfG4R+wXIPcKN2HY2Aiy3B+pcSfMLQjAfWSgUWBv3L2UuuvBI eJwTmum5Tt1A7Ci6TI26Gzn4bPq5IqOkMCEuRhjs52RpB5y7kt12NhSVo4qeKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669280424; a=rsa-sha256; cv=none; b=EtG+uueGmhLZDGnro0pKpd7Zf0pIAesEtB6U07KnpzJPr6VhaY70buehuhXcz0EvSY1+hx zIrcKBtXoeNnRCkvQK98p7lm1r2DN6+m0dIvEkyD2EfMIeTDbWFKEHXsJq0VCdO2jTCqg2 ujwQdsVUNotPVUijNZZ6D82G/I1E4rWFJ3Y3lguxyvOhsBm9nipqRVQrw9rwgleEUD7jCp Gde8Emrqz7QEy2KoWIv9MlRAE70j3HxSj4cikAm9c6WNIKrKezFw5vsg/ZKCUA1L1iJngj NGbA1vHqXkqjr5oGeL2wcOTgtlgKa0u0h3q0xZfodAClIptzWN8r8RNG95lGVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.09 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9339124792 X-Spam-Score: -5.09 X-Migadu-Scanner: scn1.migadu.com X-TUID: QoLz43+JqL3m --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable zimoun writes: > Hi Chris, Hey! Thanks for taking a look. > On Wed, 23 Nov 2022 at 10:49, Christopher Baines wrote: > >> +For a minority of changes, it can be appropriate to push them directly >> +without sending them for review. This includes both trivial changes >> +(e.g. fixing typos) but also reverting problomatic changes and > -^ >> +addressing regressions. > > >> -For patches that just add a new package, and a simple one, it's OK to >> -commit, if you're confident (which means you successfully built it in a >> -chroot setup, and have done a reasonable copyright and license >> -auditing). Likewise for package upgrades, except upgrades that trigger >> -a lot of rebuilds (for example, upgrading GnuTLS or GLib). We have a >> -mailing list for commit notifications (@email{guix-commits@@gnu.org}), >> -so people can notice. Before pushing your changes, make sure to run >> -@code{git pull --rebase}. >> +In general though, all changes should be posted to >> +@email{guix-patches@@gnu.org}. This mailing list fills the >> +patch-tracking database (@pxref{Tracking Bugs and Patches}). Leave time >> +for a review, without committing anything (@pxref{Submitting Patches}). >> +If you didn=E2=80=99t receive any reply after one week (two weeks for m= ore >> +significant changes), and if you're confident, it's OK to commit. > > I would write: > > =E2=80=A6 changes), and if you're confident (which means you > successfully built it in a chroot setup, and have done a > reasonable copyright and license auditing), it=E2=80=99s OK to co= mmit. chroot setup doesn't really make sense to me, I'm not sure why that needs specifying (like do we not want things for the Hurd pushing, since the guix-daemon doesn't support build isolation there yet)? Also, this guidance is very general, and I think it should be applicable to all changes. We already trust people with commit access to know what needs doing, I see this documentation as more about how, so I'd prefer not to try and put a list here. > and I would keep the =C2=ABtwo weeks=C2=BB instead of the =C2=ABone week = except=C2=BB. My reason for changing this is that I think waiting two weeks after sending a simple patch is unreasonable. The value from the automated testing will come after one to two days, I just put a week to avoid changing it too much, but maybe the lower bound should be two days. > I think it is also useful to provide the information about commit > notifications (guix-commits mailing list). Why though? What do we expect people with commit access to do when they read about that here? > For what it is worth, I find clearer the structure, > > For patches that =E2=80=A6 > For anything else, =E2=80=A6 > > or > > For a minority of changes, =E2=80=A6 > For anything else, =E2=80=A6 > > than =C2=ABIn general though, all changes =E2=80=A6=C2=BB. That seems fine to me, I think "everything" maybe carries more weight than "anything" though. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmN/MllfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xco1BAAo8cViaAHyIRxSikHFBnTcOshRBK0350y zwERyqUBZM7mibm4LLt2uxTpKSXFR38L0qzjHnsNNLj387pkvvRdYgp9JblkB0mX Zw+6w9dinAMW/0YTnmkQJ/ecQqFBoYLRPw2k+qNavUg6r1AvuhGE9fej+pndItYO XZUqtRyUBBOa1sShBIiqJEeWP1EWczrRBvkrDNoDinoALk/QE5dKW/jkpvxAm3dB zugux7V8ihbaoOapaOJSLUnqApRzFAG+/6PBnYpqvw70TTkh+MdyUcH9RjdhV9aB E65CvRiFKXZnVVf6Ej9y2+UO+bk3whBTrul0Df53bFwdSFSuw69X2H3p0F5NVpWx NDf/8lJFid95P+JVW68HJrNOe2bM/aD9lxVjIE1arBsJ7LVvzf3WLshkM5P0x45E fVqGxdHpnFdDGLh/C9cWF3HUtWbyoOhXeQRDULeXk1w6UVImFiING/LqGB0twHM+ tAQaE8Mk91KGNd0q3zKRGiL5pfLi3sNtz5YDQA9nXDEU4I1FPRa6s5Ewv+x/ZO5a bB0uprax640DN35K0vRkM0VtxdM2p9YpKrxgQfhbU5IdAjjLnrkjTJUvRaAUsyVA ggbWJRhjMzaVye1p7yv7WejisKThw1bz54syVejSh/6Kv53GvjPWFzk3En7r56Sx JfNH6nVDTOE= =JvxO -----END PGP SIGNATURE----- --=-=-=--