From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iIXxKDUHl2OgpgAAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 11:49:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +D7dJzUHl2M8qQAAG6o9tA (envelope-from ) for ; Mon, 12 Dec 2022 11:49:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F63226D4F for ; Mon, 12 Dec 2022 11:49:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4gMq-0001fR-Tn; Mon, 12 Dec 2022 05:49:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4gMp-0001ci-13 for guix-patches@gnu.org; Mon, 12 Dec 2022 05:49:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4gMo-0006gf-OM for guix-patches@gnu.org; Mon, 12 Dec 2022 05:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4gMo-0008Vm-DT for guix-patches@gnu.org; Mon, 12 Dec 2022 05:49:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Dec 2022 10:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.167084214132712 (code B ref 59513); Mon, 12 Dec 2022 10:49:02 +0000 Received: (at 59513) by debbugs.gnu.org; 12 Dec 2022 10:49:01 +0000 Received: from localhost ([127.0.0.1]:52139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gMm-0008VY-K2 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 05:49:00 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gMk-0008VS-Ho for 59513@debbugs.gnu.org; Mon, 12 Dec 2022 05:48:59 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157]) by mira.cbaines.net (Postfix) with ESMTPSA id BD50627BBE9; Mon, 12 Dec 2022 10:48:57 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 6ccac0f9; Mon, 12 Dec 2022 10:48:56 +0000 (UTC) References: <20221123104946.29480-1-mail@cbaines.net> <875yeuyf1z.fsf@gnu.org> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Mon, 12 Dec 2022 10:33:46 +0000 In-reply-to: <875yeuyf1z.fsf@gnu.org> Message-ID: <871qp4rj6y.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670842165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=6eSIeuacmuOWg5b7zXxLiLpI9wc0DZWDQrnnmP/BiCc=; b=pB+Ke0Da+vPVIi1A10juvGElH6ZHKE5fyqhA2sRzeug5oU4QEjw+w/ceNsN2zjYAvJqyFx Kjgg4pxm93met3Dn9D6G31s2Y3/+rV7cHUKKj00s+s24clw+oy3rZJ4AF4FDrRSnrSJB7b p95gC/XyrG8yADHPBOn2FOCwxgAmqswCsmCJ79vVXLXfiZrNtqThWB8Pw88oake8+4T2BQ qj19X8PSH0mhQbM2b/MLGroaN8sVzj0JzzWL7j7CwMbV8bKYxBHfmPHqwkZ1FK4xFRbmC+ wA8GGDfy8gewVs1Sj8xZnPlBtB5N0xVYn8FKoNoy4OvaBGP3IscB/s/ApFIfhw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670842165; a=rsa-sha256; cv=none; b=dwyKY8fyxJCjdGT/cr56/MtHsN1Aja1RkB6cMB6KAoIHQUEvRL2H/mIBbrbSmEikVejlfV A0MLKvqqTOJdOlPLErsHLhBOonkdgY+/zZokm5gxDduIRoUYPJY2WTZwFH3m+IMsh8rVxo l6yo7Z6Fpr34odm90Ucs0y5Occ6K5ROTTZqbwvL3gnlDabqWnkvNZbMYZfZT12QoqkBB7J t8rhR0mpQhPPeNxoJ9fJykuuTtg+VZJdeq1FR34kZXWuYMMRgpP69kgDI7EkjavfOh1ABG CJ5M9kwUo40GkbwdJi8/CENdN5iUC4tpCvkiHWji8puIT5dWF8Vnw1/pjD+mxA== X-Migadu-Spam-Score: -5.06 X-Spam-Score: -5.06 X-Migadu-Queue-Id: 4F63226D4F X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: h65WNR6L2V3K --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> @subsection Commit Policy >> >> -If you get commit access, please make sure to follow >> -the policy below (discussions of the policy can take place on >> +If you get commit access, please make sure to follow the policy below >> +(discussions of the policy can take place on >> @email{guix-devel@@gnu.org}). >> >> -Non-trivial patches should always be posted to >> -@email{guix-patches@@gnu.org} (trivial patches include fixing typos, >> -etc.). This mailing list fills the patch-tracking database >> -(@pxref{Tracking Bugs and Patches}). >> +For a minority of changes, it can be appropriate to push them directly >> +without sending them for review. This includes both trivial changes >> +(e.g. fixing typos) but also reverting problomatic changes and >> +addressing regressions. >> >> -For patches that just add a new package, and a simple one, it's OK to > > Similar to zimoun=E2=80=99s first comment I think, I would like the begin= ning of > the sentence to clearly tell you whether it=E2=80=99s the situation you= =E2=80=99re > interested in. =E2=80=9CFor a minority of changes=E2=80=9D doesn=E2=80= =99t fit the bill in my > view. > > So I would suggest something along the lines of: > > Changes should be posted to @email{guix-patches@@gnu.org}. This > mailing list [=E2=80=A6]. It also allows patches to be picked up and t= ested > by the quality assurance robot; the result of that testing eventually I've gone for "tooling" rather than "robot" as I'm not sure we want to go the way of personifying it. I'm not against that, but the place to start is probably not here. > shows up on the dashboard at > @indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where > @var{number} is the number assigned by the issue tracker. Leave time > [=E2=80=A6] it=E2=80=99s OK to commit. > > As an exception, some changes considered consensual and ``trivial'' or I removed "consensual" here as I wasn't sure what was meant by that, or at least I'm not sure the phrasing fits the context here. Are you trying to say something about a belief that no one will object to the change being made? > ``obvious'' may instead be pushed directly. These include: fixing > typos, and reverting commits that caused immediate problems. > > That way we state the general rule first, and the exception next. That > also explicitly mentions how that relates to qa.guix. Yeah, I think that's better. I've sent a v2 patch now (for some reason I forgot to send this email until now). Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOXBxZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xf8Tg//VyvwbuQw4rCY+n4pC7BEuLHnMqEbLAls 7AoeL2/FjnsATICEi0W9YWAk1LopjLTUe53bMbbalgiNE3VHo8t+la1Xw+fWAe+3 alfR900rwnjabWEauAR3HSCmDcxUq7VvSY7xRNo3+kfjyMF7OCW9jLeBGWc4zhSt kTXpQHeQ2Jymb+lwckSGgAxuM18HoS40bdeEgf//pJUycXEX+17h6U+kioDm9YDs erJAVmL73ZjESnyjYRJuNcgVMpsKaZXrapT5dMnM9WhqChnx/pH50DachbsBIIID 7AvSdB8EJS/234hHhDEkqfrWJsepTHkEGW/Unn2SnfCMGAXLA5UzoiJeHGZZINcX geXKFGH8VTWk52kRyLWY+7dORFQQuL6GAImfIlbHeG7FarXk4JRVveNwOFcfB9K0 HhNCOwSWsOwBc2GtcTPEuKCc3HcVabqWm0fiSMMxxbk7pZsfzpTEtkD6FEJW0jgm NANOW1TYN0Zt7RMDQ7wX/daReJYYX9Lx3OJsH6KyjkmP0DgQl21CFoxaqsXMmxMt +xH3l7OPYqXmp5imgrHTBmC/JU7j827v1JKTruR81ZrKrxmqn0RIEaEoTAcZ3EAJ NC9tebehOZ8ZdRrCI4ALD2oznh2/YYJRqzeGAS2t6Au8vBihSAEwiSyHMElTLWzB JkrDMULAjuU= =Gpnb -----END PGP SIGNATURE----- --=-=-=--