all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Andy Tai <atai@atai.org>
Cc: 59093@debbugs.gnu.org
Subject: [bug#59093] [PATCH] gnu: Add xnedit
Date: Fri, 06 Jan 2023 12:50:51 +0100	[thread overview]
Message-ID: <871qo7khk4.fsf@gmail.com> (raw)
In-Reply-To: <CAJsg1E9or6WBS-BnwBV_PEqOOpyniZeLVFfuhGoB9V5fa9paKg@mail.gmail.com> (Andy Tai's message of "Sun, 6 Nov 2022 21:12:38 -0800")

Hi,

On Sun, 06 Nov 2022 at 21:12, Andy Tai <atai@atai.org> wrote:

> +      (arguments
> +       `(#:make-flags (list (string-append "PREFIX="
> +                                         (assoc-ref %outputs "out"))
                                                      --^
                                                   this

This pattern is now deprecated, if I understand correctly.

    https://guix.gnu.org/en/blog/2021/the-big-change/

Instead, something like,

      (arguments
       (list
       #:make-flags #~(list (string-append "PREFIX=" #$output)
                            (string-append "CC=" #$(cc-for-target)))
         #:tests? #f                  ; no tests
         #:phases #~(modify-phases %standard-phases
                        (delete 'configure)
                        (replace 'build
                            (lambda* (#:key make-flags #:allow-other-keys)
                                (apply invoke "make" "linux" make-flags)))))))

seems more compliant with the “new” style.



> +      (inputs (list
> +              motif
> +              pcre))

Incorrect indentation or just (inputs (list motif pcre))


Cheers,
simon




  reply	other threads:[~2023-01-06 12:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07  5:12 [bug#59093] [PATCH] gnu: Add xnedit Andy Tai
2023-01-06 11:50 ` zimoun [this message]
2023-01-07  7:14   ` Andy Tai
2023-01-11  2:44     ` Andy Tai
2023-01-11 15:02       ` Simon Tournier
2023-01-12  3:25         ` Andy Tai
2023-01-12 10:03           ` Simon Tournier
2023-01-12 10:08             ` Andy Tai
2023-01-12 10:26               ` Simon Tournier
2023-01-11 14:56 ` [bug#59093] [PATCH v2 1/2] gnu: Add motif Simon Tournier
2023-01-11 14:56   ` [bug#59093] [PATCH v2 2/2] gnu: Add xnedit Simon Tournier
2023-01-29  1:13 ` [bug#59093] [PATCH v3 1/2] gnu: Add motif Andy Tai
2023-01-29  1:13 ` [bug#59093] [PATCH v3 2/2] gnu: Add xnedit Andy Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qo7khk4.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=59093@debbugs.gnu.org \
    --cc=atai@atai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.