From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UOEMEm8Qv2NDEAAAbAwnHQ (envelope-from ) for ; Wed, 11 Jan 2023 20:39:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WOlIEW8Qv2OklQAAG6o9tA (envelope-from ) for ; Wed, 11 Jan 2023 20:39:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F2D1A20A3F for ; Wed, 11 Jan 2023 20:39:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFgwG-0002HX-Hm; Wed, 11 Jan 2023 14:39:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFgwB-0002H9-3F for guix-patches@gnu.org; Wed, 11 Jan 2023 14:39:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFgwA-00052e-Rg for guix-patches@gnu.org; Wed, 11 Jan 2023 14:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFgwA-0003HJ-De for guix-patches@gnu.org; Wed, 11 Jan 2023 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60632] [PATCH 1/1] services: base: Add extra-env support to guix-configuration. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Jan 2023 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60632 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 60632@debbugs.gnu.org Received: via spool by 60632-submit@debbugs.gnu.org id=B60632.167346591212563 (code B ref 60632); Wed, 11 Jan 2023 19:39:02 +0000 Received: (at 60632) by debbugs.gnu.org; 11 Jan 2023 19:38:32 +0000 Received: from localhost ([127.0.0.1]:43921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFgvf-0003GZ-LJ for submit@debbugs.gnu.org; Wed, 11 Jan 2023 14:38:31 -0500 Received: from mail-vs1-f46.google.com ([209.85.217.46]:42896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFgvc-0003GK-DU for 60632@debbugs.gnu.org; Wed, 11 Jan 2023 14:38:30 -0500 Received: by mail-vs1-f46.google.com with SMTP id d66so4417990vsd.9 for <60632@debbugs.gnu.org>; Wed, 11 Jan 2023 11:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BMvIOgA7aGVaJpdRfu+i3WPqp2PRXJzobiu9GoNhc5k=; b=dK/6wo8HGC4k9i/+526kogvRmxjKsHAiHmuBf96cM3389WdB0pjvcUfXPYKIIhoQaZ 07SqYFJ2nwzVfEoWCZYgV3sN0Wrky6+uuGqCZMRbVXW8EWh18BEx4b2U7YsqAYP5ZBc1 rM6vxzIi6cl7VWezFueNKMbo3cfqXW7/iZBfwLEjWU6rh0XJ5qCUCtZ/iFIymm7SI5DN yTXMF36tFCBCAFKAe/kUAI7d3/rHWX4LY8oiPmKfHhX84WbQcBPr7jasOFRBC0ZwehZH rTtvhlXDcuiSLEq+TqipXof+c0LkD1RlsNW14C9xyXDIFIUKQg3QbIGv+2EoFsav8sO0 0H6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BMvIOgA7aGVaJpdRfu+i3WPqp2PRXJzobiu9GoNhc5k=; b=VabV5jNvePx5e7mO2F/FGaWh7wBOyK9BUAjhu2T8wOAz2UMZiwZ7sxxPhQectyudj6 xPVAcrPcE12JfJKY4hNdnAsSXWFnA0elrChDtP3ayjuwGrP1vt7jk0x5b0uXDY3qT7db FEOxXrbrjLpq9uOTVsrUSejyueuMlVMMLWT29lP3sx0H7OLh8fUq2dpHmHXeW5ZcwiuO weG5JPs6Mu8qHwKHF4l75VUpeinXj7sXVjQxY61fPpPZrI3eDJm8Cd0TzvAX/zAqEooj OAOZWlSwiUQsy2yFwp9K/uq0RZ7jcAtSL5Rv5daP5LceThRMhXfNc2aqTvaDAsc5FCvh u7JQ== X-Gm-Message-State: AFqh2kotbvRrn6BthqJnz220kjQB0VlTyUp2zH62tDnxvLqu0j30TBkG +HA52wudQouGrUJV45SVX9ZL8DJk5k2hmg== X-Google-Smtp-Source: AMrXdXtzGPmFqdxHWtBevAj+bLcn8NedDC3oS7l+UyMNqAjnQaNI7kTRbuVoXsjYuKOT7mnhzo1ubQ== X-Received: by 2002:a05:6102:3022:b0:3ce:9934:c5f5 with SMTP id v2-20020a056102302200b003ce9934c5f5mr20241887vsa.20.1673465902332; Wed, 11 Jan 2023 11:38:22 -0800 (PST) Received: from hurd (dsl-159-79.b2b2c.ca. [66.158.159.79]) by smtp.gmail.com with ESMTPSA id d6-20020a37b406000000b007049f19c736sm9368153qkf.7.2023.01.11.11.38.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:38:21 -0800 (PST) From: Maxim Cournoyer References: <20230107181938.14334-1-othacehe@gnu.org> Date: Wed, 11 Jan 2023 14:38:20 -0500 In-Reply-To: <20230107181938.14334-1-othacehe@gnu.org> (Mathieu Othacehe's message of "Sat, 7 Jan 2023 19:19:38 +0100") Message-ID: <871qo0j1zn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673465967; a=rsa-sha256; cv=none; b=nkEq+YehLm7zn0Wanx+IYyMlQyoCcXhljlkrq+CyOXIKcHHwTRnUy1SHNQbcsfH55LnaEC eAmeg0C86dxn5oOw/n3mbGtlowBDOYrw6Dvs5wPinJUGmGZhLEsaSVXL7QY4cdB0PGOQ1V JfeS/BFn5fAV5nq+iSQe72mV8n0sCSPO9Ysb1GIYPgeqA3bm2c0tPKc5LEKkaPTXwtinzq 03yPODmqgV67S64IjhALYOHqSOzIskedzryij0M+CF+dBp53pnoShKidjBIOAcrnHwe1zb y+vPMtUG8EDV7z9l0iA8SeLeLcIOiQiV4PDxarPxN5/DbAu2qm5BUUMA6TeG0A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="dK/6wo8H"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673465967; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BMvIOgA7aGVaJpdRfu+i3WPqp2PRXJzobiu9GoNhc5k=; b=HDFbRkWueQD/NRBLjjkjazvRxr2UR0la1niHDkGGdBzlcdLzB+/bdnBx3bCJqhgCnaZHDP vqKuJfDiWp3gJGG2FBSVLvIhG7w6k+ERVowJ5/P4x+qb9hF7brIzwxOrgpEjfS4N2PHUeW qJyCfSIJftcDxINMQ0WbJS4RQUEogPbdfOxU2Hpfm7tVFFF4qV8GnebgSrg9sut9gYTbaD mXpL848u+uq2s7xodUlzUTUjZ4waJNFhW7UqpCX/Y9GdziMzdxiMTIExIjhS+Qd72gARPH gtvImedrKnFAjktMx/2qAhK1ybm/768iWEs2pOxyN/Brm/+arhiWUpbh0s55LQ== X-Migadu-Spam-Score: -1.99 X-Spam-Score: -1.99 X-Migadu-Queue-Id: F2D1A20A3F X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="dK/6wo8H"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: XvMmy0FS2FOU Hi Mathieu, Mathieu Othacehe writes: > * gnu/services/base.scm ()[extra-env]: New field. > (guix-shepherd-service): Honor it. > * doc/guix.texi (Base Services): Document it. > --- > Hello, > > Here is a small patch to allow defining extra environment variables in the > guix-daemon context. > > I intend to use it to set the GUIX_SUBSTITUTE_DEBUG variable to debug > https://issues.guix.gnu.org/48468. LGTM. Side topic: I wonder if (with some changes to the daemon -- perhaps in DerivationGoal::startBuilder) in nix/libstore/build.cc we could leak the COLUMNS variable to be able to control the Guile builder backtrace width. -- Thanks, Maxim