From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QHx0M+9zC2SOaQAASxT56A (envelope-from ) for ; Fri, 10 Mar 2023 19:16:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aEFaM+9zC2SRYgEA9RJhRA (envelope-from ) for ; Fri, 10 Mar 2023 19:16:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3C1AE221 for ; Fri, 10 Mar 2023 19:16:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pahHl-0007Fj-8S; Fri, 10 Mar 2023 13:16:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pahHe-0007DV-PZ for guix-patches@gnu.org; Fri, 10 Mar 2023 13:16:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pahHe-0007Sr-Aq for guix-patches@gnu.org; Fri, 10 Mar 2023 13:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pahHd-0004wq-Kn for guix-patches@gnu.org; Fri, 10 Mar 2023 13:16:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61744] [PATCH v2 1/2] services: base: Deprecate 'pam-limits-service' procedure. References: In-Reply-To: Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Mar 2023 18:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61744 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61744@debbugs.gnu.org Cc: mirai@makinata.eu Received: via spool by 61744-submit@debbugs.gnu.org id=B61744.167847210718948 (code B ref 61744); Fri, 10 Mar 2023 18:16:01 +0000 Received: (at 61744) by debbugs.gnu.org; 10 Mar 2023 18:15:07 +0000 Received: from localhost ([127.0.0.1]:55848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pahGl-0004vY-20 for submit@debbugs.gnu.org; Fri, 10 Mar 2023 13:15:07 -0500 Received: from sender3-of-o58.zoho.com ([136.143.184.58]:21893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pahGi-0004vM-Eo for 61744@debbugs.gnu.org; Fri, 10 Mar 2023 13:15:06 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1678472100; cv=none; d=zohomail.com; s=zohoarc; b=l9WgHV4E2fhY22Pn40kC5jMRpwJLkH2tMpQRCebTYSQ0BwPxpWoKHjTESDyxfjqUkbMXfm9QzJOOJYsEnNXDrOAkxz6EM5YlM0VUwuc2Xr3LJACRWZjlLCCfnZEUgLeXGKrwrYdtFJUfYa3SW4LFJZ0clHPmq8zZF1ocmfYfEvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678472100; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=qN0AFjbkfkQ781FuPAn9+5iNywDRecCWyl1ksSuZNXE=; b=cCU6ie0i+/WNBnGctfoy+BVG951Bu7Aw+mAoML97OG2Ozu6KcsAh/pJ24PQPn0QjAf1fTKJnhfGQofpx58DYqTewnIXJ3EJ5SAaB77hP0ktEUUfHBaVTxQvTOhf3vuqT/PpMzsxmifSkE/yfyh6PWJ/GQzNcwMKk30LHm6ekAMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1678472100; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=qN0AFjbkfkQ781FuPAn9+5iNywDRecCWyl1ksSuZNXE=; b=W12No788NAvwM8lpWm7TmFD0X7iBsN9m0+c2ku0YxUZX/WLUzRXyKL1Azt8cftYp UMP+ORLzuS47fOMCHYKcywRIKuWqWvtZgeYYbXZIivSfe/NThhswa8ThuzNZZRHIz4K xoIR9B0FifDxRRFUo+W2M7/lBGir+Y4bOlRa5cZw= Received: from localhost (59-108-142-46.pool.kielnet.net [46.142.108.59]) by mx.zohomail.com with SMTPS id 1678472098625288.8338659484524; Fri, 10 Mar 2023 10:14:58 -0800 (PST) User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus Date: Fri, 10 Mar 2023 18:52:43 +0100 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <871qlwo4m8.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=W12No788; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1678472175; a=rsa-sha256; cv=fail; b=mslTzZjZVbal0VjLDJWUCnBJkw6RWC6NO1vkumytxsMwhZzwlIZLM7sgIG187rUe0X/ZLy XJIOQT68W9X5LkpzHHPfNe8qXQfKQqgIPuipkqMSX5nVeKev+p95vsSmP9kvMvketAd8k3 /4Ic3QJNVnc8JX8mZXIwLPy6jeOfNMTQgiG2GJuplxZSG7jmwKc8zFzys0uP4v88OXk2Av 4FqEhGG9CGwQeVRgtpdLj+0AJNpqEODiEwV3cgU5bS6kkETdxC71flw410LeCmlNKz+4TH Uh3vPYu1zinVN5b6EfWtcHi5xwqqso0uSo1fNgEHtHRPULJAotDI1zosULCwvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678472175; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qN0AFjbkfkQ781FuPAn9+5iNywDRecCWyl1ksSuZNXE=; b=HYwd2FwTqn1ESU1jUwgo++gqc5GefGhSh1Fu42FGkd/t33XUgpCVHNzmuidYUqUmGOpprK OZcxql4T/1/OxNVofEGMQ5dZOiAedQ2iUWDOnoOHYaTeqmGfNnxYI8bbHADCMkaXl/KFGg bCForqVBG4Vpsstt8tjLed1zx/yV+YbsV78Q9UTzGosVPGflx76O8tptAGEpAZb/j0ReBY A0XbIAHYqTJ/4kThuvjJapwPiBcwXH8m0bPi6VQoco4XiBtL+ztmbP+Z68hD/SsFrjG7+V QLzuG1KCBkx2brVbSWI0hQXupzAFVhB9YC/6sqQCq/pjuzXsGOZdFOaL2ZOpbQ== X-Migadu-Spam-Score: -1.19 X-Spam-Score: -1.19 X-Migadu-Queue-Id: E3C1AE221 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=W12No788; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") X-TUID: dVnvJjJzQasU Hi, thank you for the patches! The effective change looks fine to me, but I=E2=80=99m confused about why t= hese are two patches. The first one introduces this as an example in the docs: +(service + pam-limits-service-type + (plain-file + "limits.conf" + (string-join + (map pam-limits-entry->string + (list (pam-limits-entry "@@realtime" 'both 'rtprio 99) + (pam-limits-entry "@@realtime" 'both 'memlock 'unlimited))) + "\n"))) But the second removes this again in favour of this prettier form: +(service pam-limits-service-type + (list + (pam-limits-entry "@@realtime" 'both 'rtprio 99) + (pam-limits-entry "@@realtime" 'both 'memlock 'unlimited))) Which is really close to the original form: -(pam-limits-service - (list - (pam-limits-entry "@@realtime" 'both 'rtprio 99) - (pam-limits-entry "@@realtime" 'both 'memlock 'unlimited))) Could you merge these two patches to reduce the number of unnecessary changes? I don=E2=80=99t think we should change to file-likes as the argum= ent value for the pam-limits-service-type. Another thing that confused me: + (test-equal "/etc/security/limits.conf content matches" + #$(string-join (map pam-limits-entry->string pam-limit-entri= es) + "\n" 'suffix) + (marionette-eval + '(call-with-input-file "/etc/security/limits.conf" + get-string-all) + marionette)) Why use the gexp with a computed value here instead of using just the plain text of the expected contents of that file? Computing the expected value in a test where the compared value is computed in the same way feels like begging the question. Or perhaps I=E2=80=99m misunderstanding something here? --=20 Ricardo