From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kKlwIxUYsGToaAAASxT56A (envelope-from ) for ; Thu, 13 Jul 2023 17:28:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MBs3IxUYsGQZaQEAauVa8A (envelope-from ) for ; Thu, 13 Jul 2023 17:28:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 130224B877 for ; Thu, 13 Jul 2023 17:28:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=RJpI6CWm; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689262101; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CorsTnEfVkyliyDXjye3FRKabZstppFa/uW3ZxwCe0g=; b=cuzvCHNpZJ9heKZL2Q2/Hgtz8uE70kpIr/xeKsauagsVfgdraMEdsxQgUNBTIFN7YHUFhw xiUImJJghw22P0E+ZxD+2ZHO/nd/Y4i/lyTGzBq9o4etFoH01xA2I9JbFusFze3e/fCxGS 7R9rJdxsIx/0HUGNGKtPwLmYNSnBnmmzL2JJrHaWukrUyRTU/6WJcOi4MrjbrrbgxwyXzs ZznAxWBGy9KMAvTkAuHk5oMQQmk7/LNcjvPCXf+OFvTOTnP+znyZ3Lmgo9qxhjoEET1NS/ Qgy/g8s13TXm+vNpHTj+ArfKcvOqt0q/FAJrkQt+xY1D6zavozbfeEShSixArA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=RJpI6CWm; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689262101; a=rsa-sha256; cv=none; b=SM+x2jkUghC1+0EWmFTdJfSG1uO9XOuKytZKJL749zz9PQQ2kWmQGt12KC1YGxoi5D4fcY gqgQC3UhoSWmb8HqgwKsex9OdI9eQywHSwQQHuPoOk/b83KDXGnu9ATK1TiXr0JoUpNb7d LoxYHSZoYESEus7pO2JGQ20pA92ayssErgMyjrM7KvMa9Znq0LJRYc9CURrgQbUvtBNb3S /vX/sLHwLeezCumfg/WZLBP8XpXqX1w25f9jnnKQp22+Da+YxHLdeP9cmtRw3EQMIWitMN QCb45r2Bm+UoExfkDLCLe8XRjDEz+3DhTguhYlA2+kGtaOTKfqIlPV0oofdY7g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJyEd-0004WE-VO; Thu, 13 Jul 2023 11:28:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJyEc-0004VU-Ro for guix-patches@gnu.org; Thu, 13 Jul 2023 11:28:02 -0400 Received: from [2001:470:142:5::43] (helo=debbugs.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJyEc-0000zU-Jz for guix-patches@gnu.org; Thu, 13 Jul 2023 11:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJyEc-0000pX-4T for guix-patches@gnu.org; Thu, 13 Jul 2023 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64188] [PATCH 0/8] More package tuning Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 13 Jul 2023 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , 64188@debbugs.gnu.org, Ricardo Wurmus Received: via spool by 64188-submit@debbugs.gnu.org id=B64188.16892620503037 (code B ref 64188); Thu, 13 Jul 2023 15:28:02 +0000 Received: (at 64188) by debbugs.gnu.org; 13 Jul 2023 15:27:30 +0000 Received: from localhost ([127.0.0.1]:40604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJyE6-0000mv-5n for submit@debbugs.gnu.org; Thu, 13 Jul 2023 11:27:30 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:45016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJyE3-0000mX-Hi for 64188@debbugs.gnu.org; Thu, 13 Jul 2023 11:27:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=CorsTnEfVkyliyDXjye3FRKabZstppFa/uW3ZxwCe0g=; b=RJpI6CWmZDkmQ13aUDhEgWi3yhUV2LluHI4CXiGTXt9Uc2JdOvgJR88w os4iPZ0l0oIE7ReOkzUvU52YD7wb32z8gmEPoWpI6Phdw3s3HPoPMFPxQ 8x8WqMAcoZ2VcnpSswb0mQGpgqF7fG/A3eYJYv3A3ZMOAvTIPTWDxO+Ue M=; X-IronPort-AV: E=Sophos;i="6.01,203,1684792800"; d="scan'208";a="117498041" Received: from unknown (HELO ribbon) ([193.50.110.205]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 17:27:21 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87352fz2m9.fsf_-_@gnu.org> Date: Thu, 13 Jul 2023 17:27:21 +0200 In-Reply-To: (Efraim Flashner's message of "Mon, 26 Jun 2023 11:34:27 +0300") Message-ID: <871qhbzvae.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -3.72 X-Migadu-Queue-Id: 130224B877 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -3.72 X-TUID: w44RFKw9pFqc Hi Efraim, Thanks for pushing this patch series past the finish line! Efraim Flashner skribis: > I'll look to see how to move this into > build-system-with-tuning-compiler. I think I previously got hung-up on > the tuning-compiler function which wouldn't work for go. At first glance > it looks like I could just lift-and-shift the extra phase over. I'll > just have to make sure that either it's only for the go-build-system or > occurs sometime after the setup-go-environment phase but before/after a > phase which exists in all build systems. Then it's the toss-up between > leaving it as-is and only occurring with the go-build-system or also > occurring on any tuned package which also has go code. It looks like we=E2=80=99re now adding the =E2=80=98set-microarchitecture= =E2=80=99 phase unconditionally, not just for go. For example: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build --tune eigen-benchmarks --log-file guix build: tuning eigen-benchmarks@3.4.0 for CPU skylake https://ci.guix.gnu.org/log/djwka1jhzhk08yb23as83yk5hysn0pky-eigen-benchmar= ks-3.4.0 $ wget -qO- https://ci.guix.gnu.org/log/djwka1jhzhk08yb23as83yk5hysn0pky-ei= gen-benchmarks-3.4.0 |gunzip -c| grep -C3 set-micro phase `reset-gzip-timestamps' succeeded after 0.0 seconds starting phase `compress-documentation' phase `compress-documentation' succeeded after 0.0 seconds starting phase `set-microarchitecture' Setting GOAMD to "v3". phase `set-microarchitecture' succeeded after 0.0 seconds @ build-succeeded /gnu/store/pdz0g9q2yd9i1jkbhk2rnbfa88ngvffw-eigen-benchma= rks-3.4.0.drv - --8<---------------cut here---------------end--------------->8--- What I had in mind was to have a procedure similar to =E2=80=98tuning-compi= ler=E2=80=99 that would return a wrapper around the =E2=80=9Cgo=E2=80=9D binary that wou= ld set =E2=80=98GOAMD=E2=80=99 (or similar). That way the change would be well is= olated. Could you look into providing a patch for that? Thanks in advance! Ludo=E2=80=99.