From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kFN5Fv0t+WRbbAEAG6o9tA:P1 (envelope-from ) for ; Thu, 07 Sep 2023 03:57:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kFN5Fv0t+WRbbAEAG6o9tA (envelope-from ) for ; Thu, 07 Sep 2023 03:57:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0253367381 for ; Thu, 7 Sep 2023 03:57:16 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Hmd9qHAM; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694051837; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oAM3XXhb1iBHVr5lLps/2djKRa0rxQuXZFytUcIS+p4=; b=uFySo2zCZrwL3vtnkh1WOkw+G7IGFvxterFPJN7D8dsLram+2RvcWpUVn8q05ewFr5C2uf 0KZZBJgfNuNjZxBlQYfqeKmhkUV1xWH8DmEWlYslS+w9qlstFoHnHUEvVwAofVUUTELXqe GZ/0rhanOuJZwIeSPuh+I4R581MnJYpiVdz+zucTUhAL3GB3ulxYIJrMKsxPQBbH8lK5oj f9yDtJf2MbL25MSBaoqPgbo8qFAwVgGwG7HQyeoe6xbhGTUGjm0N0c/0hrtMKXRZW2FuGK bLZoxbGZ8pGbwEiW9uO3VekHk1wL85kLzl/ZVC53ktfDVZncdf4piQ4x/M2xhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=Hmd9qHAM; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694051837; a=rsa-sha256; cv=none; b=VxKEY2k9D2wRU+1T7QIMYyXqxKyDsOBvoeLU5y9aaujW49B9jsD/wQb1LPMR3RSCGsuA2b DTJEl9U1mMmub7HWNe9soVrm4Xp9RHEwsdjsCtvDHbX2p3fXfAiLUK8j90TVsHfs5WHhrc MitogIvfeV6mggYcWrg3/74qNbegKgJVN+CQOVYcBtiWrasMH1gGTOaI1kNL/6+TuuQq18 lYrSDhIJArx2DOEmxeX9LgIPcH/okHkXmb1oQSIsoQ6sxl9lWHs262yd2X9aHT7fIkb/0X 0D8fPWBJjkKhEmW6GykU2oiq5ao+15bPEGQCUv1PYWin0yb2Z3FsDbiYBR58bA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qe4GV-00056w-Lr; Wed, 06 Sep 2023 21:57:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qe4GU-00056l-07 for guix-patches@gnu.org; Wed, 06 Sep 2023 21:57:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qe4GT-0003yO-NP for guix-patches@gnu.org; Wed, 06 Sep 2023 21:57:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qe4GU-0006X9-EY for guix-patches@gnu.org; Wed, 06 Sep 2023 21:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65757] [PATCH] guix: packages: Support package/inherit by package-field-location. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Sep 2023 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65757 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 65757-done@debbugs.gnu.org Received: via spool by 65757-done@debbugs.gnu.org id=D65757.169405177325062 (code D ref 65757); Thu, 07 Sep 2023 01:57:02 +0000 Received: (at 65757-done) by debbugs.gnu.org; 7 Sep 2023 01:56:13 +0000 Received: from localhost ([127.0.0.1]:38196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe4Fh-0006W9-8B for submit@debbugs.gnu.org; Wed, 06 Sep 2023 21:56:13 -0400 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]:56518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qe4Fb-0006Vt-LE for 65757-done@debbugs.gnu.org; Wed, 06 Sep 2023 21:56:12 -0400 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-4121b5334f3so3550561cf.0 for <65757-done@debbugs.gnu.org>; Wed, 06 Sep 2023 18:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694051760; x=1694656560; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=oAM3XXhb1iBHVr5lLps/2djKRa0rxQuXZFytUcIS+p4=; b=Hmd9qHAME8W/rB3jho1ukK8XZs1mDk1pn7fN3ra82JJsvC8f/ZNbdGkk+b5jspb0IR jhEW9P/BWcIMwaIyfESaWqMZmQPMr7Qx5tqALMzaXBn8zbsVYb7xE1Fyh4RQeu+T//Gn mw95Lp8T3R/FUTLOESYqLs9Dm94ironK50LfkuGYM6rsCtRlPJgVN9pt5uPWUZ10QlLG LkZ61HZrE8LQLHCwN1RFPdu6f+KMc3ymQL8Lt75tRvIlEA1CVlvpFHyrItxDjRo1bh55 OKIMri+q973uo5q/QMsTvR8+UQOEpGqTeIXJS0yIQTRbvMIYq4GUrnQUh2s/H62/DvTP 8kcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694051760; x=1694656560; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oAM3XXhb1iBHVr5lLps/2djKRa0rxQuXZFytUcIS+p4=; b=V2FA3PNHgQF1c1csJXMBH403W0mPopdrcjv3Fi0hYPQmtIS4b8DWbNpDij0QngmNk1 xzEsxBjf4MKQmh4LR/vf5nnYhhMjvj+oBm6RClbdhx9XRHtvh2TZ/Vwy0s3KrD0G3A2+ 9a/H5FZ6kX16WMr1Z0aCM1NtlD6qX3mtd3cjXNBOf+cHHNfvnwoK88pXCiUfRToXCCSp TJ6IcquHCLj9TW+4ZtR8QT3dMxH227QykTBgohsoLV5Ckm2BFYbRZA8fQn7bJiLmm0px wdjVXeiTjeo0QiC2J6EyVe/xKQYruIcSIbawCRwnYpE571u9aY8wV3XbCLy26UUXa7y/ fH7w== X-Gm-Message-State: AOJu0YyB+J3LVYFlyNihA3c+GPcHjFIXMFt6oRVGsR8JlufsHhQmIAf9 WLAqb2EzWsvoUBkbjQSiLea1Tkg1oNucJw== X-Google-Smtp-Source: AGHT+IFkX14KETbGATBn1Thrsq1l7Ofz8Rjrly1LCIHZ2jL01h4e9LGDoe8QBZr7krnPLFPiRliVMQ== X-Received: by 2002:a05:622a:100c:b0:403:eecb:9cfd with SMTP id d12-20020a05622a100c00b00403eecb9cfdmr21797243qte.23.1694051760440; Wed, 06 Sep 2023 18:56:00 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id fk26-20020a05622a559a00b00411f7da6e1bsm5707210qtb.60.2023.09.06.18.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 18:56:00 -0700 (PDT) From: Maxim Cournoyer References: <6cefcfecf409ffdd5fe856c23fbbc7b9cae7161d.1693924596.git.zimon.toutoune@gmail.com> <875y4nqbk4.fsf@gmail.com> <87fs3rm05c.fsf@gmail.com> Date: Wed, 06 Sep 2023 21:55:59 -0400 In-Reply-To: <87fs3rm05c.fsf@gmail.com> (Simon Tournier's message of "Thu, 07 Sep 2023 00:01:35 +0200") Message-ID: <871qfapx00.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 0253367381 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 4.27 X-Spam-Score: 4.27 X-TUID: /OE2wMnj5Px9 Hi, Simon Tournier writes: > Hi Maxim, > > On Wed, 06 Sep 2023 at 16:41, Maxim Cournoyer = wrote: > >> --8<---------------cut here---------------start------------->8--- >> modified guix/packages.scm >> @@ -762,7 +762,7 @@ (define (package-field-location package field) >> (go-to-location port line column) >> (match (read port) >> ((or ('package inits ...) >> - ('package/inherit parent inits ...)) >> + ('package/inherit _ inits ...)) >> (let ((field (assoc field inits))) >> (match field >> ((_ value) >> --8<---------------cut here---------------end--------------->8--- >> >> And it now works; yay! Will install shortly. > > Oops! Indeed, sorry for missing the obvious. Thanks for the fix. > > Cheers, > simon > > PS: For the record, the change you made is: > > - ('package/inherit inits ...)) > + ('package/inherit _ inits ...)) > > because the one above would be equivalent :-) =E2=80=93 if I understand e= nough > Guile patterning matching. The one with 'parent' was working as well, but because the binding was never used, Guile was emitting a warning, silence by renaming 'parent' to '_' :-). --=20 Thanks, Maxim