all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#65809: [mumi] [wishlist] Allow searching subject prefix
@ 2023-09-07 16:52 Giovanni Biscuolo
  2023-09-10  4:47 ` Arun Isaac
  0 siblings, 1 reply; 6+ messages in thread
From: Giovanni Biscuolo @ 2023-09-07 16:52 UTC (permalink / raw)
  To: 65809; +Cc: Arun Isaac

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Hello,

IMO is useful to be able to search for "subject:foo", it's a different
search than searching for foo in the body

in file mumi/xapian.scm I read:

--8<---------------cut here---------------start------------->8---

             ;; Index subject and body without prefixes for general
             ;; search.
             (index-text! term-generator subjects)
             (increase-termpos! term-generator)
             (index-text! term-generator text)

--8<---------------cut here---------------end--------------->8---

Is it possible to add such a feature please?

Thanks! Gio'


P.S.: I did not Cc: Ricardo Wurmus since AFAIU he prefers not to
continue developing this

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#65809: [mumi] [wishlist] Allow searching subject prefix
  2023-09-07 16:52 bug#65809: [mumi] [wishlist] Allow searching subject prefix Giovanni Biscuolo
@ 2023-09-10  4:47 ` Arun Isaac
  2023-09-10 14:16   ` bug#65809: mumi: Add msg number and subject in search results when searching for subject: Giovanni Biscuolo
  0 siblings, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2023-09-10  4:47 UTC (permalink / raw)
  To: g, 65809


Hi Gio,

Thanks for this feature request! It's always gratifying to know that
someone is using mumi, especially its more advanced features! :-)

> IMO is useful to be able to search for "subject:foo", it's a different
> search than searching for foo in the body

It looks like we implement this already. See
https://git.savannah.gnu.org/cgit/guix/mumi.git/tree/mumi/xapian.scm#n141
A search for "subject:foo" should work already.

Cheers!
Arun




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#65809: mumi: Add msg number and subject in search results when searching for subject:
  2023-09-10  4:47 ` Arun Isaac
@ 2023-09-10 14:16   ` Giovanni Biscuolo
  2023-09-17 10:48     ` Arun Isaac
  0 siblings, 1 reply; 6+ messages in thread
From: Giovanni Biscuolo @ 2023-09-10 14:16 UTC (permalink / raw)
  To: 65809; +Cc: Arun Isaac

[-- Attachment #1: Type: text/plain, Size: 3834 bytes --]

Hi!

(I'll also try to retitle this bug, after submitting this update)

Arun Isaac <arunisaac@systemreboot.net> writes:

> Thanks for this feature request! It's always gratifying to know that
> someone is using mumi, especially its more advanced features! :-)

mumi advanced features could be **very** useful to a lot of contributing
activities, if improved a little bit and better understood

>> IMO is useful to be able to search for "subject:foo", it's a different
>> search than searching for foo in the body
>
> It looks like we implement this already. See
> https://git.savannah.gnu.org/cgit/guix/mumi.git/tree/mumi/xapian.scm#n141
> A search for "subject:foo" should work already.

Uh I missed that code:

--8<---------------cut here---------------start------------->8---

             (index-text! term-generator subjects #:prefix "S")

--8<---------------cut here---------------end--------------->8---

otherwise I could have realize that I was misinterpreting mumi search
output.

If for example I search for 'subject:zoneinfo' I get this results:

--8<---------------cut here---------------start------------->8---

giovanni@roquette [genv]\: mumi search subject:zoneinfo
#31484 [PATCH] gnu: icu4c: Patch zoneinfo directory.
opened on 17 mag 2018 14:58 by Christopher Baines
#57448 ✓ [PATCH 0/5] gnu: exa: Update to 0.10.1.
opened on 27 ago 2022 12:09 by ギャラ
#58614 ✓ [PATCH 000/187] Remove unused crates
opened on 18 ott 2022 22:18 by Efraim Flashner

--8<---------------cut here---------------end--------------->8---
(the mumi CLI output is colored and the separation of each bug is
clearer)

Via web: https://issues.guix.gnu.org/search?query=subject%3Azoneinfo

Since 2 of the 3 patch "titles" are missing 'zoneinfo', I thought the
search was done in the subject and in the body, not just the subject.

For example, bug #58614 actually contains a message with this subject:
[PATCH 185/187] gnu: Remove rust-zoneinfo-compiled-0.4.

...my misunderstanding was due to the fact that each tracked bug (issue)
have a /Title/ given by the subject mail header from the original report
or by a retitle [1]; thus Title _is_ different from the "Subject"s of
the rest of the messages in the /thread/ of the tracked bug; when we
consider bugs tracking patches, actually each and every single patch
submission (not the reviews sent by people using a reply-to) do have a
different subject.

When searching for "subject:" it would be useful to have a speficic
message number and subject along with (or in place of) the bug title.

Using the search example above, a more useful result would be:

--8<---------------cut here---------------start------------->8---

giovanni@roquette [genv]\: mumi search subject:zoneinfo
#31484 [PATCH] gnu: icu4c: Patch zoneinfo directory.
opened on 17 mag 2018 14:58 by Christopher Baines

#57448 ✓ [PATCH 0/5] gnu: exa: Update to 0.10.1.
opened on 27 ago 2022 12:09 by ギャラ
[PATCH 4/5] gnu: rust-zoneinfo-compiled: Update to 0.5.1.
sent on 27 Aug 2022 12:10 by gyara

#58614 ✓ [PATCH 000/187] Remove unused crates
opened on 18 ott 2022 22:18 by Efraim Flashner
[PATCH 185/187] gnu: Remove rust-zoneinfo-compiled-0.4.
sent on 18 Oct 2022 22:20 by Efraim Flashner

--8<---------------cut here---------------end--------------->8---

I'd also add a blank line to have clear results also with "BW" consoles.

A similar addition would also be useful in the web interface, also
having a link to the message corresponding to the searched subject,
like:

[PATCH 185/187] gnu: Remove rust-zoneinfo-compiled-0.4. -> https://issues.guix.gnu.org/58614#184

Is it doable?

WDYT?

Thanks! Gio'


[1] https://debbugs.gnu.org/server-control.html

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#65809: mumi: Add msg number and subject in search results when searching for subject:
  2023-09-10 14:16   ` bug#65809: mumi: Add msg number and subject in search results when searching for subject: Giovanni Biscuolo
@ 2023-09-17 10:48     ` Arun Isaac
  2023-09-18 15:36       ` Giovanni Biscuolo
  0 siblings, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2023-09-17 10:48 UTC (permalink / raw)
  To: Giovanni Biscuolo, 65809


Hi Gio,

Sorry for my late reply. I have been travelling the last week and am
just catching up on all my email.

> When searching for "subject:" it would be useful to have a speficic
> message number and subject along with (or in place of) the bug title.

This is actually difficult to do because of the way we index issues as
Xapian "documents".

First, a quick Xapian primer. Xapian has a bunch of documents each
associated with a set of terms. When a search query comes in, Xapian
decomposes the query into a list of terms and retrieves documents that
match those terms.

In our case, we index entire issues as Xapian documents; we don't index
each individual email message as its own Xapian document. This means
that an issue is the smallest unit we can address. We cannot address
each individual email message. So, localizing a subject to a specific
email message is difficult.

Maybe what you are looking for is some context in the search results to
know why that particular search result was produced. This can be done by
displaying a snippet of text from the issue with the search terms
highlighted. For a working demo of what I mean, see for example,
https://issues.genenetwork.org/search?query=database&type=all . Notice
how the search term "database" is highlighted in the search
results. This is relatively easy to do with Xapian, and indeed I do plan
to implement this at some point.

WDYT? Would this meet your needs?

Regards,
Arun




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#65809: mumi: Add msg number and subject in search results when searching for subject:
  2023-09-17 10:48     ` Arun Isaac
@ 2023-09-18 15:36       ` Giovanni Biscuolo
  2023-09-18 19:56         ` Arun Isaac
  0 siblings, 1 reply; 6+ messages in thread
From: Giovanni Biscuolo @ 2023-09-18 15:36 UTC (permalink / raw)
  To: Arun Isaac, 65809

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> writes:

> Sorry for my late reply.

No problem: async! :-D 

[...]

> In our case, we index entire issues as Xapian documents; we don't index
> each individual email message as its own Xapian document.

Ooh, I understand now!

> This means that an issue is the smallest unit we can address. We
> cannot address each individual email message. So, localizing a subject
> to a specific email message is difficult.

Yes, I see.

> Maybe what you are looking for is some context in the search results to
> know why that particular search result was produced. This can be done by
> displaying a snippet of text from the issue with the search terms
> highlighted. For a working demo of what I mean, see for example,
> https://issues.genenetwork.org/search?query=database&type=all .

Oooh: a live example is more than a thousand words: thanks!
(I'm following Tissue but someway I missed that feature)

> Notice how the search term "database" is highlighted in the search
> results. This is relatively easy to do with Xapian, and indeed I do
> plan to implement this at some point.

OK: can we consider this bug report (wishlist) as the "official" one for
that feature? :-)

Can I retitle it to better reflect the upcoming implementation and
assign it to you?

Actually I dont' know if there is some written or unwritten convention
in Guix or GNU about bug assignment, I don't want to put pressure on
you!

> WDYT? Would this meet your needs?

Yes, absolutely yes: thank you!

Happy hacking! Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#65809: mumi: Add msg number and subject in search results when searching for subject:
  2023-09-18 15:36       ` Giovanni Biscuolo
@ 2023-09-18 19:56         ` Arun Isaac
  0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2023-09-18 19:56 UTC (permalink / raw)
  To: Giovanni Biscuolo, 65809


>> Notice how the search term "database" is highlighted in the search
>> results. This is relatively easy to do with Xapian, and indeed I do
>> plan to implement this at some point.
>
> OK: can we consider this bug report (wishlist) as the "official" one for
> that feature? :-)

Sure!

> Can I retitle it to better reflect the upcoming implementation and
> assign it to you?

Yes, please!

> Actually I dont' know if there is some written or unwritten convention
> in Guix or GNU about bug assignment, I don't want to put pressure on
> you!

No problem! I do intend to implement this feature at some point
anyway. Even if I don't do it, it's good to list this as an issue so
that someone interested can try and hack on it.




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-18 19:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-07 16:52 bug#65809: [mumi] [wishlist] Allow searching subject prefix Giovanni Biscuolo
2023-09-10  4:47 ` Arun Isaac
2023-09-10 14:16   ` bug#65809: mumi: Add msg number and subject in search results when searching for subject: Giovanni Biscuolo
2023-09-17 10:48     ` Arun Isaac
2023-09-18 15:36       ` Giovanni Biscuolo
2023-09-18 19:56         ` Arun Isaac

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.