[bug#66576] Request for merging "rust-team" branch

[bug#66576] Request for merging "rust-team" branch

[Efraim Flashner]

IMO rust-team branch is ready to merge. We've updated rust to 1.70,
librsvg to 2.56.4 and many new and updated packages. We've added a phase
to the cargo-build-system to fail if it detects pre-built files and
we've set the cargo-build-system to skip the test phase by default,
allowing us to make sure that the packages have the correct inputs. With
these changes I've gotten 100% of the packages built using the
cargo-build-system to build successfully.

We're looking forward to this merge so we can continue bumping the rust
version, work on cross-compilation and try to reduce the number of
packages which skip the build phase entirely.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[bug#66576] Request for merging "rust-team" branch

[Maxim Cournoyer]

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> writes:

> IMO rust-team branch is ready to merge. We've updated rust to 1.70,
> librsvg to 2.56.4 and many new and updated packages. We've added a phase
> to the cargo-build-system to fail if it detects pre-built files and
> we've set the cargo-build-system to skip the test phase by default,
> allowing us to make sure that the packages have the correct inputs. With
> these changes I've gotten 100% of the packages built using the
> cargo-build-system to build successfully.

This sounds good except I don't understand how disabling the tests by
default help to "make sure that the packages have the correct inputs" ?

You've explained the rationale here:
<https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00182.html>,
saying we sometimes use a newer Rust than the package tests are
expecting; how does it work in the Rust world?  Don't they always build
even older versions against the most recent compiler?  What about the
test suites then?  Are these not typically run by users/distributions?

For one thing the 'guix lint' command would need to be told that
cargo-build-system has #:tests? set to #f by default to not warn without
reasons that '#:tests? #t' is unnecessary.

-- 
Thanks,
Maxim

bug#66553: bug#66576: Request for merging "rust-team" branch

[Ludovic Courtès]

Hello!

Efraim Flashner <efraim@flashner.co.il> skribis:

> IMO rust-team branch is ready to merge. We've updated rust to 1.70,
> librsvg to 2.56.4 and many new and updated packages. We've added a phase
> to the cargo-build-system to fail if it detects pre-built files and
> we've set the cargo-build-system to skip the test phase by default,
> allowing us to make sure that the packages have the correct inputs. With
> these changes I've gotten 100% of the packages built using the
> cargo-build-system to build successfully.

The ‘rust-team’ jobset at https://ci.guix.gnu.org is now at 78%, which
is actually better than ‘master’ (74%).  There are still ~6K
aarch64-linux builds queued but from the numbers it seems ready to be
merged.

(Besides, I’m curious about the answers to the questions Maxim asked
earlier in this thread regarding skipping tests.)

Ludo’.

bug#66553: bug#66576: Request for merging "rust-team" branch

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On Wed, Oct 18, 2023 at 12:56:57AM +0200, Ludovic Courtès wrote:
> Hello!
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > IMO rust-team branch is ready to merge. We've updated rust to 1.70,
> > librsvg to 2.56.4 and many new and updated packages. We've added a phase
> > to the cargo-build-system to fail if it detects pre-built files and
> > we've set the cargo-build-system to skip the test phase by default,
> > allowing us to make sure that the packages have the correct inputs. With
> > these changes I've gotten 100% of the packages built using the
> > cargo-build-system to build successfully.
> 
> The ‘rust-team’ jobset at https://ci.guix.gnu.org is now at 78%, which
> is actually better than ‘master’ (74%).  There are still ~6K
> aarch64-linux builds queued but from the numbers it seems ready to be
> merged.

I'm going to rebase it on master to get the changes over the past month
or so, including the qt-team branch, and let that build out a bit before
merging it.

> (Besides, I’m curious about the answers to the questions Maxim asked
> earlier in this thread regarding skipping tests.)

I'm going to refer everyone back to the RFC thread on guix-devel to try
to keep everything in one place. I've reverted it for now while we
discuss it further.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#66553: bug#66576: Request for merging "rust-team" branch

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

On Tue, Oct 17, 2023 at 11:41:11AM -0400, Maxim Cournoyer wrote:
> Hi Efraim,
> 
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > IMO rust-team branch is ready to merge. We've updated rust to 1.70,
> > librsvg to 2.56.4 and many new and updated packages. We've added a phase
> > to the cargo-build-system to fail if it detects pre-built files and
> > we've set the cargo-build-system to skip the test phase by default,
> > allowing us to make sure that the packages have the correct inputs. With
> > these changes I've gotten 100% of the packages built using the
> > cargo-build-system to build successfully.
> 
> This sounds good except I don't understand how disabling the tests by
> default help to "make sure that the packages have the correct inputs" ?
> 
> You've explained the rationale here:
> <https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00182.html>,
> saying we sometimes use a newer Rust than the package tests are
> expecting; how does it work in the Rust world?  Don't they always build
> even older versions against the most recent compiler?  What about the
> test suites then?  Are these not typically run by users/distributions?

I've copied your questions to the thread above and answered them there
so we can keep the discussion in one place.

> For one thing the 'guix lint' command would need to be told that
> cargo-build-system has #:tests? set to #f by default to not warn without
> reasons that '#:tests? #t' is unnecessary.

I've reverted it for now so we can get the rust-team branch merged and
continue discussing if this is a good idea or not.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#66576] Request for merging "rust-team" branch

[Maxim Cournoyer]

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> writes:

> On Tue, Oct 17, 2023 at 11:41:11AM -0400, Maxim Cournoyer wrote:
>> Hi Efraim,
>> 
>> Efraim Flashner <efraim@flashner.co.il> writes:
>> 
>> > IMO rust-team branch is ready to merge. We've updated rust to 1.70,
>> > librsvg to 2.56.4 and many new and updated packages. We've added a phase
>> > to the cargo-build-system to fail if it detects pre-built files and
>> > we've set the cargo-build-system to skip the test phase by default,
>> > allowing us to make sure that the packages have the correct inputs. With
>> > these changes I've gotten 100% of the packages built using the
>> > cargo-build-system to build successfully.
>> 
>> This sounds good except I don't understand how disabling the tests by
>> default help to "make sure that the packages have the correct inputs" ?
>> 
>> You've explained the rationale here:
>> <https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00182.html>,
>> saying we sometimes use a newer Rust than the package tests are
>> expecting; how does it work in the Rust world?  Don't they always build
>> even older versions against the most recent compiler?  What about the
>> test suites then?  Are these not typically run by users/distributions?
>
> I've copied your questions to the thread above and answered them there
> so we can keep the discussion in one place.

OK!

>> For one thing the 'guix lint' command would need to be told that
>> cargo-build-system has #:tests? set to #f by default to not warn without
>> reasons that '#:tests? #t' is unnecessary.
>
> I've reverted it for now so we can get the rust-team branch merged and
> continue discussing if this is a good idea or not.

OK, thanks for giving it some extra time.

-- 
Thanks,
Maxim

bug#66576: Acknowledgement (Request for merging "rust-team" branch)

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Branch merged! On to the next round of rust updates!

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]