From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +O6RE93NAGYtNwEAe85BDQ:P1 (envelope-from ) for ; Mon, 25 Mar 2024 02:05:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id +O6RE93NAGYtNwEAe85BDQ (envelope-from ) for ; Mon, 25 Mar 2024 02:05:33 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=h4nDE0cS; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711328733; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Cziwowk6q00/8OyxIpaSguZ/grEc4TBekHWDNg8UMMY=; b=HrLLlxP+UeVd8Yl7WjsKmgcOxiuY2Lv/kvY9LHJTzXqdKFJbm+ocqyR0RdeJjfrPloRhSY 0j7oPMnGm8oqKXiUo1TvWHFVfT3wnq25vlhcU+jL246EXM8iiXkXveq0vfApa4CH4euG+m fubu06I6G9XanQq3adivc79X9yiMd1Izly3JOpdjsqdiLAb4sxN+nW6nfPzIy1dWJKp3i8 JRncGF3VJgwn4IcZVa5AISDtw5WFWKLA9DZ5mioZBVk0r3nI0OqL317UyzxohNgbYFPwr7 vvf9mAbT3CZopr9/GFTvqx8zCoNPY8vgM3SiAAXwDS8ut+Y2/X5jWGFFVtasuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=h4nDE0cS; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711328733; a=rsa-sha256; cv=none; b=hjicnz/LffWH5Eh0OYQ06LMUm6xvV1WzGQrA0xE2137wFDuAcTgWKBBWZ71t0pi9A7Zd8D k5EUnkjxmgHhsVaRvfNgM/Y9YzOnhEdNcB3CLw1X6W0gw/QgkSrFEoOwrtXT2+qIj79idP 6gmvk78PaigAQjAQIsUqkAsZwWHzmcXxoHA1uKN6LCeOnJbVyuQRR/7vhXX7v2eEeihgfG rlyYju5Nb2uAS69FwYkjSSWf5yDGcP/3ULDVgoHioZjDfZ9lkgyD8DXl3Q4xiyyBASZLY+ V3zOs0wyyWCaN3tq+VIJ7sPjR7QwjeJQpBhp4c7Z+5zgd5wrfLFPkvAMF//YEg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E41283E288 for ; Mon, 25 Mar 2024 02:05:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1roYmA-0008Go-9e; Sun, 24 Mar 2024 21:05:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roYm8-0008GF-8O for guix-patches@gnu.org; Sun, 24 Mar 2024 21:05:20 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1roYm7-0007Pg-W2 for guix-patches@gnu.org; Sun, 24 Mar 2024 21:05:20 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1roYmo-0004co-1A for guix-patches@gnu.org; Sun, 24 Mar 2024 21:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69502] [PATCH] gnu: sdl2: Update to 2.30.0. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Mar 2024 01:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69502 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: 69502@debbugs.gnu.org Received: via spool by 69502-submit@debbugs.gnu.org id=B69502.171132873017712 (code B ref 69502); Mon, 25 Mar 2024 01:06:01 +0000 Received: (at 69502) by debbugs.gnu.org; 25 Mar 2024 01:05:30 +0000 Received: from localhost ([127.0.0.1]:47630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1roYmI-0004bZ-7i for submit@debbugs.gnu.org; Sun, 24 Mar 2024 21:05:30 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:34611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1roYmE-0004bF-NZ for 69502@debbugs.gnu.org; Sun, 24 Mar 2024 21:05:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1711328678; x=1711587878; bh=Cziwowk6q00/8OyxIpaSguZ/grEc4TBekHWDNg8UMMY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=h4nDE0cS21nL31Iy2r3F8nGGtNIW4e8bFnvRhhv8LMkW5V9YuLL3QE6wiftL/f/A+ LmsIiwD/+WaGUQajw7f/ipNakZEbkJgZwNFNoBEDmJZNbIbuKOU4ccoWC+qvVhAjcZ 4Ub+tHz8Ds0PHXC6bVCIFeqEk1AVAunjHnlW3GkiooWLH0MrPU5h3WXfcFI+xbVWKC RE1ue5OtCrDRWSJC34oTFUKVJNAywTmMdQKi/fpjOm2f0XithVQw8GGjiyzPqPWaBe US3j7e56oAm59hgh0Z2TJB25zI8wXy/qCxOlbFPi5Gvm75cYBFYenVHAulY7UKNuBw nGIP8ZSZzzlZQ== Date: Mon, 25 Mar 2024 01:04:21 +0000 Message-ID: <871q7zp1f3.fsf@protonmail.com> In-Reply-To: <2a111ce9-01f3-4abd-8274-541362109391@dan.games> References: <87wmqf7vzt.fsf@protonmail.com> <2a111ce9-01f3-4abd-8274-541362109391@dan.games> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.83 X-Migadu-Queue-Id: E41283E288 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -6.83 X-TUID: WTz1+cHvIf/z Hi Dan, On Wed, Mar 06, 2024 at 02:37 PM, dan wrote: > Hi John, > > On 3/6/2024 1:46 PM, John Kehayias wrote: >> I'm guessing the slight style change is from guix style, which can be >> fine (here seems okay to me and more typical), but > > ... >> these last changes all seem superfluous to me, not really improving the >> style. > > I ran guix style on sdl2 and that's the result. I'm not sure if I should > stick to the result of guix style or it's better to not introduce any > style change and only update needed things. I can send a v2 update if it > would be easier for you. Yeah, guix style is not perfect. I don't think it gets used as much as would be needed to iron out some rough spots either. In this case, as a simple upgrade to a package, I would normally just run 'guix lint' on it (if that). Unless there is some clearly unfavorable style, or a commit to update to e.g. gexps, I would just leave an existing package as is. So, I would say just a patch with the version upgrade here would be cleaner. I will finally get mesa-updates building, including this patch, in the next few days. Thanks! John