all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: dan <i@dan.games>
Cc: 69502@debbugs.gnu.org
Subject: [bug#69502] [PATCH] gnu: sdl2: Update to 2.30.0.
Date: Mon, 25 Mar 2024 01:04:21 +0000	[thread overview]
Message-ID: <871q7zp1f3.fsf@protonmail.com> (raw)
In-Reply-To: <2a111ce9-01f3-4abd-8274-541362109391@dan.games>

Hi Dan,

On Wed, Mar 06, 2024 at 02:37 PM, dan wrote:

> Hi John,
>
> On 3/6/2024 1:46 PM, John Kehayias wrote:
>> I'm guessing the slight style change is from guix style, which can be
>> fine (here seems okay to me and more typical), but
>   > ...
>> these last changes all seem superfluous to me, not really improving the
>> style.
>
> I ran guix style on sdl2 and that's the result. I'm not sure if I should
> stick to the result of guix style or it's better to not introduce any
> style change and only update needed things. I can send a v2 update if it
> would be easier for you.

Yeah, guix style is not perfect. I don't think it gets used as much as
would be needed to iron out some rough spots either.

In this case, as a simple upgrade to a package, I would normally just
run 'guix lint' on it (if that). Unless there is some clearly
unfavorable style, or a commit to update to e.g. gexps, I would just
leave an existing package as is.

So, I would say just a patch with the version upgrade here would be
cleaner. I will finally get mesa-updates building, including this
patch, in the next few days.

Thanks!

John





  reply	other threads:[~2024-03-25  1:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-02  9:06 [bug#69502] [PATCH] gnu: sdl2: Update to 2.30.0 dan
2024-03-06  5:46 ` John Kehayias via Guix-patches via
2024-03-06  6:37   ` dan
2024-03-25  1:04     ` John Kehayias via Guix-patches via [this message]
2024-03-25  3:33       ` dan
2024-03-26  1:28 ` [bug#69502] [PATCH mesa-updates v2] gnu: sdl2: Update to 2.30.1 dan
2024-03-27  5:17   ` John Kehayias via Guix-patches via
2024-04-18  4:44     ` bug#69502: " John Kehayias via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q7zp1f3.fsf@protonmail.com \
    --to=guix-patches@gnu.org \
    --cc=69502@debbugs.gnu.org \
    --cc=i@dan.games \
    --cc=john.kehayias@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.