all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Dariqq <dariqq@posteo.net>
Cc: 70460-done@debbugs.gnu.org, felix@alternativebit.fr
Subject: bug#70460: [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it.
Date: Thu, 16 May 2024 07:55:39 +0100	[thread overview]
Message-ID: <871q62p7o4.fsf@cbaines.net> (raw)
In-Reply-To: <cover.1714662236.git.dariqq@posteo.net> (dariqq@posteo.net's message of "Thu, 2 May 2024 15:37:53 +0000")

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]

Dariqq <dariqq@posteo.net> writes:

> Hi all,
>
> Here is v2 of the patches.
>
> I hope the added manual entry is ok as I don't have prior experience
> writing texinfo. I've added the note not to use tlp and p-p-d together
> there too.
>
> Also is there a better way to set the pythonpath to not include the
> packages in native-inputs? This decreases guix size of the package by
> 100 MB.

...

> Things that could still be improved:
> * The generated manpage looks horrible because python-argparse-manpage
> is outdated. I've tried updating it but ran into test errors.
> * Test timeout issues on qa? I am not sure what to do here as it is
> kind of hard for me to guess what an appropriate timeout window would
> be that would work.
>
>
> Dariqq (3):
>   gnu: power-profiles-daemon: Update to 0.21.
>   gnu: power-profiles-daemon: Build gtk-docs.
>   gnu: services: Add power-profiles-daemon-service-type.
>
>  doc/guix.texi                | 40 +++++++++++++++++++++++++
>  gnu/packages/freedesktop.scm | 56 +++++++++++++++++++++++------------
>  gnu/services/pm.scm          | 57 +++++++++++++++++++++++++++++++++++-
>  3 files changed, 134 insertions(+), 19 deletions(-)

Thanks both, these patches look good to me. I removed some tabs and
tweaked some indentation and pushed these to master as
d0ad4f557fc8b9d105877f2ef4de0ce12c5c9566.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      parent reply	other threads:[~2024-05-16  6:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 18:31 [bug#70460] [PATCH 0/4] Update power-profiles-daemon and add a service-type for it Dariqq
2024-05-02 15:37 ` [bug#70460] [PATCH v2 0/3] " Dariqq
2024-05-02 15:37   ` [bug#70460] [PATCH v2 1/3] gnu: power-profiles-daemon: Update to 0.21 Dariqq
2024-05-02 15:37   ` [bug#70460] [PATCH v2 2/3] gnu: power-profiles-daemon: Build gtk-docs Dariqq
2024-05-02 15:37   ` [bug#70460] [PATCH v2 3/3] gnu: services: Add power-profiles-daemon-service-type Dariqq
2024-05-25 13:29     ` Ludovic Courtès
2024-05-25 15:15       ` Dariqq
2024-05-09  8:00   ` [bug#70460] [PATCH v2 0/3] Update power-profiles-daemon and add a service-type for it Dariqq
2024-05-16  6:55   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q62p7o4.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=70460-done@debbugs.gnu.org \
    --cc=dariqq@posteo.net \
    --cc=felix@alternativebit.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.