From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id uDqsJLtNW2afTQEAA41jLg (envelope-from ) for ; Sat, 01 Jun 2024 18:35:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YFh2IbtNW2ZcWQAA62LTzQ (envelope-from ) for ; Sat, 01 Jun 2024 18:35:07 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=ozqqRXEI; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="h 7iF7Sn"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717259707; a=rsa-sha256; cv=none; b=pQb1YHJEUuDm7W5Tl0TkKUHyizOJ58tTQBRSCSOGl3USWudeKY7wIeqeXrFo8XVV8Tpskc yBPXSzG/wHnksFQylgqb24CSw2TooPepkyNKNEA/WT/Fj3fcBkG1mDctKctCXlY7RGUQ/G h5fgVSpME/pJ4owt/0S9DTqkNAUJ8CnJAIq4USVbl6T6z6spSQ2LjoyAZ0xaLb081l8B1D X8bxTmayK8oaV39H1k8/vtElgo4iYWa1jos9N+2k4pPzIeTBEQadmnySeKKSFpDfa16Zua jEWkdpjpZydNBs3l/0spzPw4wJ6esIuceI7410vpOWsvqIgp7+9e9H3hMJ6vJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=ozqqRXEI; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="h 7iF7Sn"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717259707; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=e6wSDtgzHJB4NXYdL+JKEErEkFL/OzkmB2VZCzbPyt0=; b=rBMCkbV6DHYs8i5oMDcl0O4nsWSfwL9TVqWYeZX96wpGYBztiXRqVaaf0btiFeCdKfGOH3 kqcGlYA8h3P9HRHYfNvsKtnrJf2RrwNVDu2pInQlnrfc4T7BMQUQZGUW1esh9E6Hi4m+Y5 au/yx+JJjt0p2+fmjgkzYxIKzx//bPZg+OJpp7acQiCgAt/k4NNcyg+VV1DbHV2fUJ5XKN O7Qly0RIg5H11UawqqqHQpA1ob2ZXdHElDmPl2zlezBg1x6KRHRms80p7wZ28gkkqr3mft rSb/6VaoxAcRAv6qXi1TBtgN7Iry3LTUxEyY6Ri6ywrvo4IKfdIrs+he9tOLwQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A95DB65D6F for ; Sat, 1 Jun 2024 18:35:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDRgz-0001cs-Nm; Sat, 01 Jun 2024 12:34:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDRgw-0001cT-KR for guix-patches@gnu.org; Sat, 01 Jun 2024 12:34:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDRgw-0000cO-Cs for guix-patches@gnu.org; Sat, 01 Jun 2024 12:34:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDRh7-0007tD-Oj for guix-patches@gnu.org; Sat, 01 Jun 2024 12:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71121] [PATCH 2/3] gnu: librewolf: Rebuild source tarball Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Jun 2024 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71121 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 71121@debbugs.gnu.org Received: via spool by 71121-submit@debbugs.gnu.org id=B71121.171725969830314 (code B ref 71121); Sat, 01 Jun 2024 16:35:01 +0000 Received: (at 71121) by debbugs.gnu.org; 1 Jun 2024 16:34:58 +0000 Received: from localhost ([127.0.0.1]:57296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDRh4-0007ss-6J for submit@debbugs.gnu.org; Sat, 01 Jun 2024 12:34:58 -0400 Received: from wfout3-smtp.messagingengine.com ([64.147.123.146]:54377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDRh1-0007se-45 for 71121@debbugs.gnu.org; Sat, 01 Jun 2024 12:34:56 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.west.internal (Postfix) with ESMTP id 2BBE31C0008D; Sat, 1 Jun 2024 12:34:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 01 Jun 2024 12:34:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717259676; x=1717346076; bh=e6wSDtgzHJB4NXYdL+JKEErEkFL/OzkmB2VZCzbPyt0=; b= ozqqRXEI+ONI6jFK89uOdvW5yvMVMG2cU3IT8VYO4733BTZ0mqe/HyXETF5rD8JV VnLEMhP0G6zIxtASYcVpoutuTkqMb8u0SkcO4PBCJcbBcExYT1bBAkiANmqWKvJK Jz08Ebnv8xVpS9MMlKv4kLzZR36bXWxwt2nDQumizR34fMaYPklBpKUG94PyFzsM wcVHU2qvRLv5G7sFkzIvrZJS1nSW7utuCI6UM3uzzNMN1boQG5hHjgg52P33LRxx AMc/FDRAwFRGfDhrJziUOah7GOIYANYXAd7zTbAo0MjQYp6hD/KhowSQnePlQ31Y vvMBp+w9bELoNe/y9Z3pIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717259676; x= 1717346076; bh=e6wSDtgzHJB4NXYdL+JKEErEkFL/OzkmB2VZCzbPyt0=; b=h 7iF7SnIOeyiwVsFprn5HrQDxxni94xd05UUbFshDCMtvXRAMQWPCEaO8dbKGoQew AkJ/KF3Wgu/6mBsjEAwHkvGAWpHehlKt7ZWkIG+GLnnwAeDliwsd2ciALMSELkMC KUJDqfBC4oLzkKYdKm/dWmC/WWGiiYSlmzkWQSdyEpvWtpNGkeL+1VmnVeHKQvcv /M9PXdzqfDwt0fjFZECX1BMcNzFga7Y3gH/iGm/AcpzvoUTTk+U/B5Lc0lIS/MN6 ghMbUNqahpgROcevJ6x7ObDqVmSbmrg2BgBybAqux3q/0XLt7GtBpmwyqmUy6Kky JSOEzHb4ON3CIiQAGAPpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekkedguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepkfgr nhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrh hnpefhleevtdeifeffgfegiedvueekudettdevjeffhfelieelfeehgefgudfgieeuhfen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnse hrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Jun 2024 12:34:35 -0400 (EDT) References: <20240522145956.31218-1-ian@retrospec.tv> <20240522145956.31218-2-ian@retrospec.tv> <87jzjcf5nk.fsf@gmail.com> <87a5k8uh9f.fsf@meson> <87plt3e9yf.fsf@gmail.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure Date: Sat, 01 Jun 2024 09:30:23 -0700 In-reply-to: <87plt3e9yf.fsf@gmail.com> Message-ID: <871q5gvcys.fsf@meson> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: A95DB65D6F X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -1.94 X-Spam-Score: -1.94 X-TUID: cTrr7QRWnGtd Maxim Cournoyer writes: > Hi Ian, > > Ian Eure writes: > >> Hi Maxim, >> >> Maxim Cournoyer writes: >> >>> Hi Ian, >>> >>> Ian Eure writes: >>> >>>> * gnu/packages/librewolf.scm (librewolf): This patch removes=20 >>>> an >>>> intermediate >>>> step in the build chain. The upstream source tarball is=20 >>>> created >>>> with an >>>> automated build process, where Firefox sources are fetched, >>>> patched, and >>>> repacked. Rather than download the output of that process,=20 >>>> as the >>>> package has >>>> been, it=E2=80=99s now replicated within the build process, similar=20 >>>> to how >>>> IceCat >>>> works. >>> >>> I think I'd rather keep using a human-prepared and vetted=20 >>> tarball, >>> to >>> avoid anything going stale in our local recipe of how it's=20 >>> meant to >>> be >>> prepared. >>> >> >> The upstream tarball is built by scripts run under a CI system=20 >> which >> triggers when changes are pushed[1], and aren=E2=80=99t human-prepared=20 >> or >> vetted in the same way that many release tarballs have=20 >> tradionally >> been. This patchset uses the same script as upstream, with >> modifications to make it reproduceable, as the upstream process=20 >> isn=E2=80=99t. > > Perhaps the modifications to make it reproducible could be=20 > shared to > upstream? We'd benefit all thee users of librewolf this way,=20 > not only > Guix ones. > Yes, I plan to work with upstream on this. The current=20 modifications are Guix-specific, but I believe a mechanism which=20 allows for both better upstream reproducability and less hacky=20 Guix packaging is possible. >> As noted in the commit messages, IceCat also builds this=20 >> way[2], >> including patching the upstream build script[3][4], so this=20 >> seems like >> a reasonable & accepted way to build. Though perhaps there=E2=80=99s >> dissatisfaction with the IceCat build which I wasn=E2=80=99t aware of,=20 >> being a >> fairly new contributor. > > The "dissatisfaction", if we can call it that, was about=20 > Linux-libre, > and voiced by some a few years ago, including the project=20 > maintainers, > if I recall correctly. The idea of linux-libre is to shield=20 > users from > blobs. In this sense it is valuable that they don't even have=20 > to touch > the pristine blobbed (there are a few array-defined firmwares in=20 > the > tree still, at least one old Apple one IIRC) Linux source, which=20 > is > considered problematic for some from a GNU FSDG perspective. > Gotcha. I agree that these are unlikely to apply here. Thank you for pushing this, and I=E2=80=99ll try to get commit messages=20 closer to the convention in the future. =E2=80=94 Ian