From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MIv2B8nHZmZXAQAAe85BDQ:P1 (envelope-from ) for ; Mon, 10 Jun 2024 09:30:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id MIv2B8nHZmZXAQAAe85BDQ (envelope-from ) for ; Mon, 10 Jun 2024 11:30:49 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718011849; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=BpI9gHHBVYAnhH5ftCVsrifYWhMgCjEk/iSPEm8jH5c=; b=tz63d+NXrgoSnp9nHskkTJgczKBNo70HpacupKtq/OCjfNXwHnaJ3X9E6UMd9h7x6/Rptk GwQXdYiNP4CyzUCrMOKgx4fNLoLjaZETxmVZUjNkNmhE2YIy1p07p0uCagxmRV8YuSg6Qa UzldnkO47NllDUIwT5yf5poww9xVbw0xSm5tqahKtni8ZsqjB2dXSgdz7VxwR9LpuLjvfB DIRKn9VzkVsNW8pO75WGCmqiG5UWtrasip3WOWbvJ1nEKSFfYi9HsE0D7azt+BiSJswyzK MaxhVfFXydhpx6EHAPWPxXeLvij0RYi82gwkq0S+wBphH45HMJwdRJYVCxzAcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718011849; a=rsa-sha256; cv=none; b=AajdKQpLaWJOXi5EbhwtCVhDCwXe6RsCUH5eitDUP0sPHJmumg8/TyM79i8tH0nqTSSoEM MTSPlwq9R127Pe5VRyLk9OkVtAQExsi4K4LywX/l+l19tnUIi4u1a2n07JWHquiEz6oLkE bDpoPr09UOygWRITgVD9S9M9cwEK6PMV73wHGBEuWH0tch+PodJMKIlWgAYJQT3/9YIPo9 f+c0Cs/3/FpVs41KZb/zMSgOTkLwZLdFBNdJKoaVgUhOdohqFM9hqqIcJl/uL8wF0ZL4cO 68e/YE3X4/7VQvyn0bvglFGABEG6Y7KiJuhvXIv1Ae0BSkhPYd4ZMyllxlnKMg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 04D3C21964 for ; Mon, 10 Jun 2024 11:30:49 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGbM9-00079M-Mb; Mon, 10 Jun 2024 05:30:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGbLx-00075H-DL for guix-devel@gnu.org; Mon, 10 Jun 2024 05:30:15 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGbLv-0004l5-6t for guix-devel@gnu.org; Mon, 10 Jun 2024 05:30:13 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 7FDC527BBE2; Mon, 10 Jun 2024 10:30:08 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 69c7ebc3; Mon, 10 Jun 2024 09:30:07 +0000 (UTC) From: Christopher Baines To: Andy Tai Cc: guix-devel@gnu.org Subject: Re: package submission, unit test failures on Guix QA... policies? In-Reply-To: (Andy Tai's message of "Fri, 7 Jun 2024 10:37:55 -0700") References: User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 10 Jun 2024 10:30:05 +0100 Message-ID: <871q5516xu.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -7.44 X-Migadu-Queue-Id: 04D3C21964 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.44 X-TUID: 6A39LD5zIlBL --=-=-= Content-Type: text/plain Andy Tai writes: > Hi, I have a patch submission that builds fine (in the GNU Guix sense, > that is, unit tests run and pass) locally but fails on Guix QA due to > unit tests failing. > > I suspect that the failures are due to the build machine (or machines) > as plain x86-64 PC (fine as build server(s)) does not have exotic > hardware units like GPU that the package in question is meant to use. > > This may become more common as GPU and NPU applications become more popular. > > Curious how shall such cases be handled? Maybe reviewers can build > and run the patch to verify the patch works, so the Guix QA failure > can be overridden? I'm not sure we have great guidance here, but viewing this through the reproducible builds lens, we want packages to build identically across a diverse range of setups. While tests might not affect the outputs, I think the same premise still holds. The set of tests that are run should be the same regardless of the machine used. Have you got some specific examples where you're seeing failing unit tests, only on headless servers? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZmx51fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xen4Q/+OnDpQR/lQuGLXXnuOFapqVvvhk2vTYKm 1e+mBXiU8MlxSDmToqJYVy0eMx+h4wYCVOKXUkSci8hWywoeiM5fVCybu+qJiKo1 UVaOfi8RXiPxDF9RzLyGit/BE0q/ae28jI7kdh7yJWGmMTrtCrj5kak3hHE78rWc Y8UqOte1P+oOkME/PF2CAak+lNgtjK4MPNP1LTIYjiVixAI7P8DVmObIBjVgrXlT GBxSCmXqzazzaEf5pAgqXfPAaMzEFWX0Y3DVem4ftpMz7oP9a0E60B7+enW5yq2T K25mS2VV1yoS4SleHo2q/RqaaIlnVNGOzdnMnokRi0FpZwYHCVs7wfDpWhd+Htxb 1u1O7LVcXPQmQuet+i7QzsNMtxJe/QShjvR/9EmV+7KsNwOEK4PJkQvDjVIbDsgq HHxdnjqCgci8YK8W5fEDgXlLTauYsDAfhdnelQFDcGsd0OAUPVuv+vAB3Mx8+kK6 LsZQgok8o99Pb2lnTGCQqcEyavW6vwxFRP4Cj8B84RF005ZKx7F3SuWSN3Ph84qB GFynncTZ4UxfOFjvN7WJ5mB3jpVr4iyAgew8xIMFnEkTS76EZU4+HM0rPP1HQ4yj 617oYAC5lAo+ra9OTRSeBH9UwbxSgPY8XnVsCdfuemQxdi6RuNOfNzeL4gckVy73 cy3OAP4UL1o= =a9GS -----END PGP SIGNATURE----- --=-=-=--