From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2NKIIZwaM2dIIQAAqHPOHw:P1 (envelope-from ) for ; Tue, 12 Nov 2024 09:06:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 2NKIIZwaM2dIIQAAqHPOHw (envelope-from ) for ; Tue, 12 Nov 2024 10:06:36 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=l06Z8Zbq; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=CGDLPCsj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731402396; a=rsa-sha256; cv=none; b=nXKr+i8awzNGUlQ4/xR4FEgRlhz1sbX7H3sDry8YBHRJbrRje4BAHLMWpk54wkIyn3lQ3T 2xuKV9Xmj9HALC6o55gpMBwG9h/Nmr6wiHPb9t/5HAzGAmvTRr0n8Er4B10h47PmS+2mWc OaS6QqnaQQA4yjMG2uA0eQIi3/StI/LHa9svAcRbuF0nZgbqzTteTh6iBM9bzqoh8GMTbP wY7eUGqkF+TRuqCWAHWGYOLTD923Q+pNDQvGWNYz/3Si2Uh3dYBkAOUQph/+avG1XwElPj tY32D5TGp4hKw0A/v5i6txvdHweljtU+XTYwD5RFMSHhgbw6KCHkluIIFSSYgw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=l06Z8Zbq; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=CGDLPCsj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731402396; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lfgXbKzfS9jFduXR2FHVNUAyGTap0xipbFuVc0/mdlE=; b=Q3FVhAo66GgKiVAQeAmjZcXZtOZjJOy0M8kug6SwTupKghzvG/KioEpjM5v0uAnMI+gx9+ ObUKp8nHuGGONmAv1PKsrv0o0G7MBTT0N93+Hb9W2tohEhk/IMmfxNJAFRGx5Qq5bsuOV8 dS0Jz56hNYOacc7CBUeooOsGOOTzwShKB8oLXVVQKqtEj0EVCgM99r5VMRpcLKgfnzV5AR IBOzjn+QkvsIeOROGFj8iEjkGJN0fiW93LBMsKHfTy8uOtjmFsKWnwVHTZImAMQuTD1Mdk MVZYXdwip8sBicNsW8/M918ARkg3B7fAmH6C5S1uNivWmMbt+H2Zo7L1l6ue1A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 75526180B0 for ; Tue, 12 Nov 2024 10:06:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAmqa-00067O-KM; Tue, 12 Nov 2024 04:06:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAmqZ-000674-Ah for guix-patches@gnu.org; Tue, 12 Nov 2024 04:06:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAmqY-0006g0-QA for guix-patches@gnu.org; Tue, 12 Nov 2024 04:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=lfgXbKzfS9jFduXR2FHVNUAyGTap0xipbFuVc0/mdlE=; b=l06Z8Zbq2UideFFIEjk1+9ohmmsXvPwaZK1nP8D3Kh84I3qP6f8+KKQlfN734yjuoaXtAspdVxLr/wa9iZIZpxY1B3JtoBuNmoPOHPDFsSqgNccJK0BwroE0TnJQMzQLB3tdB7pcTEKUhZk4monrBUUjzw24W5hh/Y1k14gh+eyXulWYcFIOfZaj79+kloxIGp3kewr2jTwRoEy32jQ0JEE6MO1We5zjrMhxCVceXD3DunI/kCSk2fWxZkEtb4lWgeMqvnyn0g+tdg5ffo48P8BaRJn32KSqArBvQteBHeBxct1eIul9hz+b4tkJ9Xon7QWDnAMtJ+dZ/hV7mdT/vg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAmqY-00045a-CD for guix-patches@gnu.org; Tue, 12 Nov 2024 04:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74058] [PATCH v2 1/2] gnu: postgresql-configuration: Set default postgresql to *no*. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Nov 2024 09:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74058 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 74058@debbugs.gnu.org Received: via spool by 74058-submit@debbugs.gnu.org id=B74058.173140233615684 (code B ref 74058); Tue, 12 Nov 2024 09:06:02 +0000 Received: (at 74058) by debbugs.gnu.org; 12 Nov 2024 09:05:36 +0000 Received: from localhost ([127.0.0.1]:60601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAmq7-00044t-Se for submit@debbugs.gnu.org; Tue, 12 Nov 2024 04:05:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAmq5-00044c-Ai for 74058@debbugs.gnu.org; Tue, 12 Nov 2024 04:05:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAmnr-00064b-Tv; Tue, 12 Nov 2024 04:03:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lfgXbKzfS9jFduXR2FHVNUAyGTap0xipbFuVc0/mdlE=; b=CGDLPCsjGaF9dKBxyD24 7ZydWnGxpq83yq5mUS+Tqoca/6Ah8q6LQWfggUFXJnBupTzTdN4Wamnyzxi5pE6VJBDJCMwJ6RATj DLdYZTayWMvJsp9M6ihCdktCokv3BOALTuYOdcePgz82VZjQv0wo6gbWVkMSGn7lcNr8RHED4rnG2 bqoFp7TM3RvD67AO06lZOyVuIdkBIPHx/svWcYvpY1Y6DtzJPcMbP/tI+lG9uSD3Dr31BF/jYg/WO Fa5Dj6wyeWmMZ+Zx6LoDI+87vytVzNeqhtWyw/NoKmq7ofgsBeglMrvgrNk3zLqajyTRNs3guhiYr Zqys4Fp/EFFBKg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20241106170439.22888-1-ngraves@ngraves.fr> (Nicolas Graves's message of "Wed, 6 Nov 2024 18:04:28 +0100") References: <20241028105741.12834-1-ngraves@ngraves.fr> <20241106170439.22888-1-ngraves@ngraves.fr> Date: Tue, 12 Nov 2024 10:03:08 +0100 Message-ID: <871pzgvn77.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.54 X-Spam-Score: -3.54 X-Migadu-Queue-Id: 75526180B0 X-Migadu-Scanner: mx10.migadu.com X-TUID: 1abvAJpro8mu Hi, Nicolas Graves skribis: > * gnu/services/databases.scm (postgresql-configuration)[postgresql]: > Set default to *no*. > (postgresql-service): Revert default to postgresql-10 (rationale: We > can remove this service at the same time than postgresql-10, in > something like 6 months to a year). > --- > gnu/services/databases.scm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm > index 0933eb5e79..05e2c5f996 100644 > --- a/gnu/services/databases.scm > +++ b/gnu/services/databases.scm > @@ -167,8 +167,12 @@ (define contents > (define-record-type* > postgresql-configuration make-postgresql-configuration > postgresql-configuration? > + ;; Setting it to *no* ensures that the user sets its current postgresql > + ;; explicitely. Since major upgrades currently require a manual migra= tion > + ;; of the database, this way the user is responsible for upgrading pro= perly. > + ;; MAYBE TODO: Write an action to automatically upgrade in Guix. > (postgresql postgresql-configuration-postgresql ;file-like > - (default postgresql)) > + (default *no*)) I think we misunderstood each other; when I wrote: > How about having *no* default value in that case? I suggested removing the (default =E2=80=A6) bit altogether, as in: (define-record-type* postgresql-configuration make-postgresql-configuration postgresql-configuration? (postgresql postgresql-configuration-postgresql) ;no default value =E2=80=A6) That way, users get a syntax error (at macro-expansion time) if they omit the =E2=80=98postgresql=E2=80=99 field. Does that make sense? Ludo=E2=80=99.