From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wP3pL6q9SWdMHAEAqHPOHw:P1 (envelope-from ) for ; Fri, 29 Nov 2024 13:12:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wP3pL6q9SWdMHAEAqHPOHw (envelope-from ) for ; Fri, 29 Nov 2024 14:12:10 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=owNCAyJL; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Wf0A8JCn; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61FC17E9C6 for ; Fri, 29 Nov 2024 14:12:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tH0n1-0001KI-AX; Fri, 29 Nov 2024 08:12:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tH0mw-0001K2-A8 for guix-patches@gnu.org; Fri, 29 Nov 2024 08:12:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tH0mw-0002zS-1O for guix-patches@gnu.org; Fri, 29 Nov 2024 08:12:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=P/Xvxwsr/tFakCiJJslIkggn2pcgdLzuGUGdXRiLVJg=; b=owNCAyJLsS7u8uHhS5B7I/tPiwn6W7kZfFzCWmc6QjnwomnW9lZ5Qzz64oYp5ws/rGjcZX3nyMrOciaK74D0oH1OoW0jKD05Wfw64G8YJZIVxGWHAKNAmlUQiy1WDn05RxejGY/sjwOpnupyKXat0U6F3dbaw9/39cHv/h9RDqgZ2QcC42ojrcDCRycSsjfHbuS4vo6CvwJEXnyYoWw2IBLnFBKRpHZSJJonXAGtlkiZs3dyu3pscJ5LcrUMXiHvaldpko8J2UN9duya6Uv0+Zs3ei3CtRb8GY178iUJslH95y/sSV08SSa7dMovv3p5brCFrHUVQveaFUpq2k6a7g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tH0mv-0007gp-TQ for guix-patches@gnu.org; Fri, 29 Nov 2024 08:12:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74411] [PATCH v2 1/5] gnu: Add (gnu packages dictd). Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Nov 2024 13:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74411 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Runciter Cc: 74411@debbugs.gnu.org Received: via spool by 74411-submit@debbugs.gnu.org id=B74411.173288586229461 (code B ref 74411); Fri, 29 Nov 2024 13:12:01 +0000 Received: (at 74411) by debbugs.gnu.org; 29 Nov 2024 13:11:02 +0000 Received: from localhost ([127.0.0.1]:41457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH0ly-0007f7-7t for submit@debbugs.gnu.org; Fri, 29 Nov 2024 08:11:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tH0lv-0007ea-PM for 74411@debbugs.gnu.org; Fri, 29 Nov 2024 08:11:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tH0lq-0002dh-9D; Fri, 29 Nov 2024 08:10:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=P/Xvxwsr/tFakCiJJslIkggn2pcgdLzuGUGdXRiLVJg=; b=Wf0A8JCn4mxyvJ1in3xl eszhDJd+Tf0bGEyMBAeNhRZlsbj4M2tGdq0YRrqS5p12BhnDtMFbv9rBT11neHW5OEFTNs5amTlk+ 5N9ZBXjE1Esi4Rp0truxlWbqhM1gwnI0pRdwRSR2wb0f4hJkqrtPYuS3s2rG8J61ZgPOJSQCQe+8T +PoED1Q6CcdH9TfcSPxztM1nQ3+KJID/Ts3B4/21Dc5lamYFVPK+QeemadlRaa5vXc3H+0D9Z1s3B 3/QdUSt5twwT4ER2qo3EBJ1iYPob1Y0U/u4PC2I6EwnCDjNxqtAdoG4aJqdyAtSZXOoeDOusd45g1 RBSfAHNEJZT/Dw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (runciter@whispers-vpn.org's message of "Thu, 21 Nov 2024 00:49:51 +0000") References: Date: Fri, 29 Nov 2024 14:10:52 +0100 Message-ID: <871pyu2nj7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 61FC17E9C6 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.51 X-Spam-Score: -4.51 X-TUID: LYPnGF7Y/+h5 Hi, Thanks for these patches! Overall it LGTM, I only have minor comments and suggestions: Runciter skribis: > * gnu/packages/dictd.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. > > Signed-off-by: Runciter [...] > +(define-public libmaa-1.3.2 Unless there=E2=80=99s a good reason (such as future patches adding specific versions), I=E2=80=99d call it =E2=80=98libmaa=E2=80=99. > + (native-inputs (list libtool)) I suspect you don=E2=80=99t need Libtool here (it would be needed if you we= re building from a checkout instead of from a tarball). > + (arguments > + (list > + #:make-flags #~'("CFLAGS=3D-DHAVE_CONFIG_H -Wall -Wno-error -g -O= 2 $(VERCFLAGS) -I. -I${srcdir}") Could you add a comment (one or two lines) explaining why these flags are needed? > + The memory management routines are especially helpful for improving ^ Extra space. :-)