* [bug#74618] [PATCH] gnu: lcov: disable parallel tests
@ 2024-11-30 7:33 Ryan Sundberg via Guix-patches via
2024-12-01 10:45 ` Zheng Junjie
2024-12-02 5:29 ` Ryan Sundberg via Guix-patches via
0 siblings, 2 replies; 4+ messages in thread
From: Ryan Sundberg via Guix-patches via @ 2024-11-30 7:33 UTC (permalink / raw)
To: 74618; +Cc: Ryan Sundberg
`make check` is not reliable for lcov when run in parallel
(e.g. `make -j 24 check`). Disable parallelism for the test suite.
* gnu/packages/code (lcov): Set #:parallel-tests? #f
Signed-off-by: Ryan Sundberg <ryan@arctype.co>
Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
---
gnu/packages/code.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 04ca4dfd6b..6ac514a5b5 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -556,6 +556,7 @@ (define-public lcov
'(#:test-target "test"
#:make-flags (list (string-append "PREFIX="
(assoc-ref %outputs "out")))
+ #:parallel-tests? #f
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'patch-references-to-commands
base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#74618] [PATCH] gnu: lcov: disable parallel tests
2024-11-30 7:33 [bug#74618] [PATCH] gnu: lcov: disable parallel tests Ryan Sundberg via Guix-patches via
@ 2024-12-01 10:45 ` Zheng Junjie
2024-12-02 5:29 ` Ryan Sundberg via Guix-patches via
1 sibling, 0 replies; 4+ messages in thread
From: Zheng Junjie @ 2024-12-01 10:45 UTC (permalink / raw)
To: 74618; +Cc: ryan
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
Ryan Sundberg via Guix-patches via <guix-patches@gnu.org> writes:
> `make check` is not reliable for lcov when run in parallel
> (e.g. `make -j 24 check`). Disable parallelism for the test suite.
Please also write this in the comments of the code. Make it easy for
people to know later
>
> * gnu/packages/code (lcov): Set #:parallel-tests? #f
>
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>
> Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
> ---
> gnu/packages/code.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 04ca4dfd6b..6ac514a5b5 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -556,6 +556,7 @@ (define-public lcov
> '(#:test-target "test"
> #:make-flags (list (string-append "PREFIX="
> (assoc-ref %outputs "out")))
> + #:parallel-tests? #f
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'patch-references-to-commands
>
> base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#74618] [PATCH] gnu: lcov: disable parallel tests
2024-11-30 7:33 [bug#74618] [PATCH] gnu: lcov: disable parallel tests Ryan Sundberg via Guix-patches via
2024-12-01 10:45 ` Zheng Junjie
@ 2024-12-02 5:29 ` Ryan Sundberg via Guix-patches via
2024-12-07 1:41 ` Zheng Junjie
1 sibling, 1 reply; 4+ messages in thread
From: Ryan Sundberg via Guix-patches via @ 2024-12-02 5:29 UTC (permalink / raw)
To: 74618; +Cc: Ryan Sundberg
`make check` is not reliable for lcov when run in parallel
(e.g. `make -j 24 check`). Disable parallelism for the test suite.
* gnu/packages/code (lcov): Set #:parallel-tests? #f
Signed-off-by: Ryan Sundberg <ryan@arctype.co>
Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
---
gnu/packages/code.scm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 04ca4dfd6b..2ad1d8616a 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -556,6 +556,9 @@ (define-public lcov
'(#:test-target "test"
#:make-flags (list (string-append "PREFIX="
(assoc-ref %outputs "out")))
+ ;; This test suite has race conditions in its scripts which make it
+ ;; unreliable when run in parallel.
+ #:parallel-tests? #f
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'patch-references-to-commands
base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#74618] [PATCH] gnu: lcov: disable parallel tests
2024-12-02 5:29 ` Ryan Sundberg via Guix-patches via
@ 2024-12-07 1:41 ` Zheng Junjie
0 siblings, 0 replies; 4+ messages in thread
From: Zheng Junjie @ 2024-12-07 1:41 UTC (permalink / raw)
To: 74618; +Cc: Ryan Sundberg, 74618-done
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
please use [PATCH v2] next.
Ryan Sundberg via Guix-patches via <guix-patches@gnu.org> writes:
> `make check` is not reliable for lcov when run in parallel
> (e.g. `make -j 24 check`). Disable parallelism for the test suite.
>
> * gnu/packages/code (lcov): Set #:parallel-tests? #f
>
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>
> Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
> ---
> gnu/packages/code.scm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 04ca4dfd6b..2ad1d8616a 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -556,6 +556,9 @@ (define-public lcov
> '(#:test-target "test"
> #:make-flags (list (string-append "PREFIX="
> (assoc-ref %outputs "out")))
> + ;; This test suite has race conditions in its scripts which make it
> + ;; unreliable when run in parallel.
> + #:parallel-tests? #f
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'patch-references-to-commands
>
> base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
pushed, closing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-07 1:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-30 7:33 [bug#74618] [PATCH] gnu: lcov: disable parallel tests Ryan Sundberg via Guix-patches via
2024-12-01 10:45 ` Zheng Junjie
2024-12-02 5:29 ` Ryan Sundberg via Guix-patches via
2024-12-07 1:41 ` Zheng Junjie
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.