all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: James Smith via Guix-patches via <guix-patches@gnu.org>
To: Z572 <zhengjunjie@iscas.ac.cn>
Cc: 70261@debbugs.gnu.org
Subject: [bug#70261] [PATCH v2] gnu: Add wsbg.
Date: Tue, 23 Apr 2024 06:09:17 -0700	[thread overview]
Message-ID: <86zftk43c6.fsf@disroot.org> (raw)
In-Reply-To: <87v848k5k6.fsf@iscas.ac.cn> (zhengjunjie@iscas.ac.cn's message of "Tue, 23 Apr 2024 13:32:09 +0800")

NOTE: Forgot to CC to debbugs before sending V3 patch.

Z572 <zhengjunjie@iscas.ac.cn> writes:

> James Smith via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/wm.scm (wsbg): New variable.
>>
>> Change-Id: Ia83a7afcbb0879f0f6d604e1d671388a30800265
>> ---
>>  gnu/packages/wm.scm | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
>> index b5e9dca524..62835b4e63 100644
>> --- a/gnu/packages/wm.scm
>> +++ b/gnu/packages/wm.scm
>> @@ -70,6 +70,7 @@
>>  ;;; Copyright © 2024 Ahmad Draidi <a.r.draidi@redscript.org>
>>  ;;; Copyright © 2024 chris <chris@bumblehead.com>
>>  ;;; Copyright © 2024 Erik Eduardo Alonso Hernández <erik@erikeduardo.xyz>
>> +;;; Copyright © 2024 James Smith <jsubuntuxp@disroot.org>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -3767,6 +3768,28 @@ (define-public velox
>>  It is inspired by dwm and xmonad.")
>>        (license license:expat))))
>>  
>> +(define-public wsbg
>> +  (let ((commit "15b0d0f6910ea97b9bcc471695fac07270955dd2")
>> +        (revision "133")
>
> revision should "0". when we update this package on guix repo, we add it.
>
Ah, I thought revision corresponds with the number of commits for the
upstream git repo, not the number of package revisions in Guix.
>> +        (version "0.1"))
>
> please add some comment about upstream is no tags.
> and version should 0.1.0, see https://github.com/saibier/wsbg/blob/15b0d0f6910ea97b9bcc471695fac07270955dd2/meson.build#L4
>
>> +    (package
>> +      (inherit swaybg)
>> +      (name "wsbg")
>> +      (version (git-version version revision commit))
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://github.com/saibier/wsbg")
>> +               (commit commit)))
>> +         (file-name (git-file-name name version))
>> +         (sha256
>> +          (base32 "15xrnwp54kghigx06y4qmmn1q9f26fx4cawyl4kcbqrrzfbbj1g6"))))
>> +      (home-page "https://github.com/saibier/wsbg")
>> +      (synopsis "Workspace wallpaper tool for Sway")
>> +      (description "Wallpaper utility for Sway with support for per-workspace
>> +configuration."))))
>> +
>>  (define-public yambar-wayland
>>    (package
>>      (name "yambar-wayland")
>>
>> base-commit: 2126dab4cd81db4cbde4566d8c638e45a4c0077c




  reply	other threads:[~2024-04-23 13:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07 18:58 [bug#70261] [PATCH] gnu: Add wsbg James Smith via Guix-patches via
2024-04-18  3:53 ` [bug#70261] [PATCH v2] " James Smith via Guix-patches via
2024-04-23  5:32   ` Z572
2024-04-23 13:09     ` James Smith via Guix-patches via [this message]
2024-04-23 13:14 ` [bug#70261] [PATCH v3] " James Smith via Guix-patches via
2024-04-24  2:39   ` bug#70261: " Z572

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zftk43c6.fsf@disroot.org \
    --to=guix-patches@gnu.org \
    --cc=70261@debbugs.gnu.org \
    --cc=jsubuntuxp@disroot.org \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.