bug#55596: subversion segfaul on `guix import texlive`

bug#55596: subversion segfaul on `guix import texlive`

[Jack Hill]

Hi Guix,

With Guix commit 4ba4cb1d49d70a00f7236f60bd92e5eccef573dd on Linux x86-64, 
I have the following problem trying to import a texlive package:

"""
$ guix import texlive qrcode
command "svn" "export" "--non-interactive" "--trust-server-cert" "-r" "59745" "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/qrcode/" "/tmp/guix-directory.6aY7Gk/doc/latex/qrcode/" failed with signal 11
guix import: error: failed to import package 'qrcode'
"""

It seems something is unwell with our subversion package?

Best,
Jack

bug#55596: subversion segfaul on `guix import texlive`

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Jack Hill 写道：
> """
> $ guix import texlive qrcode
> command "svn" "export" "--non-interactive" "--trust-server-cert" 
> "-r"
> "59745"
> "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/qrcode/"
> "/tmp/guix-directory.6aY7Gk/doc/latex/qrcode/" failed with 
> signal 11
> guix import: error: failed to import package 'qrcode'
> """
>
> It seems something is unwell with our subversion package?

I don't know why I didn't think of this sooner, but I ran that svn 
command by hand (only replacing the output directory, say 
/tmp/foo) and… it ran fine.

So I checked my dmesg and it's actually Guix that's getting 
killed:

[146565.315921] guix[1767]: segfault at c0 ip 000076c46ae99e70 sp 
00007fffcbe9cb30 error 4 cpu 5 in 
libc-2.33.so[76c46ae57000+141000]
[146565.315937] Code: 56 41 55 41 54 55 48 89 fd 53 48 81 ec f8 04 
00 00 48 8b 05 ea 1f 15 00 48 89 34 24 89 4c 24 48 64 8b 00 89 84 
24 80 00 00 00 <8b> 87 c0 00 00 00 85 c0 0f 85 4a 02 00 00 c7 87 
c0 00 00 00 ff ff

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#55596: Guix/Guile segfaults on `guix import texlive`

[Ludovic Courtès]

Hello,

Hugo Nobrega <hugonobrega@ic.ufrj.br> skribis:

> hugo@hp-guix ~$ guix import texlive cite
> command "svn" "export" "--non-interactive" "--trust-server-cert" "-r"
> "59745"
> "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/cite/"
> "/tmp/guix-directory.09UnsN/doc/latex/cite/" failed with signal 11 guix
> import: error: failed to import package 'cite'

Jack Hill <jackhill@jackhill.us> skribis:

> With Guix commit 4ba4cb1d49d70a00f7236f60bd92e5eccef573dd on Linux
> x86-64, I have the following problem trying to import a texlive
> package:
>
> """
> $ guix import texlive qrcode
> command "svn" "export" "--non-interactive" "--trust-server-cert" "-r" "59745" "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/qrcode/" "/tmp/guix-directory.6aY7Gk/doc/latex/qrcode/" failed with signal 11
> guix import: error: failed to import package 'qrcode'
> """
>
> It seems something is unwell with our subversion package?

Works for me on x86_64-linux!

--8<---------------cut here---------------start------------->8---
$ guix describe
Generation 215	May 22 2022 23:16:03	(current)
  guix 81f7bb1
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 81f7bb1691dc9dc69fc6e584ad8c6e36e495c103
$ guix shell subversion -- guix import texlive qrcode
A    /tmp/guix-directory.rXo6NK/doc/latex/qrcode
A    /tmp/guix-directory.rXo6NK/doc/latex/qrcode/README
A    /tmp/guix-directory.rXo6NK/doc/latex/qrcode/qrcode.pdf
Exported revision 59745.
A    /tmp/guix-directory.rXo6NK/source/latex/qrcode
A    /tmp/guix-directory.rXo6NK/source/latex/qrcode/qrcode.dtx
A    /tmp/guix-directory.rXo6NK/source/latex/qrcode/qrcode.ins
Exported revision 59745.
A    /tmp/guix-directory.rXo6NK/tex/latex/qrcode
A    /tmp/guix-directory.rXo6NK/tex/latex/qrcode/qrcode.sty
Exported revision 59745.
(package
  (inherit
    (simple-texlive-package
      "texlive-qrcode"
      (list "doc/latex/qrcode/" "source/latex/qrcode/" "tex/latex/qrcode/")
      (base32 "197v18lsvb90i07gxvc6mrmn1z63q8v0wvcnbk8dnn3hhabpn16y")))
  (home-page "https://ctan.org/macros/latex/contrib/qrcode")
  (synopsis "Generate QR codes in LaTeX")
  (description
    "The package generates QR (Quick Response) codes in LaTeX, without the need for
PSTricks or any other graphical package.")
  (license lppl1.3+))
$ guix shell subversion -- guix import texlive cite
A    /tmp/guix-directory.GpxhKw/doc/latex/cite
A    /tmp/guix-directory.GpxhKw/doc/latex/cite/README
A    /tmp/guix-directory.GpxhKw/doc/latex/cite/chapterbib.ltx
A    /tmp/guix-directory.GpxhKw/doc/latex/cite/chapterbib.pdf
A    /tmp/guix-directory.GpxhKw/doc/latex/cite/cite.ltx
A    /tmp/guix-directory.GpxhKw/doc/latex/cite/cite.pdf
Exported revision 59745.
A    /tmp/guix-directory.GpxhKw/tex/latex/cite
A    /tmp/guix-directory.GpxhKw/tex/latex/cite/chapterbib.sty
A    /tmp/guix-directory.GpxhKw/tex/latex/cite/cite.sty
A    /tmp/guix-directory.GpxhKw/tex/latex/cite/drftcite.sty
A    /tmp/guix-directory.GpxhKw/tex/latex/cite/overcite.sty
Exported revision 59745.
(package
  (inherit
    (simple-texlive-package
      "texlive-cite"
      (list "doc/latex/cite/" "tex/latex/cite/")
      (base32 "0b1amznayxj80dmqbzcysmj7q8aksbyz98k6djsqi0mhwp1cd0fd")
      #:trivial?
      #t))
  (home-page "https://ctan.org/macros/latex/contrib/cite")
  (synopsis "Improved citation handling in LaTeX")
  (description
    "The package supports compressed, sorted lists of numerical citations, and also
deals with various punctuation and other issues of representation, including
comprehensive management of break points.  The package is compatible with both
hyperref and backref.  The package is (unsurprisingly) part of the cite bundle
of the author's citation-related packages.")
  (license (error unknown-license "other-free")))
--8<---------------cut here---------------end--------------->8---

Jack, Hugo: What does “type -P svn” say?

Does the bug occur within ‘guix shell subversion’ as shown above?

TIA,
Ludo’.

bug#55596: Guix/Guile segfaults on `guix import texlive`

[Hugo]

Ludovic Courtès <ludo@gnu.org> writes:

> Jack, Hugo: What does “type -P svn” say?
>
> Does the bug occur within ‘guix shell subversion’ as shown above?

Well, I feel kind of silly now, after actually installing subversion the
command works as expected :)

But I suppose the silent failure is still something that could/should be
improved.

Thanks,
Hugo

bug#55596: Guix/Guile segfaults on `guix import texlive`

[Ludovic Courtès]

Hello,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> I think you might be barking up the wrong tree (or, likely, that there
> are multiple trees here).  I could reproduce the segfault on Guix
> System and encouraged Jack to file this bug.
>
> It's not foreign-distro-related.  The process actually segfaulting is
> Guix, not svn, possibly due to a missing svn.

I don’t think so; the error message that was reported is:

  command "svn" "export" "--non-interactive" "--trust-server-cert" "-r" "59745" "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/cite/" "/tmp/guix-directory.09UnsN/doc/latex/cite/" failed with signal 11

It’s a message from ‘report-invoke-error’ in (guix build utils).  It’s
really svn that’s segfaulting.

Should we close and reopen if/when we have more info?

Thanks,
Ludo’.

bug#55596: Guix/Guile segfaults on `guix import texlive`

[Akira Kyle]

Hi,

> I don’t think so; the error message that was reported is:
> 
>   command "svn" "export" "--non-interactive" "--trust-server-cert" "-r" "59745" "svn://www.tug.org/texlive/tags/texlive-2021.3/Master/texmf-dist/doc/latex/cite/" "/tmp/guix-directory.09UnsN/doc/latex/cite/" failed with signal 11
> 
> It’s a message from ‘report-invoke-error’ in (guix build utils).  It’s
> really svn that’s segfaulting.

I recently encountered this issue and did some digging. I don't think svn is actually segfaulting, just that the command svn doesn't exist so when 'system*' is called inside 'invoke' in (guix build utils) it for some reason gives signal 11.

On a recent guix system, I can reproduce this error by running 'guix import texlive' when inside 'guix shell guix --pure'. However there is no error when inside 'guix shell guix subversion --pure'. I think this is ultimately due to 'download-multi-svn-to-store' (and 'download-svn-to-store' but the texlive importer only calls the former) not setting '#:svn-command' when it calls 'build:svn-fetch' so it uses the default argument of 'svn' rather than trying to explicitly use an svn from the store.

Unfortunately my guile and gexp knowledge is quite lacking so I'm not sure that I have the know-how to create a patch to fix this, however hopefully this is enough for someone else to easily fix this issue.

Thanks,
Akira