From mboxrd@z Thu Jan  1 00:00:00 1970
From: myglc2 <myglc2@gmail.com>
Subject: Re: [PATCH 0/6] Error reporting and hints for missing modules
Date: Wed, 08 Nov 2017 12:42:39 -0500
Message-ID: <86wp30psz4.fsf@gmail.com>
References: <87zi7xwvso.fsf_-_@gnu.org> <20171108130921.25202-1-ludo@gnu.org>
	<72bfb7a9ff14c437a704381f807ce2f7@lepiller.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <myglc2@gmail.com>) id 1eCUND-0003fl-MV
	for guix-devel@gnu.org; Wed, 08 Nov 2017 12:42:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <myglc2@gmail.com>) id 1eCUN8-0003nf-N4
	for guix-devel@gnu.org; Wed, 08 Nov 2017 12:42:47 -0500
Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:47343)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <myglc2@gmail.com>) id 1eCUN8-0003nZ-Hw
	for guix-devel@gnu.org; Wed, 08 Nov 2017 12:42:42 -0500
Received: by mail-qk0-x22c.google.com with SMTP id m189so4355209qke.4
	for <guix-devel@gnu.org>; Wed, 08 Nov 2017 09:42:42 -0800 (PST)
In-Reply-To: <72bfb7a9ff14c437a704381f807ce2f7@lepiller.eu> (julien lepiller's
	message of "Wed, 08 Nov 2017 16:33:16 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: julien lepiller <julien@lepiller.eu>
Cc: guix-devel@gnu.org

On 11/08/2017 at 16:33 julien lepiller writes:

> Le 2017-11-08 14:09, Ludovic Court=C3=A8s a =C3=A9crit=C2=A0:
>> Hi!
>>
>> Here=E2=80=99s an improved version that supports hints (with Texinfo mar=
kup and
>> i18n) and error reporting with source location info.
>>
>> Hints try to make suggestions.  If you write:
>>
>>   (use-package-modules qemu)
>>
>> You=E2=80=99ll get:
>>
>>   configuration.scm:7:0: error: module (gnu packages qemu) not found
>>   hint: Did you mean `(use-package-modules virtualization)'?
>>
>> If you write:
>>
>>   (use-service-modules openssh)
>>
>> You get:
>>
>>   configuration.scm:9:0: error: module (gnu services openssh) not found
>>   hint: Did you mean `(use-service-modules ssh)'?
>>
>> The =E2=80=9Cdid you mean=E2=80=9D hints are based on exact matches on t=
he package or
>> service names.  We could go as far as doing inexact searches akin to
>> what =E2=80=9Cguix package -s=E2=80=9D and =E2=80=9Cguix system search=
=E2=80=9D do, but maybe that=E2=80=99s
>> overkill given that the suggestions could be wrong.
>>
>> Anyway, I think that=E2=80=99s already an improvement and we can always =
refine
>> it later.
>>
>> Thoughts?
>
> This is great! I don't understand it all, but it seems like when there
> is
> no exact match for a package or service, we get the more generic hint
> I wrote.
>
> I'm happy with this version, so LGTM (though untested). Let's see what
> George thinks about it.

Oh YEAH! This is truly awesome!