From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ab3tAGPNLWE0RQAAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 08:34:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iAesN2LNLWFUdQAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 06:34:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84DE0CD60 for ; Tue, 31 Aug 2021 08:34:10 +0200 (CEST) Received: from localhost ([::1]:46784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKxLV-0001Bn-Hp for larch@yhetil.org; Tue, 31 Aug 2021 02:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKxLO-0001AM-Jp for guix-patches@gnu.org; Tue, 31 Aug 2021 02:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKxLO-0002nf-BZ for guix-patches@gnu.org; Tue, 31 Aug 2021 02:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKxLO-0003pa-8e for guix-patches@gnu.org; Tue, 31 Aug 2021 02:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49993] [PATCH 00/18] Remove Python 2 packages possibly added for Python 2 MediaGoblin. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Aug 2021 06:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49993 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ben Sturmfels , 49993@debbugs.gnu.org Received: via spool by 49993-submit@debbugs.gnu.org id=B49993.163039161414674 (code B ref 49993); Tue, 31 Aug 2021 06:34:02 +0000 Received: (at 49993) by debbugs.gnu.org; 31 Aug 2021 06:33:34 +0000 Received: from localhost ([127.0.0.1]:60953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKxKv-0003oX-Kt for submit@debbugs.gnu.org; Tue, 31 Aug 2021 02:33:34 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:41768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKxKp-0003o2-9F for 49993@debbugs.gnu.org; Tue, 31 Aug 2021 02:33:31 -0400 Received: by mail-wr1-f50.google.com with SMTP id u9so25713967wrg.8 for <49993@debbugs.gnu.org>; Mon, 30 Aug 2021 23:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=FUDK8wTe79PL6wHhrTnU82fWOOgtALFRpZMpEKZnHCg=; b=WdrxpjRVunK6gDwLT4Mt4dURbBU1aGqzDXxbA6KL3YS4lbxCT1VXAIiLuq0HlCQPD1 KjiOlwOhubNNDClgprrifYbGRNNtGxPymAk5cm6tInweharPJTdnEkdc7QbKmMol4cap 2540xJSJ9pkL6OMToiPjXF6+K8s0cut499cDsbowEN42g2QattdpqcnAo59Ez0WJRmrr +FBv6e2sAtKHRZCAQDhrQC3fN6tMbroci+p+ezeugHEDNkmRAnddU0irwZX+7JwUMcza xLrVDGx9rBB372dVHaWzOmNGnnu8cdcqayPWPX7oAbN9hmTDLvQVNI5hHnzjgVL08iad ymmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=FUDK8wTe79PL6wHhrTnU82fWOOgtALFRpZMpEKZnHCg=; b=A1ZCHhx7I/FBfnI5A2y8Am+jqeM61vk6lwjnVNDqtPqqOzmDCFcCuPN1ZyLOzFGZTh G8rD2hXx/6pyv+kz1l9uiDotFG61c+xT4B4FlfSXbkJg8N5/rC/LIkn9mNwApfeZCfHk 164ijUCgdUYY218nQ90de8JILZI1NyzyAHy1GOb19Zi2Dg47r6TPQaxCjJbTryY5bGSh M1R2mc3nuY9ovnGpxaUb6H1CohKSqgALFCGmF4WOza1I8KSbLDRJPGRxPicT5VoZJfFU vwTXOOGycejeO9CCaKjzrFlDpnckO+Hf6ykDYodUIm2nl+Ifi21jsC/k/9tfQqAd5/1m ilTw== X-Gm-Message-State: AOAM531fqHe2HpLj1g4sjtYmAg3QujuLYlLXePn3oKC3joVbOgNTCeP1 HUnRZg6FcsUZs7iSPzCwx9UNKE/9C4/Eag== X-Google-Smtp-Source: ABdhPJz3OMa6+Tw1pU9nn7YM3MJRxsp8Dl5RgjxJKnGKD+0Go27bvdy7oPoJB7ZAqyZIurXtusDHNg== X-Received: by 2002:a05:6000:23a:: with SMTP id l26mr28910513wrz.369.1630391601239; Mon, 30 Aug 2021 23:33:21 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id g1sm1932295wmk.2.2021.08.30.23.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 23:33:20 -0700 (PDT) From: zimoun In-Reply-To: <871r6a2zg7.fsf_-_@sturm.com.au> References: <20210831000946.11489-1-ben@sturm.com.au> <20210831000946.11489-2-ben@sturm.com.au> <871r6a2zg7.fsf_-_@sturm.com.au> Date: Tue, 31 Aug 2021 08:10:53 +0200 Message-ID: <86wno2dtzm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630391650; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FUDK8wTe79PL6wHhrTnU82fWOOgtALFRpZMpEKZnHCg=; b=e4nHYRKio7iCE1zqcG8/pDNPZxwVb0WRFfYMYeLfRMRlHV+II4u+nOc4zRnweZpdYa7/35 kBSWs7zmn+3kknabzDUfhMj+pWcroIJfvZFI4xfrLYJvuogTk24aznj9yWlFD0zSzZTsTH HJnFYv8dwp+fcNL/Xf1a7OXZjCjfhQKQywsHPjdx/fRlnchqZgkHymG9eMW9Kpdz8Ewprf 7bFcfRuGpex+F5Qfx3yGVNV9qTh6R1JlewikvMu7L9XJ2dp8pHVGKLQw1MfsSNidIcdfIi wh6/NIlSqyJbtnvrdoBavQhA2E6vmecX/unPjuhiPtqxMv1yOCshSJ04y86HDw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630391650; a=rsa-sha256; cv=none; b=b1W/bs9/M3qk3PE1ZEwqaGV4Zwyba+gpPn95JKLOtnXrOOwDLqexl6XVMYw3KW6PKKFwjd QoDeMTo7w14Uw4KScwVaPVdXL0YxkAUoe6u0MGE19euNeXr2yaSRB/wV3oaDxrg3mYCcj7 vhpODvhV6tXOftE28a98+4SnZQ83SR1bXN6xFbJM8ZniciWm2zjNXihtKAPFRZLSaL9ll8 FHlEg77WQUw2mRBss3DHm0K0+1VE2JL0TahLx99Ym6LCxvS3YFB+eZZYqtJXJkHeYMWp67 uV5ThQ9982hTMsG5m4RmcZu3AEtZ8zvD1W3E6MU5N2aA/54ib253G2Fm9ggUhg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=WdrxpjRV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=WdrxpjRV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 84DE0CD60 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: lvldCOCErDFY Hi, On Tue, 31 Aug 2021 at 11:08, Ben Sturmfels via Guix-patches via wrote: > Now that I think about it, I'm not sure that this ad-hoc approach to > removing Python 2 deps is all that useful. Maybe a systemic approach is > needed eg. drop all broken Python 2 packages and announce a future date > to drop all non-broken Python 2 packages. This is more or less the plan. Although there is no fixed future date to drop all the non-broken Python 2 packages. :-) For instance #49272 remove 10 Python 2 packages and to find them: --8<---------------cut here---------------start------------->8--- guix weather --display-missing \ --substitute-urls=3D"https://ci.guix.gnu.org" \ | grep 'python2-' --8<---------------cut here---------------end--------------->8--- then I pick only the leaf packages using =E2=80=9Cguix refresh -l=E2=80=9D.= The dependency graph needs some care because sometimes the graph is rewritten. For example, $ guix refresh -l python2-plastid No dependents other than itself: python2-plastid@0.4.8 Then, let try to locally build it in case something wrong happened on the CI. Note that the missing is checked on Berlin but the build uses both (Berlin and Bordeaux): $ guix build python2-plastid --no-grafts Or in some cases, it is a leaf package broken because another =E2=80=99pyth= on2-=E2=80=99 package is broken. Here, =E2=80=99python2-pandas=E2=80=99. In this case, = it depends. ;-) Try to fix =E2=80=99python2-pandas=E2=80=99 because: $ guix refresh -l python2-pandas Building the following 7 packages would ensure 12 dependent package= s are rebuilt: fio@3.27 python2-pybedtools@0.8.2 python2-plastid@0.4.8 pyth= on2-biom-format@2.1.7 python2-warpedlmm@0.21 poretools@0.6.0-1.e426b1f ribo= diff@0.2.2 or simply remove all the dependants in the same patch set. Be careful, the removal needs the correct order. :-) Personally, I tend to remove leaf package brokens becaus they do not build themselves and not because of broken dependencies. For instance, in this list (from Guix a9eb969): --8<---------------cut here---------------start------------->8--- python2-biom-format-2.1.7=20=20=20 python2-pybedtools-0.8.2=20=20=20=20 python2-plastid-0.4.8=20=20=20=20=20=20=20 python2-warpedlmm-0.21=20=20=20=20=20=20 python2-scikit-learn-0.20.4=20 python2-fastlmm-0.2.21=20=20=20=20=20=20 python2-pandas-0.24.2=20=20=20=20=20=20=20 python2-seaborn-0.9.1=20=20=20=20=20=20=20 python2-pysnptools-0.4.11=20=20=20 ptpython2-3.0.17=20=20=20=20=20=20=20=20=20=20=20=20 python2-statsmodels-0.11.1=20=20 --8<---------------cut here---------------end--------------->8--- I would remove only the package =E2=80=99ptpython2=E2=80=99. All the other= s depend on =E2=80=99python2-pandas=E2=80=99 and remove =E2=80=99python2-pandas=E2=80= =99 means also remove =E2=80=99fio=E2=80=99, =E2=80=99poretools=E2=80=99 or =E2=80=99ribodiff=E2=80=99. And I am not en= ough qualified to have an opinion if it is worth to fix them. Therefore, I queue these packages in my TODO list and then I revisit months later: if there are still broken and no issue is open, it means they do not worth and can be removed. HTH. All the best, simon