From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QKDgIN0c+WS6SwEA9RJhRA:P1 (envelope-from ) for ; Thu, 07 Sep 2023 02:44:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QKDgIN0c+WS6SwEA9RJhRA (envelope-from ) for ; Thu, 07 Sep 2023 02:44:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 292F263FD3 for ; Thu, 7 Sep 2023 02:44:13 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mGqM34nI; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694047453; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=1efT7Hy+2LUHk6pwzm0EtN+Ncqmp+SLzgGTzAV2IRfM=; b=bo+TB1V5bU7Ko5Mxh2AhNBn0Wha5qogp9l1nGpOeRydtX6zSEgA8QbWV8xLQeZ6hHNg4Eq ngU/+7jtz7YyVRq0AKkEpyoW2+SPs1RW361ZROduBevoSNI6J4jEm/NFGsqMjUAPPPFjPZ aKhmxt3VeHQvbZupd3LiVA9DYes2JBFDo85ScaoOiFds/zP0x8FwVJNRpu7KHcWBsfVuLp etcO7Zl/SXmcjsrwO88PcPBlpXaYVHq8pkgMSx5Wvo6y10EjG2cUWM0ln8A5XwxaMfALPm mt9/1/kisFVg14a0uczIY4DrneYHQP7m6+7ya/Da0kWz4jwrolVuNDrpwlmTFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=mGqM34nI; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694047453; a=rsa-sha256; cv=none; b=HfCQYHpKPBeDh5d02/IGiIG1XlxZNyriGJBEXN8A3tG8/Wv5lmpIhDFrbXVqrkQki+zrVw TFalrNZbuzqeDY6bD6KzLrvwIx47zVFfU0GfRPRxkneRDOamJK6txX2FBCC6NQulDTyFqo CuVc/KLF8WAUS7yEndJy3s0P1yfYAIAnMDQgWrAnGVxar+tiJHtDBFSSI5z3ceJmZ/so0S tCfbo5FglXKLKEbjedGX6IFlTL7Qh6BHtFm81089B9W65ASM4Rsh63ITkQNWJTWxWntxa3 YQZgFCXVkyAazsYUgJwybD7WlLjtNTvjHbi2HgSrlg0z/ox+WxEuMvzw7ydmqQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qe37d-0006ki-5B; Wed, 06 Sep 2023 20:43:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qe37O-0006Mn-Dd for guix-devel@gnu.org; Wed, 06 Sep 2023 20:43:35 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qe37L-0002im-Ka for guix-devel@gnu.org; Wed, 06 Sep 2023 20:43:33 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-401d61e9fecso968775e9.0 for ; Wed, 06 Sep 2023 17:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694047409; x=1694652209; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1efT7Hy+2LUHk6pwzm0EtN+Ncqmp+SLzgGTzAV2IRfM=; b=mGqM34nImrzwbSVT2nHTzcMOfdHNLccAkl71Vcpx4jW14KMkexyDrPCHoOVJ6mwPfp 6Dz6+D9tUk1Vd7tFEsyxlP+RYRGJ2Dfj14beP+baJO6lUV5mAAk7J2mk18j6jpHTW6hS TZYvIitgLjHy7qYuMPB9hWzqABSycZLIrXo5mcJIVVz9+VJVjRkEqNk+O3r4EeFfysNt e2F4BRQryZ8nSkPh+c8ZQvBzGtQFH7aSaQtRGNASZBgWYwhOR5h4RrPkWmzpbM5fi2OA d7CulwWqJIzTIreMlJew56U0pR7m50V7DmH/SseZPeZTTjOUrEQqEuJE8HX9AqQEu5fD +3YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694047409; x=1694652209; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1efT7Hy+2LUHk6pwzm0EtN+Ncqmp+SLzgGTzAV2IRfM=; b=jGlebbCrOJKBYrVFg32c5kWkaH4MLsilssCuBhn9vZ7/Z4PuHvFG7NRRJh0sgUfocd lnRJlCzuOlPfG2L+8VpLSxs4ILTB4ffD1ILwf/86pFlM5WkOcO8/6xnT9xHdbeu8cy6E lG5scXkNAni5S3P3YJc1sPPpUbQwA7ux2EtZmPo1vTO+uU+KBADge/vNQ9VOXSD1YCrU ABi+Aqcpz4jiENiCjcm0jExxkDrBe2Zk9pFLx+lOOylZdAlbbNTZ4XPPuWSq0BXZZeaK uAZMQasmZF7gXYVcQRQA9WoB91f6sYT6YlFAv1fZQp62V5tIxS1AES5Wvzw8RKvtsq7c TvJg== X-Gm-Message-State: AOJu0Yya8X21DWycojZfK0n35aJxYVTz+qP4hdd5lYWfj0QY4+7W3cUH asj6X8udYhAha3uT/9yEBTrv5Msq+X0= X-Google-Smtp-Source: AGHT+IFxE9d0UzmxwyZPJqZOLt7bnbwSNUY21FgREUDhselk6+yz80DNKPYaWnSYFMCTm5XZtHEi+w== X-Received: by 2002:a05:600c:8505:b0:401:c07f:72bd with SMTP id gw5-20020a05600c850500b00401c07f72bdmr14174733wmb.4.1694047408684; Wed, 06 Sep 2023 17:43:28 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id k8-20020a5d6d48000000b0031434c08bb7sm21554834wri.105.2023.09.06.17.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 17:43:28 -0700 (PDT) From: Simon Tournier To: Felix Lechner , Christopher Baines Cc: guix-devel@gnu.org Subject: Re: Process for reviewing patches as someone without commit access In-Reply-To: References: <87o7ifb66o.fsf@cbaines.net> <87jzt3b0yn.fsf@cbaines.net> Date: Thu, 07 Sep 2023 01:37:56 +0200 Message-ID: <86wmx2na97.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 292F263FD3 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -7.56 X-Spam-Score: -7.56 X-TUID: k0EmtEShDn2u Hi Felix, On Wed, 06 Sep 2023 at 12:01, Felix Lechner via "Development of GNU Guix an= d the GNU System distribution." wrote: > Usually, helpful reviews come from people with more experience. In > your system they come from folks with less. That seems upside down to > me. Well, I think we are not there. Maybe I am missing the proposal about levels. Somehow, I think there is not enough regular contributors for having kind of levels. Well, that=E2=80=99s not Debian. ;-) Aside that considering how Savannah is configured today, commit access are all or nothing. Cheers, simon