From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MAkRFUSrS2G4oAAAgWs5BA (envelope-from ) for ; Thu, 23 Sep 2021 00:16:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AC68EESrS2GNLAAAB5/wlQ (envelope-from ) for ; Wed, 22 Sep 2021 22:16:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8ABA51F39B for ; Thu, 23 Sep 2021 00:16:35 +0200 (CEST) Received: from localhost ([::1]:32938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTAXa-0002ul-K2 for larch@yhetil.org; Wed, 22 Sep 2021 18:16:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTAX4-0002ua-K5 for guix-patches@gnu.org; Wed, 22 Sep 2021 18:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTAX4-0003mn-Bo for guix-patches@gnu.org; Wed, 22 Sep 2021 18:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTAX4-00076G-3E for guix-patches@gnu.org; Wed, 22 Sep 2021 18:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49581] [PATCH v3] gnu: Add git-issues. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Sep 2021 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49581 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: Tobias Geerinckx-Rice , 49581@debbugs.gnu.org Received: via spool by 49581-submit@debbugs.gnu.org id=B49581.163234891224306 (code B ref 49581); Wed, 22 Sep 2021 22:16:02 +0000 Received: (at 49581) by debbugs.gnu.org; 22 Sep 2021 22:15:12 +0000 Received: from localhost ([127.0.0.1]:52057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTAW6-00069e-Sd for submit@debbugs.gnu.org; Wed, 22 Sep 2021 18:15:12 -0400 Received: from out1.migadu.com ([91.121.223.63]:52935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTAW1-00067y-6D for 49581@debbugs.gnu.org; Wed, 22 Sep 2021 18:15:01 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632348895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppndtU8pYVNXjTTdfPbC5CzF+91cFUzivkYtZ00YkoU=; b=cfdZ7ohO/3Kj0CU20d0whhIVBJYtoW7WqTH7fpmezE1yuVmzSog1HeUx/2pVujv1q6A17Z vEYx/Eb6PBA9qZZgph/ZLQV6sry+L5sml4bCP8AAtJraA6srmxroVrg/MNXDnMswhIOB8L G+67RzYooggLkOXpeO9448vKkqlY7h4= From: Sarah Morgensen References: Date: Wed, 22 Sep 2021 15:14:53 -0700 In-Reply-To: (phodina@protonmail.com's message of "Sat, 18 Sep 2021 08:31:45 +0000 (4 days, 9 hours, 54 minutes ago)") Message-ID: <86v92sw942.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632348995; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ppndtU8pYVNXjTTdfPbC5CzF+91cFUzivkYtZ00YkoU=; b=Qiypg+8W4V63EEX2L9j+XLNAeoEZJIIDIN8/lOMpWFNsboxZKMqBl+zGYV/VQJlmmLztM4 0H0ujCvqNXeORdW+Egkr752q7UYgENsXx+CF1d1Oj1G5uTHDYUYmcraCPZDaiGNf3bAIXu +OTuQXeLFTkDPVyQWC2ZDfQ6XILOecpOG9CYO0PQHlfjmQE3Kh6NJ7HK1N1xtg7zSK5SSi BM3PxCBMwHFIO70NRVpvIGqmUjjRQTAFDqROtnm3a88qxCo/EFuoVSqZ+aqolfF/q3LffB iFqdLUKecPfGsZq3WjkkKMmzqBm6v3S7enkcQnDKpVbwnusTPrPzLlY8F7m0hg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632348995; a=rsa-sha256; cv=none; b=Sey4CT79YzZjeGN2la/J1wKSnIefDqVVAszkmOlJgS2Bt+nM2i+GPK5/dD2kknQqN4oN8S tJ0cMhfkzujgICeTNWy/IFCEp59ZUvw5BIWm+PcYUBpKgy0u73r3OrUSlUECdLOR273POa k9zrkDrQvjKWqgmUbMF9hkpAV+IPt1jiDNcUAOWgWVr3CSo2mGAFlrxOlPBS4EHjmXedAe SVHdwZ+u1hbZfdmWJ07O5mvyeDcCvERmbi4gr2EG+kCfdzijwR7D9ppTCGgrw5dDOd1Yvs b34AsBAeNV9ZFguWvQM5PNTVoMFeEYT7A0cn1ji6uDmLkdoe/Nxx3Pc0FShuRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=cfdZ7ohO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=cfdZ7ohO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8ABA51F39B X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: kSGcpQEMCzgM Hello Petr, Thanks for your updated patch. This looks like a great tool. After making the changes below, I gave it a try, and I might use it myself when I can't use fossil! I was unable to apply your patch with `git am'; I had to guess which commit it was based on and manually apply it. In the future, please configure your git to include the base commit with git config --local format.useautobase whenAble or use the `--base' command line option: git format-patch --base=3Da916d50566 phodina writes: > * gnu/packages/version-control.scm (git-issues): New variable. > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-cont= rol.scm > index 7c1dbe8b26..cff1190094 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -39,6 +39,7 @@ > ;;; Copyright =C2=A9 2021 LibreMiami > ;;; Copyright =C2=A9 2021 Xinglu Chen > ;;; Copyright =C2=A9 2021 Fran=C3=A7ois J. > +;;; Copyright =C2=A9 2021 Petr Hodina > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -1267,6 +1268,36 @@ subcommands helps automate some parts of the flow = to make working with it a > lot easier.") > (license license:bsd-2))) > > +(define-public git-issues The name should be "git-issue" since that's the name of the project and the command. > + (let ((commit "67aacad35888b4c51e2d7be35c86fef137874f12") > + (revision "1")) > + (package > + (name "git-issues") > + (version commit) > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/dspinellis/git-issue") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1z6dpwbikmiq5acpbji4kvmxqc2jw995rfk5703k5mvp5ps9a29q"= )))) > + (build-system gnu-build-system) > + (arguments > + '(#:tests? #f Please add a comment explaining why tests are disabled. For example, I attempted to run the tests and found that they must be run in a git repository, and that a global user.name and user.email must be configured. > + #:make-flags (list (string-append "PREFIX=3D"(assoc-ref %output= s "out"))) Please add a space after "PREFIX=3D" and wrap the line. > + #:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'build)))) > + (synopsis "Git-based decentralized issue management") > + (description "Git-issues provide a minimalist decentralized issue > +management system based on Git, offering (optional) bidirectional integr= ation > +with GitHub and GitLab issue management.") This is a bit short. How about: --8<---------------cut here---------------start------------->8--- (description "@command{git-issue} provides a minimalist decentralized issue management system based on Git, offering (optional) bidirectional integration with GitHub and GitLab issue management. Issues are stored as simple text files, so no special tools are required to access your data, and issues are changed and shared through Git, so no special infrastructure is necessary to manage your data.") --8<---------------cut here---------------end--------------->8--- > + (home-page "https://github.com/dspinellis/git-issue") > + (license license:gpl3+)))) > + > (define-public stgit > (package > (name "stgit") > -- > 2.32.0 Additionally, it looks like git-issue depends on several tools: cat, curl, grep, git, find, jq, and sed, at least. These should probably be included in inputs and substituted in the script, perhaps with: --8<---------------cut here---------------start------------->8--- (add-before 'install 'patch-paths (lambda* (#:key inputs #:allow-other-keys) (define (input-file input file) (string-append (assoc-ref inputs input) "/" file)) (substitute* '("git-issue.sh" "lib/git-issue/import-export.sh" "scripts/replacerefs.sh") (("\\bcat\\b") (input-file "coreutils" "bin/cat")) (("\\bcurl\\b") (input-file "curl" "bin/curl")) (("\\bdate\\b") (input-file "coreutils" "bin/date")) (("\\bgit\\b") (input-file "git-minimal" "bin/git")) (("\\bgrep\\b") (input-file "grep" "bin/grep")) (("\\bfind\\b") (input-file "findutils" "bin/find")) (("\\bjq\\b") (input-file "jq" "bin/jq")) (("\\bsed\\b") (input-file "sed" "bin/sed")) ;; Substitute back any usage examples. (("((usage|Example): )/gnu/store/[^/]+/bin/(\\w+)" all start exec) (string-append start exec))))) --8<---------------cut here---------------end--------------->8--- I may have missed a few utilities, though. Thank you! -- Sarah