From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uA92CKjbT2GI3AAAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 04:32:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qLBDBKjbT2EBTgAA1q6Kng (envelope-from ) for ; Sun, 26 Sep 2021 02:32:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44FBFDD2D for ; Sun, 26 Sep 2021 04:32:07 +0200 (CEST) Received: from localhost ([::1]:36806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUJxW-0005JN-9R for larch@yhetil.org; Sat, 25 Sep 2021 22:32:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUJxS-0005J7-O0 for guix-patches@gnu.org; Sat, 25 Sep 2021 22:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUJxS-0007Hm-Go for guix-patches@gnu.org; Sat, 25 Sep 2021 22:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUJxS-0006vq-Db for guix-patches@gnu.org; Sat, 25 Sep 2021 22:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#34358] [PATCH] gnu: python@2.7: Honor NIX_STORE. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Sep 2021 02:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34358 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Caleb Ristvedt Cc: ludo@gnu.org, 34358@debbugs.gnu.org Received: via spool by 34358-submit@debbugs.gnu.org id=B34358.163262348726600 (code B ref 34358); Sun, 26 Sep 2021 02:32:02 +0000 Received: (at 34358) by debbugs.gnu.org; 26 Sep 2021 02:31:27 +0000 Received: from localhost ([127.0.0.1]:35241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUJwt-0006ux-GZ for submit@debbugs.gnu.org; Sat, 25 Sep 2021 22:31:27 -0400 Received: from out2.migadu.com ([188.165.223.204]:30798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUJwp-0006ui-D8 for 34358@debbugs.gnu.org; Sat, 25 Sep 2021 22:31:25 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632623481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Wd1f2xpHwewVSk/WLiy40t5QJu46+DKHivZ2gzMzrE=; b=hJsUWOFLAm2ugXpIkq0zOGRbq7nQNupjotqrQfv9sSueQItHgSP2lPN58+gpv3CVTJzpXf Um7yiA2pVeuoX6r/bPZMBw/FEQIY+FWiR3x5HGeP+iqYt0AydckRfHMU2IRv1w9wVAQW39 6g5W5kiIFXer5rh2KQ9gOw88AMO4mbg= From: Sarah Morgensen References: <20190204192241.15758.66035@vcs0.savannah.gnu.org> <20190204192243.A58BA20B45@vcs0.savannah.gnu.org> <87y36vjgee.fsf@gnu.org> <87sgx0cvgm.fsf_-_@cune.org> Date: Sat, 25 Sep 2021 19:31:19 -0700 In-Reply-To: <87sgx0cvgm.fsf_-_@cune.org> (Caleb Ristvedt's message of "Wed, 06 Feb 2019 18:07:21 -0600 (2 years, 33 weeks, 14 hours ago)") Message-ID: <86v92ouky0.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632623527; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8Wd1f2xpHwewVSk/WLiy40t5QJu46+DKHivZ2gzMzrE=; b=aLnJn9oDZR+x/t0Daiab8uENE6p3Qfkb0p0HGlGcJt8l2aDRKSiaBJoWLv5P+KLaTCt89O KEnU5cO1PGksH1ZEOZjIgYPDSIIFwcsCug4HR3Kv/8tbduOhBODbxw94PhLGVhmpCVDqTI F33vRFtEnUdHQy2GbL3+0heQk3ryqL6VdkG4Q1qXwakv0dWyFFtBpv0m+0dYnb9iFjRaTM QCpH63WavRMofauGtl86DTCvjVNlWiZx30u9GM3Thc9w6X8231AuETBq/JicdL+BhnMj2b 6kCmhKVl8q8SeAOozVBNK76lDy1FjULMAk476KNtd6++Rm4fU7FlIpx1oJWmGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632623527; a=rsa-sha256; cv=none; b=Gt6/aMhFbNaH3eRjRrHh/kKa5pCyiOv973xgjoBTCRcbv950/0jizzYV3yxkzxEgJmgV+i 8sBn3eAOBFDbzausCfUDzIl9cBqWO7FYUQPshjoaMfwv4M/PuhzKxPVWoBfnPvISlxTyD5 Z2FYPTh5B53GItGMFajPZNQ8J2TKaDzmKA+kyk2bpFN4G8kB5hy4mEXUhwroJxNZDTIKOE tjU6D9vLb/0e5OADHvtw7A+qZZ1snM2IOZyXrqzAiP/DSLhpoDpWiHOfpZArK+/evG5ALQ ubFi8X8Yhk2Q2YBIc5im3C/gb+YjLOm6mFfETmivm1DfZhhIyPluDrFTssIIjQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=hJsUWOFL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=hJsUWOFL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 44FBFDD2D X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9+O3Qvcj2gGK Hello, Caleb Ristvedt writes: > Ludovic Court=C3=A8s writes: > >> Perhaps in the future you could email guix-patches@gnu.org for specific >> commits like this one, especially when it=E2=80=99s not strictly related= to the >> daemon? > > ... > >> Could you send an updated version of the patch? > > Here it is! > >> ./configure does not generate any patch files based on patch templates, >> and that=E2=80=99s on purpose. Instead, when we need something like thi= s, we >> handle it the way ld-wrapper.in is handled: by doing the substitution >> when creating the derivation. > > "When creating the derivation" sounds like it's when the package is lower= ed > to a derivation, but from what I can see of ld-wrapper in (gnu packages > base) the actual substitution is done when the derivation is built. I > am curious how one would go about doing the substitution when the > package is lowered to a derivation, though. Anyway, for now I'm doing > the substitution at derivation-build-time. > >> Last, the patch would need to go to =E2=80=98core-updates=E2=80=99 becau= se of the number >> of rebuilds it entails. > > Should I mention this somewhere? > > Also, I should add that "guix lint" and indent-code.el both want changes > to gnu/packages/python.scm, but not due to changes I made. Should a > separate patch address those? > > - reepca > >>From 62e9e9a336ab5608405df8114f78c3cbb9dc3a39 Mon Sep 17 00:00:00 2001 >From: Caleb Ristvedt >Date: Wed, 30 Jan 2019 17:00:32 -0600 >Subject: [PATCH] gnu: python@2.7: Honor NIX_STORE. > >Previously various python packages would fail to work unless the store they >were kept in was /gnu/store. This fixes that. > >* gnu/packages/patches/python-2.7-site-prefixes.patch.in: New file that ca= uses > python@2.7 to honor NIX_STORE at runtime or, if it isn't set, to use the > NIX_STORE available when it was built. > >* gnu/packages/patches/python-2.7-site-prefixes.patch: Removed. > >* gnu/packages/python.scm (python-2.7): generates a patch from > python-2.7-site-prefixes.patch.in at build-time and applies it. > (python-3.7): don't apply that patch. > (python2-minimal): inputs still need to include the patch utility and the > patch. > >* gnu/local.mk: adjust patch name since it's been suffixed with ".in". Given that Python 2.7 is now EOL and Python 3 doesn't seem to use this NIX_STORE patch in the first place, is this patch still relevant? -- Sarah