From mboxrd@z Thu Jan 1 00:00:00 1970 From: myglc2 Subject: Re: The usability of Guix configurations Date: Tue, 07 Nov 2017 09:11:42 -0500 Message-ID: <86tvy6tbz5.fsf@gmail.com> References: <868tfjw4is.fsf@gmail.com> <20171106221621.GA2534@jasmine.lan> <86o9oex34v.fsf@gmail.com> <779b1b6f2043e03a2f911981142e7740@lepiller.eu> <777f3534955ec61a520ff5f9b7054673@lepiller.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eC4bX-0002gW-Mj for guix-devel@gnu.org; Tue, 07 Nov 2017 09:11:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eC4bS-00005j-0V for guix-devel@gnu.org; Tue, 07 Nov 2017 09:11:51 -0500 Received: from mail-qk0-x22e.google.com ([2607:f8b0:400d:c09::22e]:49278) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eC4bR-00005U-Rs for guix-devel@gnu.org; Tue, 07 Nov 2017 09:11:45 -0500 Received: by mail-qk0-x22e.google.com with SMTP id q83so15373163qke.6 for ; Tue, 07 Nov 2017 06:11:45 -0800 (PST) In-Reply-To: <777f3534955ec61a520ff5f9b7054673@lepiller.eu> (julien lepiller's message of "Tue, 07 Nov 2017 14:13:04 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: julien lepiller Cc: guix-devel@gnu.org On 11/07/2017 at 14:13 julien lepiller writes: > Le 2017-11-07 13:52, Hartmut Goebel a =C3=A9crit=C2=A0: >> Am 07.11.2017 um 12:05 schrieb julien lepiller: >>> Since we encourage users to use use-package-modules etc, I think it's >>> better >>> to catch this error and explain it to users as soon as it happens. >>> It's more >>> friendly for users than a troubleshooting section in the manual. >> >> +1 >> Thanks for proposing a patch so quickly! >> >>> Package module "abc" does not exist. >>> ERROR: In procedure scm-error: >>> ERROR: check "use-package-modules" line in your configuration. >> >> For me this looks confusing: The actual error message is not >> prefixed by >> "ERROR:". Also (nitpicking) the explanation could by a bit more >> verbose. >> Like this: >> >> ERROR: In procedure scm-error: >> ERROR: Package module "abc" does not exist. >> ERROR: Please check the "use-package-modules" line in your >> configuration. >> >> It would even be better is the fist line would not refer to "procedure >> scm-error", but to the config actually processed (and even the line in >> there). But nevertheless this patch is a big improvement already. > > This new version outputs something like this : > > > guix system: error: failed to load 'vm-image.tmpl': > vm-image.tmpl:6:0: vm-image.tmpl:6:0: Package module "abc" does not > exist. > Check the "use-package-modules" line in your configuration. Thanks Julien, I tried the patch and it works for me. I think it is a great improvement. Small suggestion: is it feasible for the last line to read: Please add a module containing "abc" to the "use-package-modules" line in y= our configuration. TIA - George