all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 24083@debbugs.gnu.org
Subject: bug#24083: guix lint doesn't actually fail on some errors
Date: Wed, 24 Mar 2021 23:19:04 +0100	[thread overview]
Message-ID: <86tup09ovb.fsf@gmail.com> (raw)
In-Reply-To: <20160727231222.66849389@scratchpost.org> (Danny Milosavljevic's message of "Wed, 27 Jul 2016 23:12:22 +0200")

Hi,

On Wed, 27 Jul 2016 at 23:12, Danny Milosavljevic <dannym@scratchpost.org> wrote:
> On Wed, 27 Jul 2016 22:57:15 +0200 ludo@gnu.org (Ludovic Courtès) wrote:
>> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>> 
>> > guix lint doesn't actually fail on some errors.  
>> 
>> It never pretended to exit with non-zero when warnings are emitted.  :-)
>> (These are warnings, not errors.)
>
> Too bad :)
>
> I wrote a little helper script which was supposed to prevent me from posting
> packages that don't build or lint. Then I found out that the lint actually
> doesn't fail on warnings. So now my script is only half as useful (the builder
> does fail on build error).
>
> It would be nice to have a way to also check the lint status.

The good news is that the initial example ’perl-io-socket-inet6’ now
does not report any linting error. :-)

Well, on the other side, it is still the same behaviour.

--8<---------------cut here---------------start------------->8---
$ guix lint julia ; echo $?
gnu/packages/julia.scm:301:0: julia@1.5.3: line 301 is way too long (107 characters)
gnu/packages/julia.scm:303:0: julia@1.5.3: line 303 is way too long (106 characters)
gnu/packages/julia.scm:226:13: julia@1.5.3: can be upgraded to 1.6.0
gnu/packages/julia.scm:227:12: julia@1.5.3: source not archived on Software Heritage
0
--8<---------------cut here---------------end--------------->8---

What do we do.  On one hand, «it never pretended to exit with non-zero
when warninf» and on the other hand it could be annoying.

Well, since it is 4 years and 34 weeks, I consider it is not a big deal
and so we can close.  WDYT?


All the best,
simon




  reply	other threads:[~2021-03-24 22:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 22:25 bug#24083: guix lint doesn't actually fail on some errors Danny Milosavljevic
2016-07-27 20:57 ` Ludovic Courtès
2016-07-27 21:12   ` Danny Milosavljevic
2021-03-24 22:19     ` zimoun [this message]
2021-06-09 21:41   ` zimoun
2021-07-13  9:05   ` zimoun
2021-07-13 10:20     ` Danny Milosavljevic
2023-03-31 16:57       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tup09ovb.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=24083@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.