From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aPdfO4DqRGENUwAAgWs5BA (envelope-from ) for ; Fri, 17 Sep 2021 21:20:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CUb5NoDqRGFqaAAA1q6Kng (envelope-from ) for ; Fri, 17 Sep 2021 19:20:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B8F4B1E480 for ; Fri, 17 Sep 2021 21:20:32 +0200 (CEST) Received: from localhost ([::1]:52246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRJPT-00081d-16 for larch@yhetil.org; Fri, 17 Sep 2021 15:20:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRJP0-00081G-CR for guix-patches@gnu.org; Fri, 17 Sep 2021 15:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRJP0-0006G0-5I for guix-patches@gnu.org; Fri, 17 Sep 2021 15:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRJOz-0002Sj-V5 for guix-patches@gnu.org; Fri, 17 Sep 2021 15:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50614] [PATCH] build: utils: Add =?UTF-8?Q?=E2=80=98list-when=E2=80=99?= macro. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Sep 2021 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50614 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 50614@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 50614-submit@debbugs.gnu.org id=B50614.16319063629413 (code B ref 50614); Fri, 17 Sep 2021 19:20:01 +0000 Received: (at 50614) by debbugs.gnu.org; 17 Sep 2021 19:19:22 +0000 Received: from localhost ([127.0.0.1]:33044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRJOL-0002Rl-Qp for submit@debbugs.gnu.org; Fri, 17 Sep 2021 15:19:21 -0400 Received: from out2.migadu.com ([188.165.223.204]:50933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRJOK-0002Rc-49 for 50614@debbugs.gnu.org; Fri, 17 Sep 2021 15:19:21 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631906358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GwsxQlO+Px+5jmH6qXMRKFcad4WVznsA3od5TExnmyI=; b=GFDVe5q1NCe6lIvxTjoHs18n4N8KjMdfrV+ascsw5JpfRT3FC58+ujxAc3TKQS4NVpBa0a 3FFTs+TOzRTpGwLkRBa9cNIf5jMLjDwJmmariOe6nC/xXSyXOpo5hR1fEqGUm+zXrBiNYY 8KlTSuXsc1D+wDPbbegHIRas+MV0VH8= From: Sarah Morgensen References: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> Date: Fri, 17 Sep 2021 12:19:16 -0700 In-Reply-To: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> (Xinglu Chen's message of "Fri, 17 Sep 2021 10:26:41 +0200 (10 hours, 45 seconds ago)") Message-ID: <86tuijggcr.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631906432; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=GwsxQlO+Px+5jmH6qXMRKFcad4WVznsA3od5TExnmyI=; b=q4D9wcGvsDlZrFnsAHDIbaK8Lty+Lo62YRS2uP4AZLkNgbtefNqyKS4aX9CF23evGdodcj z3F5JCPO7Ds/Uk4tN7kBUqTYGAKiLNsL2x7IhB/Uku+9vi6GiJrO1sgcvwSp+oYidjqFfT 9ZFRCL0iJ+UdExWdr8bsOtmGg0ONUQ19d/ldVG6OcpWu1ce+1nehO6OVXviUDaMuIiy8Nl 9qQOjq2IqHuyIwZrW07pOYVyGIFSDLFVr7CjAaFEF8Xo9wb9/+mEXdR5WJxQ6MWZCnQ7Pq 1pKG1KPKdQK4gYEIZA0nb5YpE6URE09/VZpPne9nPgGEOaiWhjsnFsBR8aB1kg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631906432; a=rsa-sha256; cv=none; b=W82OSukNNzkth3wavHoXGK9hTgvhdRRAU2Pzk8Q7+fkyNknU8CM3MEures4OqPldyN+E+w oLyMNdgAm1iqj0y8Z7oHlsrM/dZ0D7iCbuCGZzGAuaT+Z1W7aXOeTltGa6hPimHiu4b/qZ WkcLyqj/8wd5YUtzpR149jIyre0kAQsX/vwYz7cZ+m0P5Dvv0hgk9jFa3HYVkCOsOlyvCK xSZi1Gr5g0G+ByfcWdEC/glY0MtqjSFrmkp5gbrZGbKsWaPz0l1Q6j9dxzxkajwh8n2jF1 jH7WidNQwm2K+kkcm+hL8A8tsd+Rr5TwHen35ZKmabkJ2OTvKtnnvsuzlBWBZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=GFDVe5q1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mgsn.dev header.s=key1 header.b=GFDVe5q1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=mgsn.dev (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B8F4B1E480 X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: IPHdgpVL8Sjg Hi, Looking at this again I have a couple more comments. Xinglu Chen writes: > +@cindex miscellaneous build utilities > +This section documents some miscellaneous utilities that are useful to > +have. "that are useful to have" is implied by its presence in the manual, so it's unnecessary to write it. Also, you might consider adding a rule to .dir-locals.el: (eval . (put list-when 'scheme-indent-function 1)) which would cause it to be indented like this: (list-when expr1 expr2 expr3) (I pointed out a couple other minor grammar corrections in the last review--did you see those?) -- Sarah