From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4H4INMuHfmOe2wAAbAwnHQ (envelope-from ) for ; Wed, 23 Nov 2022 21:51:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +G/1M8uHfmNZyAAA9RJhRA (envelope-from ) for ; Wed, 23 Nov 2022 21:51:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 749243BE2E for ; Wed, 23 Nov 2022 21:51:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxwiA-0000zf-Uh; Wed, 23 Nov 2022 15:51:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxwhz-0000we-TF for guix-patches@gnu.org; Wed, 23 Nov 2022 15:51:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxwhy-0001SN-N7 for guix-patches@gnu.org; Wed, 23 Nov 2022 15:51:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxwhy-0007je-JI for guix-patches@gnu.org; Wed, 23 Nov 2022 15:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Nov 2022 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.166923662029645 (code B ref 59513); Wed, 23 Nov 2022 20:51:02 +0000 Received: (at 59513) by debbugs.gnu.org; 23 Nov 2022 20:50:20 +0000 Received: from localhost ([127.0.0.1]:56393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxwhI-0007i4-Ay for submit@debbugs.gnu.org; Wed, 23 Nov 2022 15:50:20 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:35820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxwhG-0007hb-Oo for 59513@debbugs.gnu.org; Wed, 23 Nov 2022 15:50:19 -0500 Received: by mail-wr1-f41.google.com with SMTP id b12so17425555wrn.2 for <59513@debbugs.gnu.org>; Wed, 23 Nov 2022 12:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=xCpft4Ls2PLce4Uj4sX8CWsd4QRXdWwp7D6lAwo8UTo=; b=NexWQECiOrllr0DK9GUCsBuWcvKFVwe6GEYdrCnbvkRsz+M1w5GR3ztsEUuzzDEY5+ hS7eed4oUghZ7MEGPtavl7VbEZvTW5tURXU6bCBlF1ILL4rDsfJ5PZtiMz0QmWLeUrTp Y5HbEO+whiX9fn0TisVMXNr8lY2peOnu0BQJihlVM+b2EoaEat/Bh8rM/7XeV9HTHmUf 2WM0OIpH4ZYBJGuRDX7SZF/0rro1aG5GjS1qpesXckmh+uZn8TFLjVrQw7dK938yE5OR r0Y0SPMGCTNcG5BIRlIk9KuUUVcl6/6filT6fJ9/1pxBEPXWWvFuhY9uKj3Yb3P3NDAv IN8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xCpft4Ls2PLce4Uj4sX8CWsd4QRXdWwp7D6lAwo8UTo=; b=KZk1oOUzh0d//Sz2px2PmscDu9E0LRzvCR0fbIFLuGVJxkO3KsisAdaiIgQ1n7TItk YVCNHpjh0hDVqBngbnpRRUHMHv2XTdTfiXjIF6RVGLho5Uv47ql7Ubjzp6tROSnDTHVA sMegvVFOmhRvv51tHky7iSN8q/IroYQRanJqcAebPI39F0S/PbMVa3Qrij+5qMAGIR/d mk00AHv+seq4DouraG/caeDTRzB3NKqYU+6Xie4cJ3JFyp2qVzy8Fj2HLCcUUOC3xPST YGoyupvqWpFg+XvPvGAwUzJnX8dW1T22wPyZZEF+mVNKyz0SgOwnK0hKi9tlIsfQF7Xu tuGQ== X-Gm-Message-State: ANoB5plU5jz77hyxz0rkddPz/nwvPF/wNy16Cgs5oPb+cBgn4yOrZY5n ZjnBvl8EX6iVJsATYLMkf0HFTFpevmE= X-Google-Smtp-Source: AA0mqf4x2jWIZ23dAEdQuVFazOj1wseFwA8gUmSKKCFy/61Kcu6xfsAqBP7TIJ4lgyGyU6Pz8YWM4A== X-Received: by 2002:adf:a181:0:b0:241:bd28:f985 with SMTP id u1-20020adfa181000000b00241bd28f985mr16307441wru.686.1669236612917; Wed, 23 Nov 2022 12:50:12 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id i19-20020a1c5413000000b003cfc02ab8basm3768975wmb.33.2022.11.23.12.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 12:50:12 -0800 (PST) From: zimoun In-Reply-To: <20221123104946.29480-1-mail@cbaines.net> References: <20221123104946.29480-1-mail@cbaines.net> Date: Wed, 23 Nov 2022 21:27:32 +0100 Message-ID: <86tu2pfmbv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669236683; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xCpft4Ls2PLce4Uj4sX8CWsd4QRXdWwp7D6lAwo8UTo=; b=gCK19HfvtxX5CiWKxd1VCnBWtiSBG1vq3x83vIw4aivuUHw7BbK+7+dZDm59qGy/j2hXuU g/FALjPtKugjJPhe2k9VZVRAzgNI6PwZAtZVHoU4NeaH01NzxkJxm1Pdj2OqyPcYhfGLuD CRObA3WZQ0uLodq3zjPXwQ2mg7ZBvkozCn9v1A8pTC0u9AfVQ7QyfoKcvTu4jgt9YI1J3A bk1iHV8Sy9zoWF31LpyR5fWu4eHKq4oZEQtn3iUqQKYb6yAzXrkkr2TXNeF7Gzp8ZOfQOZ Ek7mSu2k/vLNqoB5C2hHRQccT0WshDRw520+agb4B8+XmuA0/7558YMJMDp+IA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669236683; a=rsa-sha256; cv=none; b=HmVvO5v3og8nYK3XKNGYPS/gh+cIwDXKvAZ0LfRYGVktWC5EHjimimb++J8ZljljXqVr9c 5BCLuvxDD9OKRtJP09Qc/Pl+a3Ogav9cuhDovMYtswPIYNnBABMVVKuGc4VXfV8YOZYmb0 BCqpSV5pRi4bFrgxfJpmyesqx4rdKRN/NrF3795L2tZ8RWXMQrucbmZJn6N6M5BlQUuxjN 1iVdjT0lxwCU7FSI705B2lpn1ENkiq1RHB2xsI8Z5qCDUUH3j+5+I+xDGMY5hOkAcQJSfc ia7qa2h5HAWkgE9ep6Bce04V5sf0I1aMeB51jGRUcQpK/5go87PHEbRcQFm+zQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NexWQECi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NexWQECi; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 749243BE2E X-Spam-Score: 6.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: oT7wUUAwEOJG Hi Chris, On Wed, 23 Nov 2022 at 10:49, Christopher Baines wrote: > +For a minority of changes, it can be appropriate to push them directly > +without sending them for review. This includes both trivial changes > +(e.g. fixing typos) but also reverting problomatic changes and -^ > +addressing regressions. > -For patches that just add a new package, and a simple one, it's OK to > -commit, if you're confident (which means you successfully built it in a > -chroot setup, and have done a reasonable copyright and license > -auditing). Likewise for package upgrades, except upgrades that trigger > -a lot of rebuilds (for example, upgrading GnuTLS or GLib). We have a > -mailing list for commit notifications (@email{guix-commits@@gnu.org}), > -so people can notice. Before pushing your changes, make sure to run > -@code{git pull --rebase}. > +In general though, all changes should be posted to > +@email{guix-patches@@gnu.org}. This mailing list fills the > +patch-tracking database (@pxref{Tracking Bugs and Patches}). Leave time > +for a review, without committing anything (@pxref{Submitting Patches}). > +If you didn=E2=80=99t receive any reply after one week (two weeks for mo= re > +significant changes), and if you're confident, it's OK to commit. I would write: =E2=80=A6 changes), and if you're confident (which means you successfully built it in a chroot setup, and have done a reasonable copyright and license auditing), it=E2=80=99s OK to comm= it. and I would keep the =C2=ABtwo weeks=C2=BB instead of the =C2=ABone week ex= cept=C2=BB. I think it is also useful to provide the information about commit notifications (guix-commits mailing list). For what it is worth, I find clearer the structure, For patches that =E2=80=A6 For anything else, =E2=80=A6 or For a minority of changes, =E2=80=A6 For anything else, =E2=80=A6 than =C2=ABIn general though, all changes =E2=80=A6=C2=BB. Cheers, simon