all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / Atom feed
* bug#24083: guix lint doesn't actually fail on some errors
@ 2016-07-26 22:25 Danny Milosavljevic
  2016-07-27 20:57 ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Danny Milosavljevic @ 2016-07-26 22:25 UTC (permalink / raw)
  To: 24083

guix lint doesn't actually fail on some errors.

$ guix lint perl-io-socket-inet6 ; echo $?
;;; note: source file /x/home/dannym/src/guix/gnu/packages/networking.scm
;;;       newer than compiled /x/home/dannym/src/guix/gnu/packages/networking.go
;;; note: source file /x/home/dannym/src/guix/gnu/packages/mail.scm
;;;       newer than compiled /x/home/dannym/src/guix/gnu/packages/mail.go
;;; note: source file /x/home/dannym/src/guix/gnu/packages/ldc.scm
;;;       newer than compiled /x/home/dannym/src/guix/gnu/packages/ldc.go
gnu/packages/networking.scm:437:1: perl-io-socket-inet6-2.72: line 464 is way too long (96 characters)
gnu/packages/networking.scm:437:1: perl-io-socket-inet6-2.72: line 483 is way too long (92 characters)
0
^--- ooops

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24083: guix lint doesn't actually fail on some errors
  2016-07-26 22:25 bug#24083: guix lint doesn't actually fail on some errors Danny Milosavljevic
@ 2016-07-27 20:57 ` Ludovic Courtès
  2016-07-27 21:12   ` Danny Milosavljevic
  2021-06-09 21:41   ` zimoun
  0 siblings, 2 replies; 5+ messages in thread
From: Ludovic Courtès @ 2016-07-27 20:57 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 24083

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> guix lint doesn't actually fail on some errors.

It never pretended to exit with non-zero when warnings are emitted.  :-)
(These are warnings, not errors.)

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24083: guix lint doesn't actually fail on some errors
  2016-07-27 20:57 ` Ludovic Courtès
@ 2016-07-27 21:12   ` Danny Milosavljevic
  2021-03-24 22:19     ` zimoun
  2021-06-09 21:41   ` zimoun
  1 sibling, 1 reply; 5+ messages in thread
From: Danny Milosavljevic @ 2016-07-27 21:12 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 24083

On Wed, 27 Jul 2016 22:57:15 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Danny Milosavljevic <dannym@scratchpost.org> skribis:
> 
> > guix lint doesn't actually fail on some errors.  
> 
> It never pretended to exit with non-zero when warnings are emitted.  :-)
> (These are warnings, not errors.)

Too bad :)

I wrote a little helper script which was supposed to prevent me from posting packages that don't build or lint. Then I found out that the lint actually doesn't fail on warnings. So now my script is only half as useful (the builder does fail on build error).

It would be nice to have a way to also check the lint status.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24083: guix lint doesn't actually fail on some errors
  2016-07-27 21:12   ` Danny Milosavljevic
@ 2021-03-24 22:19     ` zimoun
  0 siblings, 0 replies; 5+ messages in thread
From: zimoun @ 2021-03-24 22:19 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 24083

Hi,

On Wed, 27 Jul 2016 at 23:12, Danny Milosavljevic <dannym@scratchpost.org> wrote:
> On Wed, 27 Jul 2016 22:57:15 +0200 ludo@gnu.org (Ludovic Courtès) wrote:
>> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>> 
>> > guix lint doesn't actually fail on some errors.  
>> 
>> It never pretended to exit with non-zero when warnings are emitted.  :-)
>> (These are warnings, not errors.)
>
> Too bad :)
>
> I wrote a little helper script which was supposed to prevent me from posting
> packages that don't build or lint. Then I found out that the lint actually
> doesn't fail on warnings. So now my script is only half as useful (the builder
> does fail on build error).
>
> It would be nice to have a way to also check the lint status.

The good news is that the initial example ’perl-io-socket-inet6’ now
does not report any linting error. :-)

Well, on the other side, it is still the same behaviour.

--8<---------------cut here---------------start------------->8---
$ guix lint julia ; echo $?
gnu/packages/julia.scm:301:0: julia@1.5.3: line 301 is way too long (107 characters)
gnu/packages/julia.scm:303:0: julia@1.5.3: line 303 is way too long (106 characters)
gnu/packages/julia.scm:226:13: julia@1.5.3: can be upgraded to 1.6.0
gnu/packages/julia.scm:227:12: julia@1.5.3: source not archived on Software Heritage
0
--8<---------------cut here---------------end--------------->8---

What do we do.  On one hand, «it never pretended to exit with non-zero
when warninf» and on the other hand it could be annoying.

Well, since it is 4 years and 34 weeks, I consider it is not a big deal
and so we can close.  WDYT?


All the best,
simon




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24083: guix lint doesn't actually fail on some errors
  2016-07-27 20:57 ` Ludovic Courtès
  2016-07-27 21:12   ` Danny Milosavljevic
@ 2021-06-09 21:41   ` zimoun
  1 sibling, 0 replies; 5+ messages in thread
From: zimoun @ 2021-06-09 21:41 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 24083

Hi,

On Wed, 27 Jul 2016 at 22:57, ludo@gnu.org (Ludovic Courtès) wrote:
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
>> guix lint doesn't actually fail on some errors.
>
> It never pretended to exit with non-zero when warnings are emitted.  :-)
> (These are warnings, not errors.)

Do we modify the returned code?  If not, can we close?

Cheers,
simon




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-09 21:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-26 22:25 bug#24083: guix lint doesn't actually fail on some errors Danny Milosavljevic
2016-07-27 20:57 ` Ludovic Courtès
2016-07-27 21:12   ` Danny Milosavljevic
2021-03-24 22:19     ` zimoun
2021-06-09 21:41   ` zimoun

all messages for Guix-related lists mirrored at yhetil.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix

Example config snippet for mirrors.


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git